Mary Guillemard
631bea2e02
nak: Simplify 16-bit vector selection to not use try_from
...
Signed-off-by: Mary Guillemard <mary.guillemard@collabora.com >
Reviewed-by: M Henning <drawoc@darkrefraction.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32679 >
2024-12-23 11:47:49 +01:00
Mary Guillemard
979dfaf0bb
nak: Fix 8-bit selection for vectors
...
This fix at least permutation issues on vec16 of 8-bits values for
cooperative matrix.
Fixes: 9e84e9e44b ("nak: Add base support for 8 and 16-bit types")
Suggested-by: M Henning <drawoc@darkrefraction.com >
Signed-off-by: Mary Guillemard <mary.guillemard@collabora.com >
Reviewed-by: M Henning <drawoc@darkrefraction.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32679 >
2024-12-23 11:47:32 +01:00
Samuel Pitoiset
2c323f2b8c
radv: rename color output state to fragment output state
...
Now that it also exports depth.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32675 >
2024-12-23 08:09:26 +00:00
Samuel Pitoiset
47dc9ca512
radv: rework emitting SPI_SHADER_Z_FORMAT
...
This fixes a small issue when the Z format in PS epilogs change, like
when alpha-to-coverage is enabled and then disabled.
igned-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32675 >
2024-12-23 08:09:26 +00:00
Daniel Schürmann
28a214728c
ac/lower_ngg: move readlane into break blocks in streamout code generation for gfx12/ACO
...
This avoids unnecessary shuffle code and s_wait_loadcnt.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32743 >
2024-12-21 12:32:25 +00:00
Daniel Schürmann
47227089d6
ac/lower_ngg: move break blocks after loop in streamout code generation for gfx12/ACO
...
By inverting the break condition, the loop becomes shorter.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32743 >
2024-12-21 12:32:25 +00:00
Daniel Schürmann
39dcd9dedb
ac/lower_ngg: Fix collecting buffer offsets from 4 lanes on gfx12
...
Also use readlane for improved performance.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32743 >
2024-12-21 12:32:25 +00:00
David Rosca
ed58b869e1
frontends/va: Don't allow EndPicture without calling driver begin_frame
...
This can happen in decode context when application send no slice
buffers or in processing context with no processing buffers.
We need to avoid calling driver end_frame as no begin_frame will be
called in this case.
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32677 >
2024-12-21 09:34:01 +00:00
David Rosca
42e765d48b
frontends/va: Don't allow Render/EndPicture without BeginPicture
...
It's not valid to call RenderPicture and EndPicture without calling
BeginPicture or when BeginPicture fails. FFmpeg will however call
EndPicture when BeginPicture fails, so we need to handle this.
Use target_id, which is assigned in BeginPicture, as an indication
whether we are inside the Begin - End picture sequence.
Cc: mesa-stable
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32677 >
2024-12-21 09:34:01 +00:00
David Rosca
6e911cf252
frontends/va: Fix decoding VC1 interlaced video
...
VC1 has different start code for FRAME and FIELD, so we need to use
FIELD start code for second field.
Also simplify start code search to only look for 00 00 01.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/2347
Cc: mesa-stable
Reviewed-by: David (Ming Qiang) Wu <David.Wu3@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32741 >
2024-12-21 08:54:41 +00:00
Patrick Lerda
ad5c47502d
r600: reverse fix spec ext_packed_depth_stencil getteximage
...
This change reverses d19e2597ce which is now superseded on the mesa
development branch by 42be38a8fb ("radeon/evergreen: ensure equal
sizes for depth-stencil npot textures").
Signed-off-by: Patrick Lerda <patrick9876@free.fr >
Reviewed-by: David Heidelberg <None>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32553 >
2024-12-21 05:07:16 +00:00
Alyssa Rosenzweig
83a7d9a814
hk: fix primitive restart dirty tracking
...
the previous logic was busted with the sequence Dolphin emits:
BeginRender
BindIndex
Draw
EndRender
BeginRender
Draw without restart
Draw with restart
EndRender
the second control stream would not have any restart index emitted, since the
dirty flag is set only on Begin and Bind, and cleared on draw.
this was probably also broken in the similar case
BeginRender
BindIndex
Draw without restart
Draw with restart
EndRender
fixes Zelda: Wind Waker, Xeno Blade, etc.
thank you to pokechu22 for debug help!
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:32 +00:00
Alyssa Rosenzweig
c585681378
hk: avoid compiling unneeded VS->GS variants
...
this should reduce pipeline compile time and memory bloat, now that we have no
non-XFB passthrough GS's.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:32 +00:00
Alyssa Rosenzweig
07e1b523b9
libagx: use designated initializers
...
these work now :-)
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:32 +00:00
Alyssa Rosenzweig
a3b796ba19
libagx,hk: handle pipeline stats queries without a GS
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:32 +00:00
Alyssa Rosenzweig
5bc89aa991
hk,libagx: handle adjacency without a GS
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:32 +00:00
Alyssa Rosenzweig
872487919b
hk,libagx: accelerate index buffer robustness
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:32 +00:00
Alyssa Rosenzweig
f106451a90
hk: factor out hk_draw_as_indexed_indirect
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:32 +00:00
Alyssa Rosenzweig
954080275b
hk: use index buffer overflow check
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:31 +00:00
Alyssa Rosenzweig
e0cfc5eac1
libagx: factor out load/store_index
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:31 +00:00
Alyssa Rosenzweig
ff7abb1e22
libagx: refactor index buffer code
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:31 +00:00
Alyssa Rosenzweig
686daf2524
libagx: move index size helpers to the gpu
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:31 +00:00
Alyssa Rosenzweig
b5d41bc0fb
agx: match another address pattern
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:31 +00:00
Alyssa Rosenzweig
7626e40506
asahi: reformat
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:31 +00:00
Alyssa Rosenzweig
fc4e533709
agx: add more 8-bit address fusing rules
...
helps kernel I'm writing
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:31 +00:00
Alyssa Rosenzweig
e110b8f2c9
libagx: add missing agx_vdm_return
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:31 +00:00
Alyssa Rosenzweig
b6dbfe822b
asahi: use common draw
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:31 +00:00
Alyssa Rosenzweig
b9155de0a1
hk,libagx: move hk_draw to the gpu
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:31 +00:00
Asahi Lina
c80c56a315
asahi: hk: Enable timestamps for virt
...
Signed-off-by: Asahi Lina <lina@asahilina.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:31 +00:00
Asahi Lina
e281293508
asahi: Virt UABI update
...
Support timestamp extensions & fix a bunch of missing/broken things we
were dragging along.
Signed-off-by: Asahi Lina <lina@asahilina.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:31 +00:00
Alyssa Rosenzweig
0d5db3238b
asahi: fix mmap'ing imported BOs
...
bo->dev wasn't being set on the import path. apparently mmap'ing imported BOs is
really rare, so this slipped through. should address segfaults with gnome
settings.
Reported-by: girona
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:31 +00:00
Eric R. Smith
4533144608
panfrost: apply DEPTH_STENCIL flag consistently
...
We were inconsistent over the usage of PAN_BIND_DEPTH_STENCIL, putting
it on some stencil only formats but not others. Apply it to all
stencil formats. However, we also need to change is_format_supported
to ignore S8_UINT (at least for GLES), because the hardware is a little
weird with that format and the gallium driver gets confused by it.
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32462 >
2024-12-20 23:18:08 +00:00
Eric R. Smith
b6ade2714c
panvk: fix fs_required()
...
If the sample mask is updated, we have to run the fragment
shader, so make sure this is reflected in fs_required()
Signed-off-by: Eric R. Smith <eric.smith@collabora.com >
Co-authored-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32462 >
2024-12-20 23:18:08 +00:00
Caio Oliveira
5c0c3120ca
intel/brw: Use variable instead of manually count the passes
...
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32709 >
2024-12-20 22:41:20 +00:00
Caio Oliveira
ada898bb1c
intel/brw: Disallow cmod in some cases of ARF scalar as destination
...
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32758 >
2024-12-20 14:03:15 -08:00
Francisco Jerez
43d59c6186
intel/brw/xe3+: Relax SEND EOT register assignment restrictions.
...
These restrictions have been removed from the hardware. Make the code
enforcing and validating them conditional.
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32758 >
2024-12-20 14:03:15 -08:00
nyanmisaka
8a5ec60442
frontends/vdpau: Get AV1 decode subsampling_x/y
...
The VDPAU frontend requires similar changes as in the VAAPI frontend.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12337
Signed-off-by: nyanmisaka <nst799610810@gmail.com >
Reviewed-by: David Rosca <david.rosca@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32752 >
2024-12-20 16:36:42 +00:00
Rohan Garg
9a4f5b739e
intel/compiler: disable mesh autostrip for WA 16020916187
...
Disable mesh autostrip for platforms that need WA 16020916187.
Additionally, zero out the layer and viewport slots when a shading rate
is found through the brw_nir_initialize_mue pass.
Signed-off-by: Rohan Garg <rohan.garg@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32751 >
2024-12-20 17:02:20 +01:00
Erik Faye-Lund
b180e2a47c
panvk/ci: update expected failures
...
Acked-by: Valentine Burley <valentine.burley@collabora.com >
Acked-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32748 >
2024-12-20 14:52:25 +01:00
David Rosca
5621ce10a6
radeonsi/vcn: Return error when decoding 12bit VP9 and 4:2:2/4:4:4 AV1
...
This is not supported by VCN.
We indicate this limitation by not reporting YUV420_12 RT format
supported for VP9, and not reporting YUV422 and YUV444 for AV1.
Most applications however simply ignore this, and will pick some other
format that is supported, which obviously won't work.
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32663 >
2024-12-20 10:51:18 +00:00
David Rosca
245d8c8e99
frontends/va: Get AV1 decode subsampling_x/y
...
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32663 >
2024-12-20 10:51:18 +00:00
David Rosca
d94597a2d8
pipe: Remove PIPE_DEFAULT_DECODER_FEEDBACK_TIMEOUT_NS
...
Use OS_TIMEOUT_INFINITE instead.
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32705 >
2024-12-20 11:19:49 +01:00
David Rosca
c03805e4f5
radeonsi/vcn: Use local variable for destory fence
...
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32705 >
2024-12-20 11:19:05 +01:00
David Rosca
fed1ed1eff
radeonsi/vcn: Don't keep last fence
...
This is not needed after 0c024bbe64 ("radeonsi/vcn: Add decode DPB buffers as CS dependency")
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32705 >
2024-12-20 11:18:23 +01:00
Peyton Lee
ad0dbea49d
radeonsi/vpe: add destroy_fence function
...
implement destroy_fence() for better fence control
Signed-off-by: Peyton Lee <peytolee@amd.com >
Reviewed-by: David Rosca <david.rosca@amd.com >
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32648 >
2024-12-20 09:55:00 +00:00
Marek Olšák
1e14b00e8b
gallium: pass XFB primitive mode to set_stream_output_targets
...
radeonsi would like to know the prim mode. GL always knows it,
so let's pass it through.
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32685 >
2024-12-20 08:22:52 +00:00
Marek Olšák
e22b78a196
mesa: fix printing _NEW_* flags
...
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32685 >
2024-12-20 08:22:52 +00:00
Marek Olšák
b2ddf85591
mesa: set correct XFB prim mode for draw validation after resuming XFB
...
Draws were validated against an XFB primitive type from the last
glBeginTransformFeedback call, ignoring glResumeTransformFeedback that
may have been after it that may have resumed for a different primitive
type.
The spec doesn't state this explicitly, but it's logical.
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32685 >
2024-12-20 08:22:52 +00:00
Marek Olšák
227f69716f
st/mesa: don't use nir_opt_fragdepth because it's incorrect with MSAA
...
Doing "gl_FragDepth = gl_FragCoord.z" with MSAA and without sample shading
changes per-sample depth testing to per-pixel depth testing, so we can't
eliminate it.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12079
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32685 >
2024-12-20 08:22:52 +00:00
Samuel Pitoiset
a7d0f0b30e
radv: check descriptor indexing features for enabling the global BO list
...
It's more accurate.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32718 >
2024-12-20 07:43:59 +00:00