AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
211,841 Commits 1 Branch 0 Tags
6281a128227fdbd6e10fe33c3d8d540bc05d7ffa
Commit Graph

21 Commits

Author SHA1 Message Date
Kenneth Graunke 3c455c3532 brw: Stop using is_send_from_grf() in CSE pass 
Explicitly list FS_OPCODE_INTERPOLATE_AT_* as allowed, as they were
already allowed by the default case.  Interlock, memory fence, and
barrier were disallowed and remain so.  Uniform pull constant load
was allowed and remains so.  SHADER_OPCODE_SEND and SEND_GATHER get
explicit handling.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34040>
 2025-08-08 22:12:05 +00:00
Iván Briano 29d7b90cfc brw: make HALT instruction act as barrier in new CSE pass 
This brings back c9e33e5cbf ("intel/fs/cse: Make HALT instruction act
as CSE barrier."), from the old CSE pass into the new one.

Fixes new CTS test: dEQP-VK.subgroups.shader_quad_control.terminated_invocation

Fixes: 9690bd369d ("intel/brw: Delete old local common subexpression elimination pass")
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34643>
 2025-04-29 20:28:24 +00:00
Caio Oliveira 63224f64cc brw: Remove adjust_block_ips and brw_inst::remove() with defer 
Now that the brw_ip_ranges analysis is being used, there's no
need to track start_ip/end_ips in the blocks as they are mutate.  And
also no need to call adjust_block_ips at the end of some passes.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34012>
 2025-03-29 00:25:51 +00:00
Caio Oliveira 308f56ef82 brw: Add missing dependency classes to various passes 
- brw_lower_3src_null_dest: Allocating a new destination, so include
  INSTRUCTION_DATA_FLOW class.

- brw_lower_alu_restriction: Removing instruction, so include
  INSTRUCTION_IDENTITY.  No details are changed so remove
  INSTRUCTION_DETAIL.

- brw_lower_vgrfs_to_fixed_grfs: Changing source and destination
  numbers, so include INSTRUCTION_DETAIL.

- brw_lower_send_gather: Insert new instructions (scalar register) and
  change sources and other information on existing ones.  So include
  INSTRUCTION_DETAIL and INSTRUCTION_IDENTITY.  Promote to INSTRUCTIONS.

- brw_opt_eliminate_find_live_channel: Can change source, so include
  INSTRUCTION_DATA_FLOW.

- brw_opt_copy_propagation_defs and brw_opt_cse_defs: Both can remove
  instructions, so include INSTRUCTION_IDENTITY.  Promote to
  INSTRUCTIONS.

- brw_opt_saturate_propagation: Instruction can have `sat` modified,
  and operands can have type modified, so include INSTRUCTION_DETAIL.

Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33993>
 2025-03-12 22:44:10 +00:00
Caio Oliveira 66307811c3 brw: Remove block parameter from brw_inst::remove() 
Use brw_inst::block instead.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33815>
 2025-03-06 23:33:38 +00:00
Caio Oliveira 7924d48bcd brw: Use brw_inst::block in CSE 
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33815>
 2025-03-06 23:33:38 +00:00
Caio Oliveira 07d0af763d brw: Use brw_inst::block in Def analysis 
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33815>
 2025-03-06 23:33:38 +00:00
Caio Oliveira cf3bb77224 intel/brw: Rename fs_visitor to brw_shader 
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32536>
 2025-02-11 09:13:28 +00:00
Caio Oliveira 352a63122f intel/brw: Rename files brw_fs.cpp/h to brw_shader.cpp/h 
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32536>
 2025-02-11 09:13:28 +00:00
Kenneth Graunke accef5e8f5 brw: Replace fs_inst::target field with logical FB read/write sources 
We can just specify this as a source to the logical FB read/write
opcodes.  Notably FB reads had no sources before; now they have one.

Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33297>
 2025-02-08 01:07:22 +00:00
Caio Oliveira 5c717e68ce intel/brw: Pass fs_visitor around instead of the simple_allocator 
In preparation for getting rid of the simple_allocator.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33334>
 2025-02-06 08:33:03 -08:00
Caio Oliveira ea87bab4ce intel/brw: Remove 'using namespace brw' directives 
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33418>
 2025-02-06 07:58:55 -08:00
Caio Oliveira 1ade9a05d8 intel/brw: Use brw prefix instead of namespace for analysis implementations 
Also drop the 'fs' prefix when applicable.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33048>
 2025-02-05 21:47:07 +00:00
Caio Oliveira 2b92eb0b2c intel/brw: Use brw prefix instead of namespace for dep analysis enum 
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33048>
 2025-02-05 21:47:07 +00:00
Caio Oliveira d59bd421a2 intel/brw: Rename fs_inst to brw_inst 
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33114>
 2025-01-31 00:57:21 +00:00
Lionel Landwerlin 2e4dcf72c6 brw: fix CSE with negation 
The pass is currently turning this :

mul(16) %17:F, %1:F, 0.5f
mul(16) %19:F, %1:F, -0.5f
(+f0.0) sel(16) %27:UD, %19:UD, %17:UD

into this :

{ 12} mul(16) %17:F, %1:F, 0.5f
{ 14} (+f0.0) sel(16) %27:UD, -%17:F, %17:UD

The type change in the SEL instruction incurs a type conversion that
produces invalid values.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: 234c45c929 ("intel/brw: Write a new global CSE pass that works on defs")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12477
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33070>
 2025-01-23 12:45:34 +00:00
Caio Oliveira 5ac82efd35 intel/brw: Rename fs_builder to brw_builder 
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33076>
 2025-01-18 16:12:55 +00:00
Caio Oliveira f2d4c9db92 intel/brw: Rename brw_fs_builder.h to brw_builder.h 
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33076>
 2025-01-18 16:12:54 +00:00
Kenneth Graunke 36d0485ae4 brw: Allow CSE of MEMORY_MODE_CONSTANT loads 
This matches the behavior of FS_OPCODE_UNIFORM_PULL_CONSTANT_LOAD.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32888>
 2025-01-10 22:44:09 +00:00
Caio Oliveira e1aebf8a0c intel/brw: Remove 'fs' prefix from passes and related functions 
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32813>
 2025-01-02 18:11:05 +00:00
Caio Oliveira 25384dccc0 intel/brw: Remove 'fs' prefix from passes filenames 
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32813>
 2025-01-02 18:11:05 +00:00