Add additional checks for the *DRIRec info structure passed in from the
device driver. This ensures that things fallback to indirect rendering if
the DDX driver has had modifications (i.e. removal of the drmAddress field).
extension wasn't enabled. I have verified its correct function with Mesa's
stencil_wrap test. It is enabled on both Savage4 and Savage3D. Since
Savage3D uses a software fallback for *all* stencil operations, this is safe.
should be defined. It was flawed on some platforms (e.g., Darwin & mingw).
Instead, rely on the build system to define it on the compiler command line.
This also reverts ajax's hand-edit to indirect_size.c. I'll fix that on the
X.org side of things later today.
proper DRM_CAS_RESULT to declare the variable used to store the result
of DRM_CAS. Second, only use the "real" versions of LOCK_HARDWARE and
UNLOCK_HARDWARE on SPARC. That's the only platform where the hardware
can really exist.
the driver. The loader now takes care of this for the driver.
Remove _glapi_DispatchTSD and give _glapi_Dispatch its semantic (i.e.,
having a NULL value means that the application is multithreaded and
_glapi_get_dispatch must be called).
Gut all of the dispatch override code. This removes _glapi_RealDispatch,
_glapi_tls_RealDispatch, _glapi_begin_dispatch_override,
_glapi_end_dispatch_override, and _glapi_get_override_dispatch.
Remove _glapi_get_proc_address, _glapi_get_proc_name, _glapi_get_version,
and _glapi_check_table from the loader / driver interface.
Reviewed by: Brian Paul
attributes in display lists. If a driver doesn't add entry points for
GL_NV_vertex_program, it will explode. This patch adds GL_NV_vertex_program
to the list of default extensions whose entry points are added by
driInitExtensions.
Thanks go to Roland Scheidegger for tracking the problem down and suggesting
the fix.
Make sure that all the values used in the clean-up code are initialized at
some point. It is still unclear to me as to why GCC does not complain. I
suspect the problem may be due to the depth of if-statement nesting.
The weak version of _glapi_DispatchTSD was removed from dri_util.c. As
stated in the bug report, this was only needed to support versions of libGL
that did not have this symbol. Versions of libGL without this symbol are no
longer supported at all, so it is totally irrelevant.
direct-rendering is possible on a given screen. It is not possible to
determine this by just looking at driDisplay.private in the display
structure. However, it is possible to determine this by looking at
driScreen.private in the screen structure. This field is only non-NULL if a
DRI driver has been successfully loaded and bootstrapped. Once we get to
that point, we know that direct-rendering is at least theoretically
possible.
This fixes bugzilla #2875.
CALL_by_offset, SET_by_offset, and GET_by_offset all had various problems.
The core issue is that parts of the device-independent code in Mesa assumes
that all functions have slots in the dispatch table. This is especially
true in the display list code. It will merrilly try to set dispatch
pointers for glVertexAttrib1fARB even if GL_ARB_vertex_program is not
supported. When the GET/SET/CALL macros are invoked, they would read a 0
from the remap table. The problem is that 0 is the dispatch offset for
glNewList!
One change is that the remap table is now initialized to be full of -1
values. In addtion, all of the *_by_offset marcos misbehave in an obvious
way if the specified offset is -1. SET_by_offset will do nothing,
GET_by_offset will return NULL, and CALL_by_offset, since it uses
GET_by_offset, will segfault.
I also had to add GL_EXT_blend_func_separate to the list of default
extensions in all_mesa_extensions (src/mesa/drivers/dri/common/utils.c).
Even though many drivers do not export this extension, glBlendFunc is
internally implemented by calling glBlendFuncSeparate. Without this
addition, glBlendFunc stopped working on drivers (such as mga) that do not
export GL_EXT_blend_func_separate.
There are still a few assertions / crashes in GL_ARB_vertex_program tests,
but I don't think that these are related to any of my changes.
DRI drivers using the "old" interface relied on certain fields being at
certain offsets. Removing the structures would break that. Now that the
old interface is no longer supported, the dead data can finally die.
linux-dri, but it disables support for direct-rendering in it. This config
mainly exists so that I can verify that changes to libGL haven't broken
builds on non-DRI platforms.
Ian Romanick