Emma Anholt
46498abbac
symbol_table: Don't bother resetting the key on popping scope.
...
If you made a same-name symbol, then its name was just the name from the
parent scope anyway.
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22451 >
2023-04-15 18:33:25 +00:00
Emma Anholt
0a400f933f
symbol_table: Don't maintain the HT as we're destroying the table.
...
Release Mesa build runtime of
KHR-Single-GL46.arrays_of_arrays_gl.SizedDeclarationsPrimitive -5.05801%
+/- 3.41206% (n=12)
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22451 >
2023-04-15 18:33:25 +00:00
Emma Anholt
6db7d72b4b
symbol_table: Store the symbol name in the same allocation as the symbol entry.
...
Saves an extra malloc. Release Mesa build runtime of
KHR-Single-GL46.arrays_of_arrays_gl.SizedDeclarationsPrimitive (which is a
lot of GLSL 4.60 builtin vars symbol table setup) -5.15821% +/- 3.19636%
(n=13).
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22451 >
2023-04-15 18:33:25 +00:00
David Heidelberg
c690644842
ci/amd: update checksums after DXVK 2.1 update
...
Heaven got fixed with DXVK 2.1.
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22447 >
2023-04-15 10:57:06 +00:00
David Heidelberg
5cf3b92661
ci/dxvk: uprev to 2.1
...
Major uprev, requires VK 1.3 now.
Acked-by: Martin Roukala <martin.roukala@mupuf.org >
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22447 >
2023-04-15 10:57:06 +00:00
David Heidelberg
0dcb3994a5
ci/amd: 4/5 runners TPad-C13 runners are online, restore most of the tests
...
Partial revert of 590959057c ("ci/amd: raven is currently downgraded
to 2 machines only, adapt")
Test which remains disabled: radeonsi-raven-va:amd64 (VAAPI testing).
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22447 >
2023-04-15 10:57:06 +00:00
Lionel Landwerlin
a787728906
anv: enable blorp query reset for performance queries
...
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Felix DeGrood <felix.j.degrood@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22480 >
2023-04-15 12:25:57 +03:00
Michel Dänzer
20c330e95d
ci: Drop executable permissions from backend compiler wrapper script
...
Not needed anymore, since the frontend scripts just source the backend
script now.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22438 >
2023-04-15 01:55:12 +00:00
Michel Dänzer
1ec3c16c54
ci: Remove shebang from backend compiler wrapper script
...
Not needed anymore, since the frontend scripts just source the backend
script now.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22438 >
2023-04-15 01:55:12 +00:00
Michel Dänzer
21b190bf44
ci: Use set -e in frontend compiler wrapper scripts.
...
I doubt the shebang line in the backend script has any effect now,
since the frontend scripts just source it directly.
v2:
* Use "set -e" instead of adding -e to shebang (Eric Engestrom)
v3:
* Apply to the clang wrapper scripts as well (Eric Engestrom)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22438 >
2023-04-15 01:55:12 +00:00
Michel Dänzer
1915185648
ci: Explicitly test for meson feature checks in compiler wrapper
...
The previous indirect method was more complicated and still error prone.
v2:
* Use "grep -E" (Eric Engestrom)
* Exclude spaces and slashes in the grep pattern, to avoid accidentally
matching across unrelated compiler arguments.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22438 >
2023-04-15 01:55:12 +00:00
Jesse Natalie
2fbedd442a
util: Delete Offset() macro from u_memory.h
...
Reviewed-by: Giancarlo Devich <gdevich@microsoft.com >
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22494 >
2023-04-15 00:54:16 +00:00
Caio Oliveira
7706d1cc33
spirv/tests: Add test for single-block loop
...
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22509 >
2023-04-15 00:17:15 +00:00
Jesse Natalie
5672b6cb02
dzn: Remove #if D3D12_SDK_VERSION blocks now that 610 is required
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22504 >
2023-04-14 23:59:33 +00:00
Jesse Natalie
290bb7a706
microsoft/clc: Remove #if D3D12_SDK_VERSION blocks now that 610 is required
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22504 >
2023-04-14 23:59:33 +00:00
Jesse Natalie
27c304be2e
d3d12: Remove #if D3D12_SDK_VERSION blocks now that 610 is required
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22504 >
2023-04-14 23:59:33 +00:00
Luc Ma
b5a9021708
meson: keep Mako version checking in accord with build msg
...
Fixes: 52194ae4df ("meson: Ensure that mako is >= 0.8.0")
Signed-off-by: Luc Ma <luc@sietium.com >
Reported-by: Terry Zhang <terry@sietium.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22499 >
2023-04-14 23:16:01 +00:00
Sathishkumar S
8f0da0851f
radeonsi/vcn: engage all jpeg engines on gfx940 for mjpeg decode
...
engage all available jpeg engines to decode mjpeg video frames
Signed-off-by: Sathishkumar S <sathishkumar.sundararaju@amd.com >
Reviewed-by: Leo Liu <leo.liu@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22388 >
2023-04-14 22:30:44 +00:00
Sathishkumar S
87a44c44b4
radeonsi/vcn: enable RGBP format on gfx940 jpeg
...
decode output format conversion to RGBP is supported on gfx940 jpeg.
Signed-off-by: Sathishkumar S <sathishkumar.sundararaju@amd.com >
Reviewed-by: Leo Liu <leo.liu@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22388 >
2023-04-14 22:30:44 +00:00
Sathishkumar S
bdb7f36aa8
frontends/va: add support for RGBP rt_format
...
check and enable RGBP rt_format and support VaImage creation for the RGBP/ARGB.
Signed-off-by: Sathishkumar S <sathishkumar.sundararaju@amd.com >
Reviewed-by: Leo Liu <leo.liu@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22388 >
2023-04-14 22:30:44 +00:00
Sathishkumar S
23580b09a3
util/format: add planar3 r8_g8_b8_unorm pipe format
...
add pipe format to represent three plane 8bit RGB format
Signed-off-by: Sathishkumar S <sathishkumar.sundararaju@amd.com >
Reviewed-by: Leo Liu <leo.liu@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22388 >
2023-04-14 22:30:44 +00:00
Felix DeGrood
33886e5ef2
docs: add INTEL_MEASURE=cpu
...
Update documentation about INTEL_MEASURE=cpu
Reviewed-by: Mark Janes <markjanes@swizzler.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21505 >
2023-04-14 21:57:50 +00:00
Felix DeGrood
b661149921
iris: Enable INTEL_MEASURE=cpu
...
Reviewed-by: Mark Janes <markjanes@swizzler.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21505 >
2023-04-14 21:57:50 +00:00
Felix DeGrood
0417cfd7a0
anv: Enable INTEL_MEASURE=cpu
...
Reviewed-by: Mark Janes <markjanes@swizzler.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21505 >
2023-04-14 21:57:50 +00:00
Felix DeGrood
55ba4575be
intel: INTEL_MEASURE cpu mode
...
INTEL_MEASURE normally measures timing of GPU events. However, it
is sometimes useful to instead measure when these gfx API calls
were requested of the driver. INTEL_MEASURE cpu can be used in
in conjunction with other driver debug capabilities, like
INTEL_DEBUG=pc for analyzing stalls/flushes or when debugger is
attached, to track which frame you're currently on or where in
the frame you're at.
Initial commit, without plumbing into anv/iris.
"INTEL_MEASURE=cpu" will collect a cpu timestamp for each
INTEL_MEASURE event instead of GPU timestamps.
Reviewed-by: Mark Janes <markjanes@swizzler.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21505 >
2023-04-14 21:57:50 +00:00
Felix DeGrood
c45dee34aa
anv: split INTEL_MEASURE multi events
...
Measure performance of each draw separately in multi_draw event.
Previously, we measured duration of the sum of all draws launched
per multi_draw. This should provide more detailed data for
multi_draws.
Reviewed-by: Mark Janes <markjanes@swizzler.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21505 >
2023-04-14 21:57:49 +00:00
Felix DeGrood
50bda45d15
anv: Add flush reason to NEEDS_END_OF_PIPE_SYNC
...
cs_stall gets inserted if both flushes and invalidates are required.
This cs_stall reason was not called out explicitly, until now.
Reviewed-by: Mark Janes <markjanes@swizzler.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21505 >
2023-04-14 21:57:49 +00:00
Felix DeGrood
bdeb849e25
anv: Add flush reasons to raytracing flushes
...
Reviewed-by: Mark Janes <markjanes@swizzler.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21505 >
2023-04-14 21:57:49 +00:00
Felix DeGrood
9a30493ccb
anv: Add END_OF_PIPE_SYNC reporting to INTEL_DEBUG=pc
...
Reviewed-by: Mark Janes <markjanes@swizzler.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21505 >
2023-04-14 21:57:49 +00:00
David (Ming Qiang) Wu
bfce57c7a5
radeonsi/vcn: add an exception of field case for h264 decoding
...
This is an error case where the I field has no reference, however
the reference list contains some reference, which resulting in
not be able to find its reference, and it is a correct behavior,
should not enter the correction code. Just add this exception to
prevent such a case, if more exceptions found, they will
be treated indiviually in the future.
Cc: mesa-stable
closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8740
Signed-off-by: Ruijing Dong <ruijing.dong@amd.com >
Signed-off-by: David (Ming Qiang) Wu <David.Wu3@amd.com >
Reviewed-by: Leo Liu <leo.liu@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22485 >
2023-04-14 21:03:43 +00:00
Roland Scheidegger
f23d54cfaa
llvmpipe: fix some corner cases with line rendering
...
Some comparisons were wrong depending on swapped endpoints and
the bottom_edge_rule (if the endpoint was exactly touching
pixel center), hence the code assuming a line endpoint which
should be drawn according to diamond exit rules would already be
drawn (so not adjusting the endpoint) when in reality it was not,
in which case the line would end up one pixel too short.
Note that this is still not fully correct - the logic as such
should be correct now, however these comparisons can give wrong
results due to float math vs. fixed point planes (an endpoint very
close to a pixel center might be exactly at pixel center in fixed
point), but this should do for now. (Also, the logic is still
completely wrong for state trackers not using half_pixel_center
setting, but this is only really a concern for dx9 state tracker.)
Reviewed-by: Brian Paul <brianp@vmware.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22481 >
2023-04-14 20:41:09 +00:00
Roland Scheidegger
9b6abe4206
llvmpipe: minor cleanups in line rendering code
...
Use float constants, some code deduplication, no functional change.
Reviewed-by: Brian Paul <brianp@vmware.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22481 >
2023-04-14 20:41:09 +00:00
Juan A. Suarez Romero
82c2258019
v3d: set depth compare function correctly
...
Depth compare function must be set to the configured one only when
compare mode is enabled; otherwise it must be configured to never.
v2 (Eric):
- Handle V3D < 4.0 case
CC: mesa-stable
Reviewed-by: Eric Engestrom <eric@igalia.com >
Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22470 >
2023-04-14 20:20:43 +00:00
antonino
c84989c4cf
zink: use correct primitives for passthrough gs with tess
...
When tessellation is used the geometry shader needs to take the
tessellator output primitive as input.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Fixes: 90a8525d70 ("zink: handle edgeflags")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22498 >
2023-04-14 19:22:48 +00:00
antonino
7e6191f605
zink: don't emulate edgeflags for patches
...
Patches are used for tessellation, edgeflags don't work with
tessellation.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Fixes: 90a8525d70 ("zink: handle edgeflags")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22498 >
2023-04-14 19:22:48 +00:00
Samuel Pitoiset
3ad751f043
radv: tidy up dirtying RBPLUS state in radv_bind_dynamic_state()
...
To dirty driver specific states at the same place.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22472 >
2023-04-14 17:49:23 +00:00
Samuel Pitoiset
ba71b142f8
radv: re-emit the guardband state when related PSO are bound
...
If one of the related states is static, the guardband state needs to be
re-emitted when a graphics pipeline is bound.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8828
Fixes: 40d8df7280 ("radv: emit the guardband state separately from the scissor state")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22472 >
2023-04-14 17:49:23 +00:00
Patrick Lerda
28cb33fada
r600: fix refcnt imbalance related to r600_set_vertex_buffers()
...
For instance, this issue is triggered with: "piglit/bin/useprogram-flushverts-2 -auto -fbo" or
"piglit/bin/primitive-restart-draw-mode line_loop -auto"
while setting GALLIUM_REFCNT_LOG=refcnt.log.
Fixes: 27dcb46629 ("gallium: add take_ownership param into set_vertex_buffers to eliminate atomics")
Signed-off-by: Patrick Lerda <patrick9876@free.fr >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22395 >
2023-04-14 16:48:09 +00:00
James Knight
cd861b7f38
meson: ensure i915 Gallium driver includes Intel sources
...
Ensure builds flag the use of Intel sources when the i915 Gallium driver
is configured (`-Dgallium-drivers=i915`). Otherwise, a build may fail if
other Intel-based configuration options are not enabled:
./src/gallium/winsys/i915/drm/meson.build:21:0: ERROR: Unknown variable "libintel_common".
Signed-off-by: James Knight <james.d.knight@live.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22490 >
2023-04-14 16:13:48 +00:00
Marcin Ślusarz
cf90be90ad
intel: split URB space between task and mesh proportionally to entry sizes
...
Improves performance by 0.5-2.5% in vk_meshlet_cadscene
depending on the model.
Reviewed-by: José Roberto de Souza <jose.souza@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22445 >
2023-04-14 15:43:50 +00:00
Samuel Pitoiset
f11a4a09b0
radv: try to keep HTILE compressed for READ_ONLY_OPTIMAL layout
...
It should be handled like DEPTH_STENCIL_READ_ONLY_OPTIMAL.
This fixes an issue with VRS attachment because HTILE was considered
disabled for READ_ONLY_OPTIMAL but there is no reasons to disable it
as long as the image is only used as a depth/stencil attachment.
Otherwise, when HTILE is disabled, VRS rates are ignored.
Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8675
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22468 >
2023-04-14 13:48:04 +00:00
Eric Engestrom
3e22c3a8bc
broadcom/ci: deduplicate script definition
...
It's always going to be the same for all the jobs in our farm.
Signed-off-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: Emma Anholt <emma@anholt.net >
Reviewed-by: Juan A. Suarez <igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22457 >
2023-04-14 13:13:00 +00:00
Samuel Pitoiset
bdb03ecdd9
vulkan: ignore rasterizationSamples when the state is dynamic
...
Fixes: 1deb83fb86 ("vulkan: Add more dynamic multisample states")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Tapani Pälli <tapani.palli@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22444 >
2023-04-14 12:26:53 +00:00
Eric Engestrom
6af78baa23
ci: update shebang to make it more portable
...
Doesn't matter for now, but it doesn't cost anything to make it portable :)
Suggested-by: David Heidelberg <david.heidelberg@collabora.com >
Signed-off-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: Emma Anholt <emma@anholt.net >
Reviewed-by: Helen Koike <helen.koike@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22450 >
2023-04-14 11:28:21 +00:00
Eric Engestrom
9120f17b27
ci: bump tags
...
Signed-off-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com >
Reviewed-by: Emma Anholt <emma@anholt.net >
Reviewed-by: Helen Koike <helen.koike@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22450 >
2023-04-14 11:28:21 +00:00
Eric Engestrom
8eb5de3126
ci: start documenting which image tags need to be bumped
...
Signed-off-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com >
Reviewed-by: Emma Anholt <emma@anholt.net >
Reviewed-by: Helen Koike <helen.koike@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22450 >
2023-04-14 11:28:21 +00:00
Eric Engestrom
9a45d3ee13
ci: move deqp-egl instead of copying it
...
To make sure we can't accidentally run a random leftover platform.
Signed-off-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com >
Reviewed-by: Emma Anholt <emma@anholt.net >
Reviewed-by: Helen Koike <helen.koike@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22450 >
2023-04-14 11:28:21 +00:00
Eric Engestrom
efd2067a8f
ci: add -android suffix for android build of deqp-egl
...
Makes it clearer which platform is being run.
Signed-off-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com >
Reviewed-by: Emma Anholt <emma@anholt.net >
Reviewed-by: Helen Koike <helen.koike@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22450 >
2023-04-14 11:28:21 +00:00
Eric Engestrom
e876a018e9
ci: stop removing -x11 suffix for x11 build of deqp-egl
...
Makes it clearer which platform is being run.
Signed-off-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com >
Reviewed-by: Emma Anholt <emma@anholt.net >
Reviewed-by: Helen Koike <helen.koike@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22450 >
2023-04-14 11:28:21 +00:00
Lionel Landwerlin
08cf224c4a
intel/vec4: force exec_all on float control instruction
...
Applying the same rule as the fs backend so that generation code
doesn't assert.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Fixes: daa8003e45 ("intel/fs: use nomask for setting cr0 for float controls")
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22473 >
2023-04-14 10:54:01 +00:00