Emma Anholt
f0c033ebbc
zink: No need to use a 2-sample dummy image for bindless without null descs.
...
This appears to be some leftover copy and paste or something, should be
1-sample just like other dummy usages.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19126 >
2022-10-28 20:37:54 +00:00
José Roberto de Souza
09c4ed4f2c
iris: Do not export iris_bo_wait()
...
It has a single user, so no need to export it.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19359 >
2022-10-28 20:12:07 +00:00
José Roberto de Souza
144ccc31d7
iris: Drop duplicated errno handling in iris_bo_wait()
...
Both code paths already do this handling, so no need to this again in
iris_bo_wait().
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19359 >
2022-10-28 20:12:07 +00:00
José Roberto de Souza
191f9a39c9
iris: Nuke pci_id from iris_screen
...
We have the same information in devinfo.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19359 >
2022-10-28 20:12:07 +00:00
José Roberto de Souza
bb9f66800c
intel/perf: Use intel_device_info functions to compute subslice and eu totals
...
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19359 >
2022-10-28 20:12:07 +00:00
Giancarlo Devich
dc4d7d7b0f
d3d12: Don't align already-aligned size in d3d12_bufmgr_create_buffer
...
This is handled by `pb_cache_manager_create_buffer`.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19082 >
2022-10-28 19:46:25 +00:00
Giancarlo Devich
e902f2ab8c
gallium/pipe: Align allocation size in pb_cache_manager_create_buffer
...
Some drivers have minimum buffer size or alignment requirements. When a
buffer is created using pb_cache_manager_create_buffer, the cache is
first checked for a compatible buffer to return instead. If the
requested buffer size is less than
(minimum buffer size) / (mgr->size_factor), no buffer in the cache
is _ever_ applicable.
The alignment is used to determine the true allocation size when
evaluating against cached buffers.
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19082 >
2022-10-28 19:46:25 +00:00
Rob Clark
416b33337d
freedreno/ci: Small bit of xfails cleanup
...
Minor resorting to group similar edgeflags fails together.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19236 >
2022-10-28 19:13:27 +00:00
Rob Clark
edfc98460b
freedreno: Enable GL_ARB_enhanced_layouts
...
Seems like ir3 already supports everything that was needed, according to
piglit.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19236 >
2022-10-28 19:13:27 +00:00
Rob Clark
5b7e6b583a
freedreno/a6xx: Enable GL_ARB_texture_mirror_clamp_to_edge
...
It was already supported, might as well turn it on.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19236 >
2022-10-28 19:13:27 +00:00
Rob Clark
c50e9f65bd
freedreno/a6xx: Support GL_ARB_viewport_array + gl43
...
Support multiple viewports and bump supported GLSL version now that we
tick all the boxes.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19236 >
2022-10-28 19:13:27 +00:00
Rob Clark
23b7948a72
freedreno: Move guardband calc to bind time
...
No point in re-calculating this at emit time. Even more so when there
are multiple viewports.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19236 >
2022-10-28 19:13:27 +00:00
Rob Clark
d9150eab28
freedreno: Massage scissor state at bind time
...
All the generations want maxx/maxy to be inclusive rather than
exclusive, so shift the subtract-one nonsense to bind time rather
than emit time.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19236 >
2022-10-28 19:13:27 +00:00
Rob Clark
e752a26ca4
freedreno: support multiple viewports
...
Core plumbing to have multiple viewport support. Each viewport has it's
own scissor state.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19236 >
2022-10-28 19:13:27 +00:00
Rob Clark
138b513fb7
freedreno/a6xx: Support AMD_vertex_shader_layer
...
Another thing we already supported but didn't set the cap.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19236 >
2022-10-28 19:13:27 +00:00
Rob Clark
110a5f4f02
freedreno/a6xx: Fix buffer size clamping
...
Fixes spec@arb_texture_buffer_object@texture-buffer-size-clamp@* which
we start hitting after exposing glsl420
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19236 >
2022-10-28 19:13:27 +00:00
Rob Clark
b416c08e86
freedreno/ir3: Drop unused view_zero/layer_zero lowering
...
Previous patch removed the only remaining user.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19236 >
2022-10-28 19:13:27 +00:00
Rob Clark
679adcbc3c
freedreno/a6xx: Move layer_zero handling to interp state
...
We can just bake this into the program state, rather than making it a
shader variant. Turnip had already switched to this approach so it will
let us drop ir3 lowering for this.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19236 >
2022-10-28 19:13:27 +00:00
Rob Clark
3a69547086
freedreno: Don't advertise TGSI support for GS/tess
...
tgsi_to_nir doesn't support these, and we long ago removed support for
consuming TGSI without tgsi_to_nir. So don't claim to support this.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19236 >
2022-10-28 19:13:27 +00:00
Rob Clark
2e689e9d9d
Revert "mesa/st: ARB_vertex_attrib_64bit depend on glsl>=410"
...
Turns out this change was unnecessary
This reverts commit 533b87dff0 .
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19236 >
2022-10-28 19:13:27 +00:00
Samuel Pitoiset
c84dbd189b
ac/nir/ngg: fix emitting streamout output by using packed location
...
In RadeonSI, they are packed but not in RADV, so don't rely on driver
locations.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Qiang Yu <yuq825@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19343 >
2022-10-28 18:54:16 +00:00
Karol Herbst
1c37a8342c
rusticl/kernel: fix more 32 bit problems
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19353 >
2022-10-28 18:46:33 +00:00
Samuel Pitoiset
eae2867122
radv: move nir_opt_idiv_const/nir_lower_idiv after NGG lowering
...
NGG streamout lowering creates some idiv instructions that need to be
lowered.
No fossil-db results because it's currently broken.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19364 >
2022-10-28 18:19:57 +00:00
Samuel Pitoiset
e2fcbd4a37
radv/llvm: fix dual source blending on GFX11
...
Untested but this should be similar to RadeonSI.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19367 >
2022-10-28 17:03:37 +00:00
Samuel Pitoiset
d172fc1fca
radv: fix VRS limit when attachmentFragmentShadingRate is disabled
...
Can be reproduced on GFX10.3 with RADV_DEBUG=nohiz.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19374 >
2022-10-28 16:30:29 +00:00
Mike Blumenkrantz
e97edac66d
zink: don't double-deref bindless texture arrays in shaders
...
these are already dereferenced
Fixes: b2fcb34e97 ("zink: rework sampler emission")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19377 >
2022-10-28 15:38:41 +00:00
José Roberto de Souza
a5f335f97a
iris: Fix enablement of protected contexts
...
I915_CONTEXT_CREATE_FLAGS_USE_EXTENSIONS needs to set otherwise
i915 will ignore the extensions.
Fixes: 57a1d13279 ("iris: enable protected contexts")
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19373 >
2022-10-28 06:08:43 -07:00
Iago Toral Quiroga
004f431b7f
v3dv: split event implementation to a separate file
...
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19366 >
2022-10-28 10:55:37 +00:00
Iago Toral Quiroga
6748d22a7b
v3dv: return out of host memory if we fail to create event pipelines
...
Fixes: ecb01d53fd ('v3dv: refactor events')
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19366 >
2022-10-28 10:55:37 +00:00
Frank Binns
40e683b907
pvr: remove implicit sync support
...
This is the legacy way of doing synchronisation and is no longer necessary now
that the DMA_BUF_IOCTL_EXPORT_SYNC_FILE / DMA_BUF_IOCTL_IMPORT_SYNC_FILE ioctls
exist, which the wsi code is already making use of.
Signed-off-by: Frank Binns <frank.binns@imgtec.com >
Reviewed-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19293 >
2022-10-28 10:44:55 +00:00
Mykhailo Skorokhodov
b890ad7d5e
drirc: Apply fp64_workaround_enabled to DOOM Eternal
...
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6847
Signed-off-by: Mykhailo Skorokhodov <mykhailo.skorokhodov@globallogic.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18854 >
2022-10-28 10:08:50 +00:00
Mykhailo Skorokhodov
a954933f4f
drirc: Add fp64_workaround_enabled option
...
Signed-off-by: Mykhailo Skorokhodov <mykhailo.skorokhodov@globallogic.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18854 >
2022-10-28 10:08:50 +00:00
Mykhailo Skorokhodov
8c4c4c3ee1
anv: Add softtp64 workaround
...
Pass float64.glsl into nir_lower_doubles() resolves the problem on
ICL/TGL when the shader uses float64, but the device doesn't support
that type.
Signed-off-by: Mykhailo Skorokhodov <mykhailo.skorokhodov@globallogic.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18854 >
2022-10-28 10:08:50 +00:00
Mykhailo Skorokhodov
829d74b2f2
anv/meson: Add float64_spv_h custom target
...
Signed-off-by: Mykhailo Skorokhodov <mykhailo.skorokhodov@globallogic.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18854 >
2022-10-28 10:08:50 +00:00
Mykhailo Skorokhodov
f8425e661a
glsl/meson: Add variable to export float64.glsl
...
Signed-off-by: Mykhailo Skorokhodov <mykhailo.skorokhodov@globallogic.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18854 >
2022-10-28 10:08:50 +00:00
Mykhailo Skorokhodov
4692c66358
nir: Add assert in nir_lower_doubles
...
Cc: mesa-stable
Signed-off-by: Mykhailo Skorokhodov <mykhailo.skorokhodov@globallogic.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18854 >
2022-10-28 10:08:50 +00:00
Mykhailo Skorokhodov
e4b7bf1a6d
nir: Make lower_double_ops recognize SPIR-V mangling
...
Signed-off-by: Mykhailo Skorokhodov <mykhailo.skorokhodov@globallogic.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18854 >
2022-10-28 10:08:50 +00:00
Mykhailo Skorokhodov
9786d9ef2a
util: Add glsl2spirv.py script
...
Signed-off-by: Mykhailo Skorokhodov <mykhailo.skorokhodov@globallogic.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18854 >
2022-10-28 10:08:50 +00:00
Nanley Chery
48844910a3
iris: Enable INTEL_MEASURE for compute dispatches on XeHP
...
Cc: mesa-stable
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19324 >
2022-10-28 09:28:01 +00:00
Lucas Stach
a41c0b58aa
etnaviv: blt: try to find exact format match first
...
For MSAA downsampling to work correctly, the BLT engine needs to know
the exact format of the blit source/target. The compatible formats are
fine as long as the BLT is only used as a tiler without doing any
conversion.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de >
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19349 >
2022-10-28 08:49:11 +00:00
Lucas Stach
0f34a092e4
etnaviv: blt: scale operations by MSAA mode
...
Same as with the RS engine, BLT operations need to be scaled by
the MSAA size.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de >
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19349 >
2022-10-28 08:49:11 +00:00
Samuel Pitoiset
c41997f29f
radv: fix suspending/resuming pipeline statistics queries with GDS
...
This probably doesn't fix anything in practice because GDS is only
used for the number of generated primitives by GS and meta operations
don't use GS.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19348 >
2022-10-28 08:12:30 +00:00
Samuel Pitoiset
cf687e88ce
ac/nir/ngg: fix emitting streamout output by using packed location
...
In RadeonSI, they are packed but not in RADV, so don't rely on driver
locations.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Qiang Yu <yuq825@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19365 >
2022-10-28 07:49:32 +00:00
Lionel Landwerlin
920aed2121
intel/compiler: don't allocate compaction arrays on the stack
...
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7569
Cc: mesa-stable
Reviewed-by: Luis Felipe Strano Moraes <luis.strano@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19339 >
2022-10-28 07:10:58 +00:00
Iago Toral Quiroga
29588fe116
v3dv: re-enable sync_fd import/export
...
Now that we implement GPU-side event functions in the GPU we
no longer have the issue that didn't allow us to expose
sync_fd.
Further more, new spec text has also made the problematic
behavior undefined, so the test that caused this issue,
dEQP-VK.api.external.semaphore.sync_fd.import_twice_temporary,
is incorrect and should be fixed.
It should be noted that we still keep sync_fd disabled in the
simulator, at least until the CTS tests are fixed, since the
synchronous execution model of the simulator means that in the
problematic scenario we can block the CPU on the execution
of the command buffer before we ever submit the signaling job,
still causing a deadlock.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19313 >
2022-10-28 08:41:13 +02:00
Iago Toral Quiroga
ecb01d53fd
v3dv: refactor events
...
This replaces our current implementation, which is 100% CPU based,
with an implementation that uses compute shaders for the GPU-side
event functions. The benefit of this solution is that we no longer
need to stall on the CPU when we need to handle GPU-side event
commands.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19313 >
2022-10-28 08:35:00 +02:00
Iago Toral Quiroga
8cd50ef071
broadcom/compiler: handle vec2 load/store index
...
In vulkan, we load descriptors via vulkan resource index, which
returns a vec2, of which we want component 0 which holds the actual
index. Typically, this will be cleaned-up by the time we get to
emitting VIR so the index is a single scalar component, but there
are some cases where this might no be the case, so make sure we don't
assume it to be a scalar, like we do in other places.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19313 >
2022-10-28 08:23:32 +02:00
Brian Paul
2ab70c1004
llvmpipe: check rectangle vertices have equal W components
...
The attribute interpolation code does not handle perspective
correction. But it's OK if the vertex W components are non-one as
long as they're equal.
This fixes about 30 CTS/dEQP tests.
Signed-off-by: Brian Paul <brianp@vmware.com >
Reviewed-by: Roland Scheidegger <sroland@vmware.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19331 >
2022-10-27 22:05:01 -06:00
Matt Turner
3ef88cd0a2
intel/dev: Set display_ver = 13 on all ADL/RPL/DG2
...
display_ver doesn't seem to be used anywhere, but if that were to
change, we'd want this to be consistent.
Fixes: c746bf4c5c ("intel/dev: Add display_ver and set adl-p to 13")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19354 >
2022-10-28 01:31:44 +00:00
Karol Herbst
dbc4f05ca1
zink: remove leftover work_dim lowering code
...
Signed-off-by: Karol Herbst <kherbst@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19362 >
2022-10-28 01:11:00 +00:00