Tapani Pälli
095fd121a3
intel/perf: cleanup, remove duplicate function declaration
...
Signed-off-by: Tapani Pälli <tapani.palli@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8805 >
2021-02-03 16:37:59 +00:00
Bas Nieuwenhuizen
047d799a16
radv: Fix assert.
...
Fixes: 7f7da82dbb ("radv: Add image layout with drm format modifiers.")
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8828 >
2021-02-03 16:18:20 +00:00
Bas Nieuwenhuizen
469341fabc
radv: Add modifier fails for CTS bug.
...
Fixes: 58e5232625 ("radv: Enable DRM format modifiers on GFX9+.")
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8828 >
2021-02-03 16:18:20 +00:00
Witold Baryluk
736834931b
radv: memset the alignment hole in cache_entry to 0
...
Detected using valgrind. Otherwise these bytes at the end
will be touched by zstd compression, spamming valgrind output.
Other option is to do full memset(entry, 0, size),
but that is somehow unnecessary and suboptimal.
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8229 >
2021-02-03 15:28:04 +00:00
Samuel Iglesias Gonsálvez
5fc5d18aac
turnip: fix UINT64_MAX size wrapping in tu_GetBufferMemoryRequirements()
...
tu_GetBufferMemoryRequirements() ends up wrapping the UINT64_MAX size
to 0 when aligning.
Fixes:
dEQP-VK.api.buffer.basic.size_max_uint64
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com >
Reviewed-by: Jonathan Marek <jonathan@marek.ca >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4493 >
2021-02-03 16:01:41 +01:00
Samuel Iglesias Gonsálvez
ea42632ba7
turnip: set sparseAddressSpaceSize to zero
...
According to Vulkan spec, "Table 46. Required Limits", as sparse
binding is unsupported, we need to return unsupported limit for
sparseAddressSpaceSize, which is zero.
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com >
Reviewed-by: Jonathan Marek <jonathan@marek.ca >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4493 >
2021-02-03 16:01:21 +01:00
Alyssa Rosenzweig
5a975fc8e7
pan/decode: Prefer sizeof to ARRAY_SIZE for char
...
One less macro.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8829 >
2021-02-03 14:04:53 +00:00
Alyssa Rosenzweig
df8c4471b3
pan/decode: Remove tile range validation
...
Fault pointer works as you expect so it's not terribly useful.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8829 >
2021-02-03 14:04:53 +00:00
Alyssa Rosenzweig
53c672aa12
pan/mdg: Drop unused stage parameter to disassembler
...
No longer used but was adding a dependency on compiler/shader_enums.h
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8829 >
2021-02-03 14:04:53 +00:00
Alyssa Rosenzweig
a00db92e49
pan/decode: Remove mesa header dependencies
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8829 >
2021-02-03 14:04:53 +00:00
Alyssa Rosenzweig
307191f88c
pan/decode: Remove unused disasm stats
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8829 >
2021-02-03 14:04:52 +00:00
Alyssa Rosenzweig
641b8a6a19
pan/decode: Remove pandecode_prop
...
For pre-GenXML printing.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8829 >
2021-02-03 14:04:52 +00:00
Alyssa Rosenzweig
19ae0017d1
pan/decode: Simplify tiler printing
...
Again, most of this is either wrong or doesn't really matter.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8829 >
2021-02-03 14:04:52 +00:00
Alyssa Rosenzweig
0aa3e959b8
pan/decode: Remove unused MEMORY_PROP macro
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8829 >
2021-02-03 14:04:52 +00:00
Alyssa Rosenzweig
19a29f2e45
pan/decode: Deduplicate shader property printing
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8829 >
2021-02-03 14:04:52 +00:00
Alyssa Rosenzweig
6c0669979d
pan/decode: Deduplicate SFBD blend printing
...
Annoying verbosity of traces on midgard.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8829 >
2021-02-03 14:04:52 +00:00
Alyssa Rosenzweig
71c43211c1
pan/decode: Remove dependency of decoder on the encoder
...
Obstacle to decouple panwrap from the rest of mesa.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8829 >
2021-02-03 14:04:52 +00:00
Alyssa Rosenzweig
776a6a8435
pan/decode: Remove tiler size checks
...
Bad dependency and also mostly speculation at the time of writing.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8829 >
2021-02-03 14:04:52 +00:00
Alyssa Rosenzweig
aba23ec43e
pan/decode: Be explicit when printing invocations
...
Our "canonical" forms weren't really... good.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8829 >
2021-02-03 14:04:52 +00:00
Jonathan Marek
dd388b14c8
turnip: add missing register write to disable dithering
...
This was causing rendering issues with low precision formats because GL
driver can enable it.
Signed-off-by: Jonathan Marek <jonathan@marek.ca >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8707 >
2021-02-03 13:45:19 +00:00
Jonathan Marek
bdaa4d1ee0
turnip: don't always use 3d ops for blit_image
...
Revert this accidentally committed testing change.
Fixes: 872c4bcd27 ("turnip: implement z-scaling and z-mirroring BlitImage")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8707 >
2021-02-03 13:45:19 +00:00
Jonathan Marek
b37bd5f89b
turnip: IMAGE_FILTER_{LINEAR,CUBIC}_BIT only for non-integer formats
...
Avoid CTS trying to use linear filtering for integer formats.
Signed-off-by: Jonathan Marek <jonathan@marek.ca >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8707 >
2021-02-03 13:45:19 +00:00
Jonathan Marek
b4653c1033
turnip: use vk_format_is_int to disable COLOR_ATTACHMENT_BLEND_BIT
...
This is simpler and easier to understand.
Signed-off-by: Jonathan Marek <jonathan@marek.ca >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8707 >
2021-02-03 13:45:19 +00:00
Jonathan Marek
de44e700b1
turnip: delete unused vk_format_parse.py file
...
Signed-off-by: Jonathan Marek <jonathan@marek.ca >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8707 >
2021-02-03 13:45:19 +00:00
Jonathan Marek
596e82510d
turnip: fix logicOp
...
Don't ignore logic op for integer formats.
Blend also doesn't need this path, because it isn't valid for blendEnable
to be true for integer formats.
Signed-off-by: Jonathan Marek <jonathan@marek.ca >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8707 >
2021-02-03 13:45:19 +00:00
Rhys Perry
0602d4ec69
radv: correctly enable WGP_MODE for tessellation control
...
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8811 >
2021-02-03 11:27:50 +00:00
Rhys Perry
2338e4ad36
radv: correctly enable WGP_MODE for NGG and GS
...
Previously, we would set WGP_MODE on GFX10+ and then only on GFX10.
Because we used bitwise or, the result was WGP_MODE being set on GFX10+.
We also set the wrong bit, S_00B848_WGP_MODE instead of S_00B228_WGP_MODE.
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8811 >
2021-02-03 11:27:50 +00:00
Rhys Perry
56cd79b63d
radv: round-up num_records division in radv_flush_vertex_descriptors
...
Vertex attribute bounds checking is supposed to be done per-attribute:
is_oob = index * stride + attrib_offset + attrib_size > buffer_size
but we were obtaining num_records by dividing the buffer size by the
stride, making it per-vertex:
is_oob = index * stride + (stride - 1) >= buffer_size
An example from Dead Cells (Wine) is:
attribute bindings: 0, 1, 2
attribute formats: r32g32, r32g32, r32g32b32a32
attribute offsets: 0, 0, 0
binding buffers: all the same buffer
binding offsets: 0, 8, 16
binding sizes: 128, 120, 112
binding strides: 32, 32, 32
Workaround this issue without switching to per-attribute descriptors by
rounding up the division. This is still incorrect, but it should now no
longer consider in-bounds attributes out-of-bounds.
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3796
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4199
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8835 >
2021-02-03 09:53:08 +00:00
James Park
4cec72c3a9
radv: Use typed outarray API
...
MSVC cannot perform GCC __typeof__ for C code. (C++ has decltype.)
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8818 >
2021-02-03 08:57:59 +00:00
James Park
2e8b8f0514
ac: Remove unnecessary header
...
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8819 >
2021-02-03 08:32:01 +00:00
Tony Wasserka
5df057a3e6
aco/ra: Add helper to get a PhysRegInterval for the register demand
...
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8737 >
2021-02-03 08:17:49 +00:00
Marek Olšák
32fc4dada2
gallium/u_vbuf: skip non-indirect draws with 0 vertices
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Reviewed-by: Zoltán Böszörményi <zboszor@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8770 >
2021-02-02 19:53:44 -05:00
Marek Olšák
dc9645be67
Revert "gallium/u_vbuf: skip draws with 0 vertices"
...
This reverts commit be8d811e57 .
Fixes: be8d811e57
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4184
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Reviewed-by: Zoltán Böszörményi <zboszor@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8770 >
2021-02-02 19:53:44 -05:00
Caio Marcelo de Oliveira Filho
d49b0fa72f
anv: Implement VK_KHR_zero_initialize_workgroup_memory
...
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8708 >
2021-02-02 17:06:56 +00:00
Caio Marcelo de Oliveira Filho
a2414ada87
nir: Add nir_zero_initialize_shared_memory
...
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8708 >
2021-02-02 17:06:56 +00:00
Caio Marcelo de Oliveira Filho
c4f2297f00
spirv: Recognize zero initializers in Workgroup variables
...
This will be used to implement
VK_KHR_zero_initialize_workgroup_memory.
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8708 >
2021-02-02 17:06:56 +00:00
Caio Marcelo de Oliveira Filho
378eca1394
spirv: Refactor variable initializer code
...
Pass the vtn_value and let vtn_create_variable do the validation.
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8708 >
2021-02-02 17:06:56 +00:00
Erico Nunes
696b0ab2c9
lima: always set stride in texture descriptor
...
We can just always specify the stride parameter regardless of whether
an alignment was forced or not. This fixes some issues where it is not
straightforward to detect the need to specify stride by checking the
buffer width (e.g. imported dmabuf to be used as texture).
Signed-off-by: Erico Nunes <nunes.erico@gmail.com >
Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8549 >
2021-02-02 16:54:47 +00:00
Erico Nunes
ce432ac7cd
lima: enable r and rg pixel formats again
...
Enable r and rg targets to allow r and rg so that lima exposes
GL_EXT_texture_rg.
This is notably required by programs working with textures for
video playback.
Signed-off-by: Erico Nunes <nunes.erico@gmail.com >
Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8549 >
2021-02-02 16:54:47 +00:00
Erico Nunes
f17c8dc798
lima: set yuv formats as external_only
...
lima is not able to use yuv textures directly.
Set them as external_only so that drivers don't attempt to send yuv
planes directly as dma bufs.
Signed-off-by: Erico Nunes <nunes.erico@gmail.com >
Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8549 >
2021-02-02 16:54:47 +00:00
Jason Ekstrand
774fae34f0
nir: Drop the lower_mem_constant_vars declaration
...
The function was removed in c730ace12b .
Fixes: c730ace12b "nir,clover: Drop nir_lower_mem_constant_vars"
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8834 >
2021-02-02 16:34:22 +00:00
Karol Herbst
6adf410cc0
clover/api: make use of validate_mem_migration_flags in clEnqueueMigrateMemObjects
...
Signed-off-by: Karol Herbst <kherbst@redhat.com >
Reviewed-by: Francisco Jerez <currojerez@riseup.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6401 >
2021-02-02 16:11:35 +00:00
Jérôme Glisse
6e4f7e14af
nouveau: add support for SVM migrate
...
v2 (Ralph): don't allign address as the kernel handles that already
support migration from GPU to system RAM
v3 (Karol): use DIV_ROUND_UP for sizes not being page aligned
Signed-off-by: Jérôme Glisse <jglisse@redhat.com >
Signed-off-by: Karol Herbst <kherbst@redhat.com >
Reviewed-by: Francisco Jerez <currojerez@riseup.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6401 >
2021-02-02 16:11:35 +00:00
Jérôme Glisse
f7616c89a4
clover: implement clEnqueueSVMMigrateMem
...
Memory migration for SVM (share virtual memory). This allow to migrate
a range of virtual address of the process to device memory to speed up
device processing when that memory is in use by the device.
v2 (Karol): use tracked SVM allocation in order to support cases where
the size of the migration is not specified
Signed-off-by: Jérôme Glisse <jglisse@redhat.com >
Signed-off-by: Karol Herbst <kherbst@redhat.com >
Reviewed-by: Francisco Jerez <currojerez@riseup.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6401 >
2021-02-02 16:11:35 +00:00
Karol Herbst
3718938c1a
clover: track allocated svm pointers
...
We need those to proper validate the SVM API.
v2: use std::map instead of std::unordered_map
v3: guard against segfaults on std::prev with empty containers
Signed-off-by: Karol Herbst <kherbst@redhat.com >
Reviewed-by: Francisco Jerez <currojerez@riseup.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6401 >
2021-02-02 16:11:35 +00:00
Jérôme Glisse
e3c2432b37
gallium: add support for SVM (Share Virtual Memory) migrate
...
v2 (Karol): Fix declaration of pointers argument
v3 (Karol): Move flags into function interface as bools
Signed-off-by: Jérôme Glisse <jglisse@redhat.com >
Signed-off-by: Karol Herbst <kherbst@redhat.com >
Acked-by: Francisco Jerez <currojerez@riseup.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6401 >
2021-02-02 16:11:35 +00:00
Erik Faye-Lund
0e47422413
zink: wrap some long lines
...
These lines are very long, let's wrap them a bit.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8832 >
2021-02-02 16:00:37 +00:00
Erik Faye-Lund
a7d9ac2956
zink: refactor vertex-order emitting
...
Using a ternary expression inside the argument list avoids some
repetition, showing that the rest of the call is the same. This increase
readability a tad.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8832 >
2021-02-02 16:00:37 +00:00
Erik Faye-Lund
06e421fe5c
zink: add a get_spacing-helper
...
Similarly to the previous commit, this makes the code a bit easier to
read.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8832 >
2021-02-02 16:00:37 +00:00
Erik Faye-Lund
e240221d15
zink: add a get_primitive_mode-helper
...
This just makes the code a bit easier to read, where the details are
hidden slightly.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8832 >
2021-02-02 16:00:37 +00:00