Iago Toral Quiroga
509c8a60c4
We were assuming that if the command buffer state doesn't have any attachments (as per the attachment count) the attachment state array should not be allocated, however, during meta operations it is possible that the attachment state grows (since meta operations can emit render passes of their own). In that case, we would grow the state for the meta operation but then pop the previous attachment count and we would leak the state. An example of that is a secondary command buffer which has no attachment state by default since it doesn't execute a render pass begin, but that executes one in a meta operation (for vkCmdClearAttachments for example). Fix this by making the attachment count an allocation count instead and not popping it once we finish a meta operation. Also, always free the state so long as there is a valid pointer, and assert that the allocated count is not zero in that case. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6766>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `Freenode's #dri-devel <irc://chat.freenode.net#dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.