Francisco Jerez
1272ff5ed1
The LSC implements several optimizations for atomic operations on a memory addresses that are uniform across all lanes, in which case its cost is approximately O(1) instead of O(exec_size). Even cases where memory offsets are non-uniform but packed in a cacheline appear to have a cost that is non-linear with the number of lanes. In order to approximate this behavior more closely approximate its back-end cost as roughly 1300 cycles instead of the previous 400 * exec_size/8. This fixes some cases where we were incorrectly predicting the SIMD32 shader would be bound by the throughput of LSC atomic operations, even though the observed cost per lane of the LSC operations was significantly lower in SIMD32 mode so it would have the best performance. Clearly this is still a rough approximation and it might be possible to obtain a more accurate result by plumbing divergence analysis data all the way down to codegen, however the goal of the performance analysis pass isn't to provide an exact prediction of the performance of a shader (that's not really possible in general via static analysis without solving the halting problem), but to provide a good enough approximation at a low cost -- And the constant approximation seems to be strictly better in practice than the approximation we were using before, there appear to be no regressions from this change, and ShadowTombRaider-trace-dx11-2160p-ultra shows 5.7% better performance on PTL with a subsequent commit that re-enables the use of the static analysis-based SIMD32 heuristic on xe3+. Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36618>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.