Alyssa Rosenzweig
ff7abb1e22
libagx: refactor index buffer code
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:31 +00:00
Alyssa Rosenzweig
686daf2524
libagx: move index size helpers to the gpu
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:31 +00:00
Alyssa Rosenzweig
b5d41bc0fb
agx: match another address pattern
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:31 +00:00
Alyssa Rosenzweig
7626e40506
asahi: reformat
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:31 +00:00
Alyssa Rosenzweig
fc4e533709
agx: add more 8-bit address fusing rules
...
helps kernel I'm writing
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:31 +00:00
Alyssa Rosenzweig
e110b8f2c9
libagx: add missing agx_vdm_return
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:31 +00:00
Alyssa Rosenzweig
b6dbfe822b
asahi: use common draw
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:31 +00:00
Alyssa Rosenzweig
b9155de0a1
hk,libagx: move hk_draw to the gpu
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:31 +00:00
Asahi Lina
c80c56a315
asahi: hk: Enable timestamps for virt
...
Signed-off-by: Asahi Lina <lina@asahilina.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:31 +00:00
Asahi Lina
e281293508
asahi: Virt UABI update
...
Support timestamp extensions & fix a bunch of missing/broken things we
were dragging along.
Signed-off-by: Asahi Lina <lina@asahilina.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:31 +00:00
Alyssa Rosenzweig
0d5db3238b
asahi: fix mmap'ing imported BOs
...
bo->dev wasn't being set on the import path. apparently mmap'ing imported BOs is
really rare, so this slipped through. should address segfaults with gnome
settings.
Reported-by: girona
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32759 >
2024-12-21 01:50:31 +00:00
Eric R. Smith
4533144608
panfrost: apply DEPTH_STENCIL flag consistently
...
We were inconsistent over the usage of PAN_BIND_DEPTH_STENCIL, putting
it on some stencil only formats but not others. Apply it to all
stencil formats. However, we also need to change is_format_supported
to ignore S8_UINT (at least for GLES), because the hardware is a little
weird with that format and the gallium driver gets confused by it.
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32462 >
2024-12-20 23:18:08 +00:00
Eric R. Smith
b6ade2714c
panvk: fix fs_required()
...
If the sample mask is updated, we have to run the fragment
shader, so make sure this is reflected in fs_required()
Signed-off-by: Eric R. Smith <eric.smith@collabora.com >
Co-authored-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32462 >
2024-12-20 23:18:08 +00:00
Caio Oliveira
5c0c3120ca
intel/brw: Use variable instead of manually count the passes
...
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32709 >
2024-12-20 22:41:20 +00:00
Caio Oliveira
ada898bb1c
intel/brw: Disallow cmod in some cases of ARF scalar as destination
...
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32758 >
2024-12-20 14:03:15 -08:00
Francisco Jerez
43d59c6186
intel/brw/xe3+: Relax SEND EOT register assignment restrictions.
...
These restrictions have been removed from the hardware. Make the code
enforcing and validating them conditional.
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32758 >
2024-12-20 14:03:15 -08:00
nyanmisaka
8a5ec60442
frontends/vdpau: Get AV1 decode subsampling_x/y
...
The VDPAU frontend requires similar changes as in the VAAPI frontend.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12337
Signed-off-by: nyanmisaka <nst799610810@gmail.com >
Reviewed-by: David Rosca <david.rosca@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32752 >
2024-12-20 16:36:42 +00:00
Rohan Garg
9a4f5b739e
intel/compiler: disable mesh autostrip for WA 16020916187
...
Disable mesh autostrip for platforms that need WA 16020916187.
Additionally, zero out the layer and viewport slots when a shading rate
is found through the brw_nir_initialize_mue pass.
Signed-off-by: Rohan Garg <rohan.garg@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32751 >
2024-12-20 17:02:20 +01:00
Erik Faye-Lund
b180e2a47c
panvk/ci: update expected failures
...
Acked-by: Valentine Burley <valentine.burley@collabora.com >
Acked-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32748 >
2024-12-20 14:52:25 +01:00
David Rosca
5621ce10a6
radeonsi/vcn: Return error when decoding 12bit VP9 and 4:2:2/4:4:4 AV1
...
This is not supported by VCN.
We indicate this limitation by not reporting YUV420_12 RT format
supported for VP9, and not reporting YUV422 and YUV444 for AV1.
Most applications however simply ignore this, and will pick some other
format that is supported, which obviously won't work.
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32663 >
2024-12-20 10:51:18 +00:00
David Rosca
245d8c8e99
frontends/va: Get AV1 decode subsampling_x/y
...
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32663 >
2024-12-20 10:51:18 +00:00
David Rosca
d94597a2d8
pipe: Remove PIPE_DEFAULT_DECODER_FEEDBACK_TIMEOUT_NS
...
Use OS_TIMEOUT_INFINITE instead.
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32705 >
2024-12-20 11:19:49 +01:00
David Rosca
c03805e4f5
radeonsi/vcn: Use local variable for destory fence
...
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32705 >
2024-12-20 11:19:05 +01:00
David Rosca
fed1ed1eff
radeonsi/vcn: Don't keep last fence
...
This is not needed after 0c024bbe64 ("radeonsi/vcn: Add decode DPB buffers as CS dependency")
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32705 >
2024-12-20 11:18:23 +01:00
Peyton Lee
ad0dbea49d
radeonsi/vpe: add destroy_fence function
...
implement destroy_fence() for better fence control
Signed-off-by: Peyton Lee <peytolee@amd.com >
Reviewed-by: David Rosca <david.rosca@amd.com >
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32648 >
2024-12-20 09:55:00 +00:00
Marek Olšák
1e14b00e8b
gallium: pass XFB primitive mode to set_stream_output_targets
...
radeonsi would like to know the prim mode. GL always knows it,
so let's pass it through.
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32685 >
2024-12-20 08:22:52 +00:00
Marek Olšák
e22b78a196
mesa: fix printing _NEW_* flags
...
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32685 >
2024-12-20 08:22:52 +00:00
Marek Olšák
b2ddf85591
mesa: set correct XFB prim mode for draw validation after resuming XFB
...
Draws were validated against an XFB primitive type from the last
glBeginTransformFeedback call, ignoring glResumeTransformFeedback that
may have been after it that may have resumed for a different primitive
type.
The spec doesn't state this explicitly, but it's logical.
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32685 >
2024-12-20 08:22:52 +00:00
Marek Olšák
227f69716f
st/mesa: don't use nir_opt_fragdepth because it's incorrect with MSAA
...
Doing "gl_FragDepth = gl_FragCoord.z" with MSAA and without sample shading
changes per-sample depth testing to per-pixel depth testing, so we can't
eliminate it.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12079
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32685 >
2024-12-20 08:22:52 +00:00
Samuel Pitoiset
a7d0f0b30e
radv: check descriptor indexing features for enabling the global BO list
...
It's more accurate.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32718 >
2024-12-20 07:43:59 +00:00
Samuel Pitoiset
62edab4cac
radv: cleanup enabling the global BO list when BDA is used
...
VK_{EXT,KHR}_buffer_device_address are redundant with the
bufferDeviceAddress feature.
VK_KHR_ray_tracing_pipeline depends on VK_KHR_acceleration_structure
which also depends on the bufferDeviceAddress feature.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32718 >
2024-12-20 07:43:59 +00:00
Pavel Ondračka
b06797633d
r300: disable ATI2N textures on R400
...
The HW can do it, however if the state tracker sees support for ATI2N,
it will assume we also don't need a fallback for ATI1N. So if something
actually tries to use ATI1N format later, we will crash.
This could be fixed at the st level, but I honestly don't think the added
complexity is worth it, especially as this is highly r300 specific and
only affects single generation. So just disable it.
Signed-off-by: Pavel Ondračka <pavel.ondracka@gmail.com >
Reviewed-by: Filip Gawin <filip@gawin.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32639 >
2024-12-20 07:31:11 +00:00
Mel Henning
6f6072448d
gallium/winsys/nouveau: Don't mark the api PUBLIC
...
We don't want to export this symbol from our shared object - any use of
this function from outside of mesa (like the ddx) should get the version
from libdrm, not the private copy in mesa.
Fixes: 821f4c8d99 ("nouveau: import libdrm_nouveau")
Reviewed-by: Karol Herbst <kherbst@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32740 >
2024-12-20 03:35:36 +00:00
Karol Herbst
6646b5f95b
rusticl: fix clippy::doc-lazy-continuation
...
Reviewed-by: @LingMan
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32723 >
2024-12-20 03:13:34 +00:00
Karol Herbst
c2ec0c26fd
rusticl: fix clippy::needless-lifetimes
...
Reviewed-by: @LingMan
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32723 >
2024-12-20 03:13:34 +00:00
Karol Herbst
a4d0d1c87b
rusticl/util: fix ptr_to_integer_transmute_in_consts warning
...
We simply remove the const attribute :)
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12288
Reviewed-by: @LingMan
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32723 >
2024-12-20 03:13:34 +00:00
Karol Herbst
de664f05e3
rusticl/platform: silence static_mut_refs warning
...
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12288
Reviewed-by: @LingMan
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32723 >
2024-12-20 03:13:34 +00:00
Marek Olšák
a50d069d1c
nir/opt_varyings: clear info->clip/cull_distance_array_size if relocated
...
svga breaks if shader_info declares these, but the shader is missing
the outputs.
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32684 >
2024-12-20 02:32:08 +00:00
Marek Olšák
9d129505b5
nir/opt_varyings: set all IO types to float to facilitate full vectorization
...
If types differ between components of a vec4 slot, IO vectorization can't
be done.
This also helps drivers like d3d12 that require matching types between
shaders.
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32684 >
2024-12-20 02:32:08 +00:00
Kenneth Graunke
cb756ae8a2
brw: Don't rely on SIMD splitting in opt_combine_convergent_txfs
...
The SIMD splitting pass does not handle wide force_writemask_all
instructions correctly at the moment. For example, a SIMD32 TXF
on pre-Xe2 would get split to a pair of SIMD16. But it will set
the groups to operate on channels 15:0 and 31:16. That's not what
we want for a NoMask instruction - both should be 15:0, i.e.
bld.group(inst->exec_size, 0).
We could (and perhaps should) fix the SIMD splitting pass to handle
this, but the pass already has subtle complexity in which builders
are used. Or we could alter fs_builder::group(), but that has broader
implications. As a stop-gap, just make opt_combine_covergent_txfs stop
relying on SIMD splitting. It's trivial to do and fixes the issue
without risking other breakage.
Fixes: 6341b3cd87 ("brw: Combine convergent texture buffer fetches into fewer loads")
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32714 >
2024-12-19 23:16:12 +00:00
Chia-I Wu
0204baaa8b
panvk: silence a perfetto init warning
...
Kernel drivers gained timestamp support in 6.13. CI might be on an
older kernel, but on a build with perfetto enabled. Silence the
warning.
Signed-off-by: Chia-I Wu <olvaffe@gmail.com >
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32728 >
2024-12-19 19:00:13 +00:00
Job Noorman
419879ee62
ir3,freedreno: remove binning outputs after vs ucp lowering
...
nir_lower_clip_vs relies on VARYING_SLOT_CLIP_VERTEX which gets removed
when removing the outputs that are unused by the binning vs. Fix this by
only removing the outputs after running nir_lower_clip_vs.
Signed-off-by: Job Noorman <jnoorman@igalia.com >
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12328
Fixes: 24b422dc3e ("ir3: remove unused outputs for binning pass in NIR")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32727 >
2024-12-19 17:32:26 +00:00
Jordan Justen
adfd7486c2
iris: Check that mem_fence_bo was created
...
Cc: José Roberto de Souza <jose.souza@intel.com >
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Fixes: 8e8097245f ("iris: Emit STATE_SYSTEM_MEM_FENCE_ADDRESS")
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: José Roberto de Souza <jose.souza@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32716 >
2024-12-19 08:54:00 -08:00
Erik Faye-Lund
4bcb92d35b
nvk: use vk_descriptor_type_is_dynamic
...
No need to open-code this one now that we have a generic helper.
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32627 >
2024-12-19 15:12:58 +00:00
Erik Faye-Lund
dc5ac13959
dozen: use vk_descriptor_type_is_dynamic
...
No need to open-code this one now that we have a generic helper.
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32627 >
2024-12-19 15:12:58 +00:00
Erik Faye-Lund
97dec34a89
hasvk: use vk_descriptor_type_is_dynamic
...
No need to open-code this one now that we have a generic helper.
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32627 >
2024-12-19 15:12:58 +00:00
Erik Faye-Lund
e17abeca44
anv: use vk_descriptor_type_is_dynamic
...
No need to open-code this one now that we have a generic helper.
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32627 >
2024-12-19 15:12:58 +00:00
Erik Faye-Lund
4de0e11b92
lavapipe: use vk_descriptor_type_is_dynamic
...
No need to open-code this one now that we have a generic helper.
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32627 >
2024-12-19 15:12:58 +00:00
Erik Faye-Lund
3df7eda3a8
panvk: use vk_descriptor_type_is_dynamic
...
No need to open-code this one now that we have a generic helper.
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32627 >
2024-12-19 15:12:58 +00:00
Erik Faye-Lund
6877ff7d9b
pvr: use vk_descriptor_type_is_dynamic
...
No need to open-code this one now that we have a generic helper.
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32627 >
2024-12-19 15:12:58 +00:00