Emma Anholt
f9ecf99ca9
kopper: Use the swap interval that was set at swapchain creation time.
...
We need to track what the caller has given us for swap interval, and use
that to set the present mode at startup.
Fixes incorrect vblank syncing in apitrace's glretrace, which sets the
swap interval to 0 before the swapchain is made.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17470 >
2022-07-12 21:57:23 +00:00
Emma Anholt
f3d3368065
kopper: Fix the return value of kopperSetSwapInterval().
...
Compare to dri2SetSwapInterval() and dri3_set_swap_interval()
implementations of the same method.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17470 >
2022-07-12 21:57:23 +00:00
Marek Vasut
378da2c3ff
etnaviv: Implement TXD
...
Fill in support for TXD instruction which emits shader TEXLDD opcode.
Signed-off-by: Marek Vasut <marex@denx.de >
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com >
Reviewed-by: Lucas Stach <l.stach@pengutronix.de >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17500 >
2022-07-12 21:28:11 +00:00
Marek Vasut
221d042c31
etnaviv: Rename etna_emit_tex() args
...
Rename the args from low_bias/compare to src1/src2, since they
are used for different purposes depending on the texture load
type. No functional change.
Signed-off-by: Marek Vasut <marex@denx.de >
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com >
Reviewed-by: Lucas Stach <l.stach@pengutronix.de >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17500 >
2022-07-12 21:28:11 +00:00
Yiwei Zhang
20eeb529f7
venus: GetPhysicalDeviceSparseImageFormatProperties to match sparse support
...
Test: dEQP-VK.api.info.sparse_image_format_properties2.*
Fixes: 1a7632e54b ("venus: add NO_FENCE_FEEDBACK perf option and disable sparse resource")
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org >
Reviewed-by: Ryan Neph <ryanneph@google.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17476 >
2022-07-12 21:20:19 +00:00
Enrico Galli
1f0d27e45f
microsoft/spirv_to_dxil: Fix discard to demote + return pass
...
While SPIR-V's OpKill is block terminating, the converted discard
intrinsic is not block terminating. This can lead to issues where
instruction could be placed after discard.
This patch adds an extra pass that drops all instructions after discard
before we convert discards.
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17474 >
2022-07-12 20:22:52 +00:00
Samuel Pitoiset
ed6c346155
zink/ci: update list of CTS flakes for RADV
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17492 >
2022-07-12 19:23:39 +00:00
Adam Jackson
82fea22607
glx: Fix return values from __glXGetDrawableAttribute
...
This is intended to return true on attribute-found.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17422 >
2022-07-12 18:43:24 +00:00
Adam Jackson
11c30fcad0
glx/dri2: Stop tracking the protocol version in the display state
...
We only use it at init time, no need to keep it around.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17422 >
2022-07-12 18:43:24 +00:00
Adam Jackson
1255d370b7
glx: Remove excess screen parameter from CreateContext
...
This is effectively looked up from the config anyway, which we're
already passing in.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17422 >
2022-07-12 18:43:24 +00:00
Adam Jackson
215200d8f1
glx: Remove unused __glXSetupForCommand from __glXIsDirect
...
This was needed when we emitted an xlib request here, but xcb knows the
GLX major opcode for the connection already.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17422 >
2022-07-12 18:43:24 +00:00
Adam Jackson
61834ae898
glx: Remove some can't-happen checks from protocolDestroyDrawable
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17422 >
2022-07-12 18:43:24 +00:00
Connor Abbott
cf0cfd572e
freedreno/a6xx: VPC_SO_NCOMP is actually VPC_SO_BUFFER_STRIDE
...
This answers the question in a comment in turnip, and fixes some GL46
tests and piglit tests.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17494 >
2022-07-12 17:57:07 +00:00
Emma Anholt
7976d558d5
vc4: Add links to test bug reports.
...
Reviewed-by: Adam Jackson <ajax@redhat.com >
Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17449 >
2022-07-12 17:15:43 +00:00
Emma Anholt
2f851f0479
vc4: Work around a HW bug with 2-vert line loops.
...
Reviewed-by: Adam Jackson <ajax@redhat.com >
Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17449 >
2022-07-12 17:15:43 +00:00
Emma Anholt
0f37e3c339
mesa: Fix the error check for VertexAttrib*.
...
It was checking "mesa's theoretical max attributes" rather than "the
driver's max attributes."
Reviewed-by: Adam Jackson <ajax@redhat.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17449 >
2022-07-12 17:15:43 +00:00
Emma Anholt
0feedec9e6
zink: Do the timestamp-to-ns math in a double to have better precision.
...
Fixes arb_timer_query-timestamp-get on my radv system, where the GPU has
been on for many days and the timestamp would only increment every once in
a while.
Part of fixing #6808
Fixes: 7a40b734ee ("zink: handle timestamp queries")
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17477 >
2022-07-12 16:58:10 +00:00
Gert Wollny
cf1715e391
r600/sfn: Don't use assert to test success of operation
...
With that the actual call will be eliminated if the code is
compiled with NDEBUG.
Fixes: 79ca456b48
r600/sfn: rewrite NIR backend
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6832
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Reviewed-by: Filip Gawin <filip@gawin.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17496 >
2022-07-12 16:48:20 +00:00
Eric Engestrom
75938f9d1f
venus: use updated tokens from vk.xml
...
Signed-off-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org >
Acked-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17342 >
2022-07-12 15:53:11 +00:00
Eric Engestrom
8fa577340c
panvk: use updated tokens from vk.xml
...
Signed-off-by: Eric Engestrom <eric@igalia.com >
Acked-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17342 >
2022-07-12 15:53:11 +00:00
Eric Engestrom
a96ddc3803
dzn: use updated tokens from vk.xml
...
Signed-off-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Acked-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17342 >
2022-07-12 15:53:11 +00:00
Eric Engestrom
0225293a97
anv: use updated tokens from vk.xml
...
Signed-off-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Acked-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17342 >
2022-07-12 15:53:11 +00:00
Eric Engestrom
9554462f4d
pvr: use updated tokens from vk.xml
...
Signed-off-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: Frank Binns <frank.binns@imgtec.com >
Acked-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17342 >
2022-07-12 15:53:11 +00:00
Eric Engestrom
ebb3ea5790
lavapipe: use updated tokens from vk.xml
...
Signed-off-by: Eric Engestrom <eric@igalia.com >
Acked-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17342 >
2022-07-12 15:53:11 +00:00
Eric Engestrom
0ab33ec6d4
zink: use updated tokens from vk.xml
...
Signed-off-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com >
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Acked-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17342 >
2022-07-12 15:53:11 +00:00
Hoe Hao Cheng
c8bd10852c
zink/codegen: use the updated identifiers
...
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Acked-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17342 >
2022-07-12 15:53:11 +00:00
Eric Engestrom
2c99dc5b22
turnip: use updated tokens from vk.xml
...
Signed-off-by: Eric Engestrom <eric@igalia.com >
Acked-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Reviewed-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17342 >
2022-07-12 15:53:11 +00:00
Eric Engestrom
9db1af8757
v3dv: use updated tokens from vk.xml
...
Signed-off-by: Eric Engestrom <eric@igalia.com >
Acked-by: Iago Toral Quiroga <itoral@igalia.com >
Acked-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17342 >
2022-07-12 15:53:11 +00:00
Eric Engestrom
9035408d62
radv: use updated tokens from vk.xml
...
Signed-off-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Acked-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17342 >
2022-07-12 15:53:11 +00:00
Eric Engestrom
9844a2fb64
nir: use updated tokens from vk.xml
...
Signed-off-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17342 >
2022-07-12 15:53:11 +00:00
Eric Engestrom
e706a915b0
vulkan: use updated tokens from vk.xml
...
Signed-off-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17342 >
2022-07-12 15:53:11 +00:00
Eric Engestrom
c3d8395a14
vulkan/runtime: use updated tokens from vk.xml
...
Signed-off-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17342 >
2022-07-12 15:53:11 +00:00
Eric Engestrom
66af355a00
vulkan: add script to detect & replace identifiers that have been renamed
...
Signed-off-by: Eric Engestrom <eric@engestrom.ch >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17342 >
2022-07-12 15:53:11 +00:00
Jason Ekstrand
af6f6ce065
vulkan/wsi: Add debug variables to force the SW and PRIME buffer blit paths
...
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17436 >
2022-07-12 14:14:01 +00:00
Jason Ekstrand
3ff7494a97
vulkan/wsi/wayland: Add a BUFFER_TYPE flag
...
This makes all the different ways of presenting a bit more clear.
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17436 >
2022-07-12 14:14:01 +00:00
Jason Ekstrand
f336a4f9b3
anv: Init supported extensions before WSI
...
Otherwise WSI extension support checks won't work.
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17436 >
2022-07-12 14:14:01 +00:00
Mike Blumenkrantz
fb917a606c
lavapipe: don't crash on null xfb buffer pointer
...
cc: mesa-stable
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17469 >
2022-07-12 13:43:37 +00:00
Mike Blumenkrantz
276557b9c6
lavapipe: don't overwrite entire VkFormatProperties3 struct
...
this clobbers pNext and breaks tooling, as found by Panagiotis Apostolou
Fixes: f72d5a930b ("lavapipe: KHR_format_feature_flags2")
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17462 >
2022-07-12 13:31:00 +00:00
SoroushIMG
eb6faf329c
zink: Fix BO size when it's not aligned to 16 bytes
...
glsl_get_explicit_size can return non-16 byte aligned sizes.
Therefore, make sure the sure the size isrounded up so that OOB does not happen.
Fixes: ea8a0654f5 ("zink: further improve bo sizing")
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17460 >
2022-07-12 12:58:02 +00:00
Konstantin Seurer
e8d12bc2b7
radv: Fix acceleration structure size queries
...
From looking at the CTS,
VK_QUERY_TYPE_ACCELERATION_STRUCTURE_SIZE_KHR
refers to the serialization size and not to the
actual, current size.
Fixes the following CTS:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.query_pool_results.cpu.buffer.size
dEQP-VK.ray_tracing_pipeline.acceleration_structures.query_pool_results.cpu.memory.size
dEQP-VK.ray_tracing_pipeline.acceleration_structures.query_pool_results.gpu.buffer.size
dEQP-VK.ray_tracing_pipeline.acceleration_structures.query_pool_results.gpu.memory.size
Fixes: 5d56c2c ("radv: Add accel struct queries for maintenance1")
Signed-off-by: Konstantin Seurer <konstantin.seurer@gmail.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17444 >
2022-07-12 12:30:42 +00:00
Bas Nieuwenhuizen
97641e5c94
radv: Add ability to override the build id for the cache.
...
This would allow us to keep the shader cache key the same for updates
that we know won't impact compilation on SteamOS.
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17426 >
2022-07-12 12:08:12 +00:00
Iago Toral Quiroga
f286289c7f
v3dv: remove unused lowering for nir_intrinsic_load_layer_id
...
This intrinsic is only produced when the compiler is instructed
to handle layer id as a system value, which we don't use. Also,
we have been supporting layered rendering for a while and passing
all the relevant tests which would've failed if we were hitting
this lowering.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17483 >
2022-07-12 11:47:13 +00:00
Iago Toral Quiroga
5a4c5f46c7
v3dv: fix comment in texel buffer shader copy path
...
When using the texel buffer copy path to copy a buffer we need to
sample from the buffer and for that we need a texture shader state
record where we specify the base offset of the texture (the buffer).
If the copy operation has a start offset we can't add that offset
to the base address of the buffer because the texture state record
requires the base pointer to be 64-byte aligned, so it would only
work for offsets that are multiple of 64B. Instead, we pass the
offset (in elements) to the shader and we use that to shift the
indices into the buffer when selecting the source texel to copy.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17482 >
2022-07-12 10:48:45 +00:00
Adam Jackson
4fbc237cae
gallium/dri: Remove the memory of GLX_MESA_multithread_makecurrent
...
The only way this could happen was if GLX did it, which it doesn't.
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17473 >
2022-07-12 10:02:46 +00:00
Adam Jackson
92b2e479b8
glx: Remove the remains of GLX_MESA_multithread_makecurrent
...
This hasn't actually been exported for a while. I think I probably broke
this in
commit 63a6b719d9
Author: Adam Jackson <ajax@redhat.com >
Date: Tue Dec 5 11:10:09 2017 -0500
glx: GLX_MESA_multithread_makecurrent is direct-only
in which I made it no longer default to having client support, but
failed to instruct dri{2,3,sw} to enable it. In any case, it was never
widely used, there is no EGL equivalent, and we've had zero complaints
about it getting nerfed.
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17473 >
2022-07-12 10:02:46 +00:00
Konstantin Seurer
d528289c74
radv: Skip pipeline_no_null_shaders_flag tests
...
Those tests either fail or hang so just exclude
all of them for now to make ray tracing CTS usable
again.
Signed-off-by: Konstantin Seurer <konstantin.seurer@gmail.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17443 >
2022-07-12 09:36:29 +00:00
Samuel Pitoiset
e9b2fa6527
radv: fix wide points/lines by configuring the guardband correctly
...
Fixes all remaining wide points/lines failures with Zink.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6121
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17392 >
2022-07-12 09:11:40 +02:00
Nanley Chery
a07919edeb
mesa: Follow ASTC decode mode extension for RGBA8 output
...
The GL extension, EXT_texture_compression_astc_decode_mode, enables
applications to specify the desired decoding precision when decoding
non-sRGB ASTC textures. The options for the channels are FP16 (the
default), UNORM8, and RGB9_E5.
The ASTC LDR decoder outputs to UNORM8 by doing the following
conversions: UNORM16 -> FP16 -> UNORM8. This doesn't seem to be defined
by any specification and is costly according to perf profiles. To
conform to the decode mode spec (and for better performance), we convert
UNORM16 to UNORM8 by simply storing/keeping the top 8 bits.
In a texture upload microbenchmark, this decreases the upload time for
textures in the linear color space by about 34%.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17195 >
2022-07-11 21:59:42 +00:00
Nanley Chery
dab0936141
mesa: Simplify UNORM8 conversions for sRGB ASTC textures
...
The ASTC extension specs state that a vector of UNORM8 values are
returned when decoding sRGB ASTC textures. For the alpha channel
however, they don't seem to specify how to get there from the UNORM16
produced after interpolation (or returned from a void-extent block).
The ASTC decoder in the VK-GL-CTS project treats the alpha channel like
the RGB channels and simply uses the top 8 bits of the UNORM16. For
better performance, we choose to do the same.
In a texture upload microbenchmark, this decreases the upload time for
textures in the sRGB color space by about 13%.
Ref: https://gitlab.khronos.org/egl/DataFormat/-/merge_requests/32
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17195 >
2022-07-11 21:59:42 +00:00
Adam Jackson
81b0862642
mesa: Stub out GL_APPLE_object_purgeable
...
There's slots in the glapi static dispatch table (which is still
arguably ABI) which we need to preserve, but we can stop exposing the
extension string or doing anything in the added functions.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Acked-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17425 >
2022-07-11 16:37:34 -04:00