Samuel Pitoiset
f5ba4e855e
radv: do not remove PSIZ for VS when the topology is unknown
...
When compiling only the pre-rast stages in a library, the input
assembly state might not be present and the topology would be 0.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18519 >
2022-09-16 08:22:16 +00:00
Samuel Pitoiset
7f91555d4c
radv: enable the VS prologs cache if graphicsPipelineLibrary is enabled
...
GPL will re-use most of the VS prologs code.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18519 >
2022-09-16 08:22:16 +00:00
Samuel Pitoiset
c199a5160a
radv: bind the VS input state for prologs created with GPL
...
If we have a VS that needs a prolog without using the dynamic state,
that means that it comes from a library, so we can overwrite the
cmdbuf VS input state.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18519 >
2022-09-16 08:22:16 +00:00
Samuel Pitoiset
0feab7b9cf
radv: prepare the VS input state for prologs created with GPL
...
This state will be bound at pipeline bind time.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18519 >
2022-09-16 08:22:16 +00:00
Samuel Pitoiset
fdfa59d7bf
radv: rename radv_pipeline_key::vs::dynamic_vs_input to has_prolog
...
With GPL it's possible to create VS prologs without this dynamic state,
so it seems better to rename.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18519 >
2022-09-16 08:22:16 +00:00
Samuel Pitoiset
57b3bff41a
radv: disable VK_EXT_graphics_pipeline_library with LLVM
...
Epilogs/prologs aren't supported at all.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18609 >
2022-09-16 07:12:40 +00:00
Iago Toral Quiroga
591103d04d
v3dv: don't return incompatible driver if GPU is not present
...
Instead, we should just return VK_SUCCESS. The physical device
won't be initialized and vkEnumeratePhysicalDevices will not
list it as available, which is the expected behavior here.
Also, VK_ERROR_INCOMPATIBLE_DRIVER is not a valid return code
from vkEnumeratePhysicalDevices, so never return that, instead
we return VK_ERROR_INITIALIZATION_FAILED if a valid device was
found but we failed to create the physical device for it.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Tested-By: Ryan Houdek <Sonicadvance1@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18591 >
2022-09-16 05:42:26 +00:00
Emma Anholt
03294e1dd1
turnip: Keep a host copy of push descriptor sets.
...
Otherwise, the back-copy on same-layout push descriptor updates would read
from WC memory, which is absurdly slow. Improves performance of
vkoverhead's descriptor_template_12ubo_push from 760k/sec to 2876k/sec.
Improves submit-disabled gfxbench gl_driver2 performance on zink from 79.6
fps to 103.6.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18561 >
2022-09-16 02:43:44 +00:00
Emma Anholt
e313098427
turnip: Ignore pDescriptorCounts[] for non-variable-count layouts.
...
The spec says "If VkDescriptorSetAllocateInfo::pSetLayouts[i] does not
include a variable-sized descriptor binding, then pDescriptorCounts[i] is
ignored." So, make sure that we ignore it unless there is a
variable-sized binding. And, we can keep it simple just taking the
variable-sized path for variable-sized bindings with the 0 variable_count
value to handle "If descriptorSetCount is zero or this structure is not
included in the pNext chain, then the variable lengths are considered to
be zero."
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18561 >
2022-09-16 02:43:44 +00:00
Yonggang Luo
a9f3e011e5
drm-shim: drop gnu99 override
...
If we override with gnu99 here, we effectively down-grade from C11,
meaning we can no longer assume static_assert support.
Fixes: 45fb815a75 ("util: implement STATIC_ASSERT using c++11 / c11 primitives")
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Suggested-by: Chia-I Wu <olvaffe@gmail.com >
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Reviewed-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: Chia-I Wu <olvaffe@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18611 >
2022-09-16 02:06:38 +00:00
Emma Anholt
7b2bdb31f2
turnip: Skip rather than invalidate LRZ on gl_FragDepth writes.
...
As long as the direction is still compatible, if we skip the LRZ use and
updates for this draw, then we can keep using LRZ later in the scene, as
whatever gl_FragDepth will get written by the shader later will still have
to move the depth in the right direction.
Similarly, the no_earlyz flag that contributes to DISABLE_LRZ just wants
to make sure we don't kill fragments before dispatch, not change what Z
eventually lands.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18606 >
2022-09-15 21:45:05 +00:00
Emma Anholt
62d8124522
turnip: Don't look at RB.Z_READ_ENABLE for setting LRZ.Z_TEST_ENABLE.
...
It will always be set in HW when RB.Z_WRITE_ENABLE is set (since that
implies RB.Z_TEST_ENABLE), but in the case of dynamic Z the flag gets
computed at emit time and not stored to cmd->state.rb_depth_cntl. This
bug effectively disabled LRZ for zink.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18606 >
2022-09-15 21:45:05 +00:00
Emma Anholt
52d35cc82a
turnip: Ignore dynamic color write enables past our number of attachments.
...
We were always disabling LRZ writes on zink+turnip because it sets all the
color write enables (translating directly from GL turning them all on).
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18606 >
2022-09-15 21:45:05 +00:00
Emma Anholt
f6d15818ca
turnip: Add some missing LRZ disable debug.
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18606 >
2022-09-15 21:45:05 +00:00
Alyssa Rosenzweig
6938c9f9cd
u_transfer_helper: Pack Z24S8 to Z24-in-Z32F and S8
...
On Asahi needed to pass
dEQP-GLES3.functional.texture.specification.texsubimage2d_depth.depth24_stencil8
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Acked-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18136 >
2022-09-15 21:19:39 +00:00
Alyssa Rosenzweig
45a37ace28
u_transfer_helper: Handle Z24X8 for drivers that don't use the
...
interleaved transfer_map
Fixes
dEQP-GLES3.functional.texture.format.sized.2d.depth_component24_pot on
Asahi.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Acked-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18136 >
2022-09-15 21:19:39 +00:00
Konstantin Seurer
b12cc5c4fe
radv: Cleanup radv_GetInstanceProcAddr
...
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18600 >
2022-09-15 20:50:17 +00:00
Juston Li
fc1ff335d9
venus: use buffer cache for vkGetDeviceBufferMemoryRequirements
...
Align with vkGetBufferMemoryRequirements2 and utilize the cache for
retrieving memory requirements before trying the host call.
Fixes
dEQP-VK.api.invariance.memory_requirements_matching
dEQP-VK.memory.requirements.create_info.buffer.regular
Signed-off-by: Juston Li <justonli@google.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18603 >
2022-09-15 20:35:18 +00:00
Chia-I Wu
fe36f763d6
vulkan: update comments to device enumeration callbacks
...
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com >
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18607 >
2022-09-15 20:01:29 +00:00
Hans-Kristian Arntzen
f5b46a643f
radv: Implement VK_EXT_mutable_descriptor_type.
...
Trivial promotion from VALVE, just rename enums and types.
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18610 >
2022-09-15 16:55:25 +00:00
Hans-Kristian Arntzen
3bfda5cc0e
vulkan: Update to 1.3.228 headers.
...
Acked-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18610 >
2022-09-15 16:55:25 +00:00
Sil Vilerino
3d4c36a3bc
d3d12: d3d12_video_buffer_create_impl make resident after checking for resource creation
...
Reviewed-by: Giancarlo Devich <gdevich@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18328 >
2022-09-15 11:19:39 -04:00
Sil Vilerino
2003d2d928
d3d12: Add VPBlit processor check for D3D12_FEATURE_VIDEO_PROCESS_MAX_INPUT_STREAMS
...
Reviewed-by: Giancarlo Devich <gdevich@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18328 >
2022-09-15 11:19:39 -04:00
Sil Vilerino
0325a2a1a3
d3d12: Allow video processing for formats other than NV12
...
Reviewed-by: Giancarlo Devich <gdevich@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18328 >
2022-09-15 11:19:39 -04:00
Sil Vilerino
07bb5951fc
d3d12: Allow formats other than NV12 in d3d12_video_buffer
...
Reviewed-by: Giancarlo Devich <gdevich@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18328 >
2022-09-15 11:19:39 -04:00
Sil Vilerino
fd84575809
d3d12: Add support for importing d3d12_video_buffer from handle
...
Reviewed-by: Giancarlo Devich <gdevich@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18328 >
2022-09-15 11:19:39 -04:00
Sil Vilerino
59c45e1ed7
d3d12: Fix leak in d3d12_resource_from_resource and usage in d3d12 video dec, enc
...
Reviewed-by: Giancarlo Devich <gdevich@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18328 >
2022-09-15 11:19:39 -04:00
Sil Vilerino
cdd83c6110
d3d12: Fix winsys displaytarget leak in d3d12_resource
...
Reviewed-by: Giancarlo Devich <gdevich@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18328 >
2022-09-15 11:19:39 -04:00
Sil Vilerino
cd03643309
d3d12: Fix leak in d3d12_video_proc when re-creating ID3D12VideoProcessor
...
Reviewed-by: Giancarlo Devich <gdevich@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18328 >
2022-09-15 11:19:39 -04:00
Sil Vilerino
c0e1548844
d3d12: Fill feedback in d3d12_video_encoder_encode_bitstream so vaSyncSurface properly populates buf->coded_size
...
Reviewed-by: Giancarlo Devich <gdevich@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18328 >
2022-09-15 11:19:39 -04:00
Sil Vilerino
d672cc39ba
d3d12: Avoid heap allocations on hot path d3d12_video_decoder_dxva_picparams_from_pipe_picparams_hevc
...
Using pre-allocated storage now.
Reviewed-by: Giancarlo Devich <gdevich@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18328 >
2022-09-15 11:19:39 -04:00
Sil Vilerino
d3f0733d1d
d3d12: Avoid local allocations for D3D12_RESOURCE_BARRIER on hot paths
...
Reviewed-by: Giancarlo Devich <gdevich@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18328 >
2022-09-15 11:19:39 -04:00
Sil Vilerino
5c2ec8efc8
d3d12: Avoid extra allocation, copies when generating DXVA_Slice_Hxxx_Short arrays
...
Reviewed-by: Giancarlo Devich <gdevich@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18328 >
2022-09-15 11:19:39 -04:00
Sil Vilerino
da11684e9d
d3d12: Add HEVC Decode/Encode
...
Reviewed-by: Giancarlo Devich <gdevich@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18328 >
2022-09-15 11:19:39 -04:00
Sil Vilerino
f2d172a8be
gallium/vl: Rename s_addr variable in vl_idct.c as it conflicts with windows existing inaddr.h keyword definition
...
Reviewed-by: Giancarlo Devich <gdevich@microsoft.com >
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18328 >
2022-09-15 11:19:39 -04:00
Sil Vilerino
e0b732e506
gallium/vl: Allow vl_zscan.h to be included from C++
...
Reviewed-by: Giancarlo Devich <gdevich@microsoft.com >
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18328 >
2022-09-15 11:19:34 -04:00
Sil Vilerino
8e92c76c34
d3d12/va: Name convention rename PIPE_VIDEO_SUPPORTS_CONTIGUOUS_PLANES_MAP to PIPE_VIDEO_CAP_SUPPORTS_CONTIGUOUS_PLANES_MAP
...
Reviewed-by: Giancarlo Devich <gdevich@microsoft.com >
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18328 >
2022-09-15 11:19:34 -04:00
Sil Vilerino
427135ea6d
frontends/va: Support HEVC caps regarding features, block sizes, prediction direction
...
Add new pipe structures: PIPE_VIDEO_CAP_ENC_HEVC_BLOCK_SIZES, PIPE_VIDEO_CAP_ENC_HEVC_FEATURE_FLAGS, PIPE_VIDEO_CAP_ENC_HEVC_PREDICTION_DIRECTION
Implement new VA caps VAConfigAttribEncHEVCFeatures, VAConfigAttribEncHEVCBlockSizes, VAConfigAttribPredictionDirection
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18328 >
2022-09-15 11:19:34 -04:00
Sil Vilerino
2670756965
frontends/va: Extend single to multiple L0-L1 references for HEVC Encode
...
Also fixing refactored variable name for L0/L1 lists in drivers/radeonsi to avoid build break.
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18328 >
2022-09-15 11:19:28 -04:00
Sil Vilerino
56684b85e9
frontends/va: Add HEVC Encode support multi slice and extend pipe args
...
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18328 >
2022-09-15 11:19:23 -04:00
Sil Vilerino
52f23f923e
frontends/va: Mark IsLongTerm in HEVC decode args
...
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18328 >
2022-09-15 11:19:18 -04:00
Sil Vilerino
ee62f4d614
frontends/omx: Fill HEVC Decode param IntraPicFlag
...
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18328 >
2022-09-15 11:19:09 -04:00
Sil Vilerino
5efd4bbf7f
frontends/vdpau: Fill HEVC Decode param IntraPicFlag
...
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18328 >
2022-09-15 11:19:00 -04:00
Sil Vilerino
c7acd6788e
frontends/va: Add HEVC decode args: IntraPicFlag, no_pic_reordering_flag, no_bipred_flag
...
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18328 >
2022-09-15 11:18:44 -04:00
Sil Vilerino
a6e32bf15b
frontends/va: Add HEVC decode slice descriptors
...
Adds HEVC decoded slice descriptors to the pipe interface and also to the VA frontend
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18328 >
2022-09-15 11:18:43 -04:00
Martin Roukala (né Peres)
2aa4ed16e2
radv/ci: move some tests from the renoir fail to its flake list
...
This mirrors the change we made for vega10 (6bbe3c6d3 ) in August...
Seems like the chances of a PASS are indeed slim, but possible.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18590 >
2022-09-15 14:12:07 +00:00
Erik Faye-Lund
ba7e87a03d
panfrost: do not fake rgtc-support
...
Panfrost doesn't expose LATC format support at all, so RGTC
state-tracker level RGTC support is sufficient to drop the fake RGTC
flag on Panfrost.
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Acked-by: Eric Engestrom <eric@igalia.com >
Tested-by: Eric Engestrom <eric@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18248 >
2022-09-15 08:16:01 +00:00
Erik Faye-Lund
df58342f61
mesa/st: enable rgtc extension with fallback
...
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Acked-by: Eric Engestrom <eric@igalia.com >
Tested-by: Eric Engestrom <eric@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18248 >
2022-09-15 08:16:01 +00:00
Erik Faye-Lund
f25875ce18
mesa/st: do not fall back to uncompressed for rgtc
...
This logic doesn't really do what it pretends to; we don't expose the
RGTC features unless we actually have RGTC support. This is about to
change, but for that logic to work, we need to be able to tell if we're
using a fallback-format or not, and we can't do that unless we keep the
format as RGTC.
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Acked-by: Eric Engestrom <eric@igalia.com >
Tested-by: Eric Engestrom <eric@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18248 >
2022-09-15 08:16:01 +00:00
Erik Faye-Lund
1735053de5
mesa/st: implement fallback for rgtc
...
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Acked-by: Eric Engestrom <eric@igalia.com >
Tested-by: Eric Engestrom <eric@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18248 >
2022-09-15 08:16:01 +00:00