Alyssa Rosenzweig
f5161f6cec
pan/va: Generalize LD_VAR_IMM_* to support flat varyings
...
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14292 >
2021-12-22 22:01:20 +00:00
Alyssa Rosenzweig
8df1b42eb0
pan/va: Add .signed bit to right shift instructions
...
This makes the RSHIFT_* family of instructions act like ARSHIFT.* on
Bifrost.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14292 >
2021-12-22 22:01:20 +00:00
Alyssa Rosenzweig
73d7a046ff
pan/va: Rename LEA_ATTR to LEA_VARY
...
This more accurately reflects the function of the instruction. Unlike
earlier Malis, there don't seem to be attribute records for varyings.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14292 >
2021-12-22 22:01:20 +00:00
Alyssa Rosenzweig
1e5a20a33b
pan/va: Remove extra LD_VAR_IMM_F32 source
...
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14292 >
2021-12-22 22:01:20 +00:00
Dave Airlie
4392c24844
intel/compiler: drop unused decleration
...
Acked-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14202 >
2021-12-22 21:37:55 +00:00
Dave Airlie
2692a5f8db
intel/compiler: don't lower swizzles in backend.
...
These are lowered by crocus in the frontend, the key
entries are still used.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14202 >
2021-12-22 21:37:55 +00:00
Dave Airlie
e12b0d0d60
intel/compiler: remove gfx6 gather wa from backend.
...
Crocus lowers this in the frontend, they key member is still used
but reset prior to backend.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14202 >
2021-12-22 21:37:55 +00:00
Dave Airlie
ebaba7a2fd
mesa/dd: drop unused InvalidateBufferSubData entry.
...
I already removed the users of this, but forgot the entry.
Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14286 >
2021-12-22 20:59:23 +00:00
Dave Airlie
57a730f4ad
mesa: drop unused _mesa_new_program.
...
This isn't used since classic removal.
Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14286 >
2021-12-22 20:59:23 +00:00
Dave Airlie
3c9bbe2fa1
mesa: drop unused new renderbuffer code.
...
This isn't used anywhere currently
Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14286 >
2021-12-22 20:59:23 +00:00
Dave Airlie
be277ace89
mesa/st: use has_stencil_export instead of querying screen cap.
...
We already query at context setup, just use that value.
Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14286 >
2021-12-22 20:59:23 +00:00
Dave Airlie
37190ad932
mesa: drop texformat code this isn't used.
...
v2: dropped comment (Tapani)
Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14286 >
2021-12-22 20:59:23 +00:00
Timur Kristóf
739bf4d0be
spirv: Allow VRS with mesh shaders.
...
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com >
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14291 >
2021-12-22 21:29:22 +01:00
Thomas H.P. Andersen
c8c00fc6c3
draw: drop unused function
...
Introduced in 381e9fe6 . Never used.
Fixes a compile warning with clang
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14252 >
2021-12-22 17:02:00 +00:00
Thomas H.P. Andersen
a7c5645dd3
gallium/tgsi_exec: drop unused function
...
Introduced in 9ca6cf0f and last usage
dropped in 31369987
Fixes a compile warning with clang
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14252 >
2021-12-22 17:02:00 +00:00
Thomas H.P. Andersen
887b838632
gallium/u_threaded: drop unused function
...
tc_drop_sampler_view_reference is unused. It was introduced
in 340703e0 and its last usage was dropped in bb89cf4bf3
Fixes a compile warning with clang
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14252 >
2021-12-22 17:02:00 +00:00
Thomas H.P. Andersen
2a5b867594
glx: remove a set but not used variable
...
total_sent was never used. It was introduced in
fdb07636f2
Fixes a warning in clang
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14252 >
2021-12-22 17:02:00 +00:00
Thomas H.P. Andersen
46a0f6384e
r600: remove a set but not used variable
...
grid_size was never used. Not even when introduced
in 6a829a1b72
Fixes a warning on clang
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14252 >
2021-12-22 17:02:00 +00:00
Thomas H.P. Andersen
ea33eceb32
r300: remove a set but not used variable
...
The use of phase_refmask was removed 12 years ago
in b7cf887ca7
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14252 >
2021-12-22 17:02:00 +00:00
Thomas H.P. Andersen
202ebf9969
i915g: fix implicit-fallthrough warning
...
Fixes a warning on clang.
Uses FALLTHROUGH like the surrounding code.
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14252 >
2021-12-22 17:02:00 +00:00
Thomas H.P. Andersen
57f6ef69b9
lavapipe: fix implicit-fallthrough warning
...
Fixes a warning on clang
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14252 >
2021-12-22 17:02:00 +00:00
Marcin Ślusarz
a48f1d51e2
intel/compiler: disable workaround not applicable to gfx >= 11
...
There's nothing in bspec that would suggest this is still needed.
It only affected gfx 9 and 10.
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com >
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14280 >
2021-12-22 10:13:25 +00:00
Guido Günther
7440fbd596
etnaviv: Use mesa_log*
...
Makes it consistent with the DRM bits
Signed-off-by: Guido Günther <guido.gunther@puri.sm >
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com >
Acked-by: Lucas Stach <l.stach@pengutronix.de >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10546 >
2021-12-22 09:16:07 +01:00
Guido Günther
01bb981d57
entaviv/drm: Use same log format as gallium bits
...
We prefix with __func__:__LINE__ there.
Signed-off-by: Guido Günther <guido.gunther@puri.sm >
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com >
Acked-by: Lucas Stach <l.stach@pengutronix.de >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10546 >
2021-12-22 09:16:04 +01:00
Guido Günther
b5eacfc469
etnaviv/drm: Use mesa_log* for debugging
...
This makes sure errors, warnings and info messages don't get
compiled out in non debug builds.
Signed-off-by: Guido Günther <agx@sigxcpu.org >
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com >
Acked-by: Lucas Stach <l.stach@pengutronix.de >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10546 >
2021-12-22 09:16:00 +01:00
Guido Günther
afbccdf8f9
etnaviv/drm: Print gpu model at debug verbosity
...
Otherwise we print it at every application start.
Signed-off-by: Guido Günther <guido.gunther@puri.sm >
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com >
Acked-by: Lucas Stach <l.stach@pengutronix.de >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10546 >
2021-12-22 09:15:57 +01:00
Guido Günther
a93c0e1860
etnaviv/drm: Add some bo debug output
...
This makes it simpler to trace BO usage.
Signed-off-by: Guido Günther <agx@sigxcpu.org >
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com >
Acked-by: Lucas Stach <l.stach@pengutronix.de >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10546 >
2021-12-22 09:15:53 +01:00
Guido Günther
87879b0633
etnaviv/drm: Use etna_mesa_debug for debugging messages
...
We use the variable from gallium but fall back to a weak symbol
in case there's usage out of galllium in the future.
Signed-off-by: Guido Günther <agx@sigxcpu.org >
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com >
Acked-by: Lucas Stach <l.stach@pengutronix.de >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10546 >
2021-12-22 09:15:02 +01:00
Tapani Pälli
ebd1f202ae
glsl: fix invariant qualifer usage and matching rule for GLSL 4.20
...
I noticed that GLSL version referenced here was wrong, version 4.20 is
first spec that does not allow invariant keyword for inputs.
v2: fix all comments (Timothy Arceri)
Fixes: f9f462936a ("glsl: Fix invariant matching in GLSL 4.30 and GLSL ES 1.00.")
Signed-off-by: Tapani Pälli <tapani.palli@intel.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14241 >
2021-12-22 06:01:37 +00:00
Thomas H.P. Andersen
0bc5e8cddc
ci: debian-clang: drop -Wno-error for self-assign
...
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14272 >
2021-12-22 03:34:23 +00:00
Thomas H.P. Andersen
f1dfc6a780
gallivm: avoid a self-assign warning
...
Fixes a clang warning
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14272 >
2021-12-22 03:34:23 +00:00
Vinson Lee
9f8a204645
panfrost: Avoid double unlock.
...
Fix defect reported by Coverity Scan.
Double unlock (LOCK)
double_unlock: pthread_mutex_unlock unlocks dev->indirect_draw_shaders.lock while it is unlocked.
Fixes: 2e6d94c198 ("panfrost: Add helpers to support indirect draws")
Suggested-by: Alyssa Rosenzweig <alyssa@collabora.com >
Signed-off-by: Vinson Lee <vlee@freedesktop.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14262 >
2021-12-22 02:01:57 +00:00
Vinson Lee
1d6f6f9102
ir3: Make shift operand 64-bit.
...
Fix defect reported by Coverity Scan.
Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN)
overflow_before_widen: Potentially overflowing expression 2 << W
with type int (32 bits, signed) is evaluated using 32-bit
arithmetic, and then used in a context that expects an expression
of type uint64_t (64 bits, unsigned).
Signed-off-by: Vinson Lee <vlee@freedesktop.org >
Acked-by: Rob Clark <robclark@freedesktop.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14258 >
2021-12-22 01:19:46 +00:00
Timur Kristóf
b293299776
aco/optimizer_postRA: Fix applying VCC to branches.
...
Fixes: a93092d0ed
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com >
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14281 >
2021-12-21 22:53:23 +00:00
Timur Kristóf
ce4daa259c
aco/optimizer_postRA: Fix combining DPP into VALU.
...
Fixes: 4ac47ad1cd
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com >
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14281 >
2021-12-21 22:53:23 +00:00
Thomas H.P. Andersen
14a204b19d
ci: clean up debian-clang no-error list
...
I see no warnings for these on a local build
Reviewed-by: Michel Dänzer <mdaenzer@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14269 >
2021-12-21 22:24:16 +00:00
Caio Oliveira
ac90519e35
anv: Simplify assertions related to graphics stages
...
In all three cases, COMPUTE was on the table but with an invalid
value (zero). Drop it from the tables and the extra assertion, so if
a COMPUTE is passed it will just fail the ARRAY_SIZE assertion.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14274 >
2021-12-21 18:25:05 +00:00
Daniel Schürmann
d36a43598c
aco/ra: fix get_reg_for_operand() in case of stride mismatches
...
We have to clear the register file from the previous operand
as otherwise, there might be no space left.
Totals from 5 (0.00% of 134572) affected shaders: (GFX10.3)
CodeSize: 21144 -> 21000 (-0.68%); split: -0.72%, +0.04%
Instrs: 3738 -> 3720 (-0.48%); split: -0.51%, +0.03%
Latency: 517229 -> 516319 (-0.18%); split: -0.18%, +0.00%
InvThroughput: 49068 -> 48902 (-0.34%); split: -0.38%, +0.04%
Copies: 501 -> 483 (-3.59%); split: -3.79%, +0.20%
Cc: mesa-stable
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14279 >
2021-12-21 17:15:45 +00:00
Jesse Natalie
664810ebb0
d3d12: Fix NV12 resource importing
...
Fixes: a6db8054 ("d3d12: Handle opening planar resources")
Reviewed-by: Sil Vilerino <sivileri@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14276 >
2021-12-21 16:56:45 +00:00
Daniel Schürmann
17ecd0b31a
nir/opt_algebraic: lower fneg_hi/lo to fmul
...
This pattern, found in the FSR upscaling shader,
helps the vectorization efforts by keeping the
chain of vectorized instructions intact.
Radeon can optimize it to per-component fneg modifiers.
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13688 >
2021-12-21 13:23:37 +01:00
Daniel Schürmann
30a7199e37
aco/optimizer: propagate and fold inline constants on VOP3P instructions
...
This patch aims to propagate and fold constants on VOP3P instructions
by using omod selection and the fneg modifier.
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13688 >
2021-12-21 13:23:36 +01:00
Daniel Schürmann
62bcfcd0a8
aco: change fneg for VOP3P to use fmul with +1.0
...
This will be useful to be able to also apply
fneg_lo and fneg_hi.
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13688 >
2021-12-21 13:23:36 +01:00
Daniel Schürmann
193bd740ab
aco/optimizer: fix fneg modifier propagation on VOP3P
...
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13688 >
2021-12-21 13:23:36 +01:00
Caio Oliveira
de916d827f
anv: Refactor dirty masking in cmd_buffer_flush_state
...
Instead of masking the dirty variable itself, use an appropriate mask
in the users of dirty. This will avoid extra tracking when dealing
with Task/Mesh later.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14275 >
2021-12-21 11:07:31 +00:00
Caio Oliveira
37fca614b8
anv/blorp: Split blorp_exec into a render and compute
...
And set the relevant push_constants_dirty for each case.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14275 >
2021-12-21 11:07:31 +00:00
Roman Stratiienko
2686c5419d
v3dv: add Android support
...
Acknowledgements to android-rpi team and lineage-rpi maintainer (KonstaT)
for creating/testing initial vulkan support. Their experience was used as
a baseline for this work.
Most of the code is a copy of turnip and anv.
Improved by cleaning dEQP failures:
- Improved gralloc support (use allocation time stride, size, modifier).
- Fixed some dEQP crashes due to memory allocation issues.
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com >
Signed-off-by: Roman Stratiienko <r.stratiienko@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14016 >
2021-12-21 09:24:43 +00:00
Emma Anholt
658b2ca467
r300/vs: Fix flow control processing just after an endloop.
...
We tried to step over the instruction we just generated, except we didn't
always just generate one. In the sequence_vertex tests, that meant we
skipped processing the next BGNLOOP and then underflowed our stack.
Cc: mesa-stable
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14271 >
2021-12-21 01:05:07 +00:00
Emma Anholt
b48852436e
r300/vs: Reuse rc_match_bgnloop().
...
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14271 >
2021-12-21 01:05:07 +00:00
Emma Anholt
e41a53cd19
r300/vs: Allocate temps we see a use as a source, too.
...
This is a quick hack for a bunch of the fail in #5766 .
Cc: mesa-stable
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14271 >
2021-12-21 01:05:07 +00:00
Emma Anholt
e3d0ceccc9
ci/r300: Add another xfail on the main branch.
...
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14271 >
2021-12-21 01:05:07 +00:00