Bas Nieuwenhuizen
e553ea51e8
radv: Create sparse images.
...
Disable all metadata for now.
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7953 >
2021-01-11 12:01:34 +00:00
Bas Nieuwenhuizen
d3286bdd76
radv/winsys: Fix offset in range merging.
...
If we change the virtual address we also have to change the offset in the buffer
to be mapped.
Fixes: 715df30a4e "radv/amdgpu: Add winsys implementation of virtual buffers."
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7953 >
2021-01-11 12:01:34 +00:00
Bas Nieuwenhuizen
2b12e6931e
radv/winsys: Fix inequality for sparse buffer remapping.
...
Found a case where we mapped a range too many.
Per the comment the constraint is:
/* [first, last] is exactly the range of ranges that either overlap the
* new parent, or are adjacent to it. This corresponds to the bind ranges
* that may change.
*/
So that means that after the ++last we the ranges[last] should still
be adjacent. So we need to test the post-increment value to see whether
it is adjacent.
Failure case:
ranges:
0: 0 - ffff
1: 10000 - 1ffff
2: 20000 - 2ffff
3: 30000 - 3ffff
new range: 10000 - 1ffff
wrong first, last: 0,3
However range 3 clearly isn't adjacent at all.
Fixes: 715df30a4e "radv/amdgpu: Add winsys implementation of virtual buffers."
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7953 >
2021-01-11 12:01:34 +00:00
Bas Nieuwenhuizen
f56a28daa4
ac/surf: Use correct tilemodes on GFX8 for PRT.
...
Otherwise addrlib will assign the non-PRT tiling indices anyway ...
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7953 >
2021-01-11 12:01:34 +00:00
Bas Nieuwenhuizen
50bafb85ec
ac/surf: Add sparse texture info to radeon_surf.
...
For GFX9 I didn't reuse the existing mipmap offset/pitch because
last time we did that there was a revert request from Marek.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7953 >
2021-01-11 12:01:34 +00:00
Bas Nieuwenhuizen
cd5458f367
ac/surf: Implement PRT layout.
...
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7953 >
2021-01-11 12:01:34 +00:00
Bas Nieuwenhuizen
dea1c06c9b
ac/surf: Prepare for 64-bit flags.
...
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7953 >
2021-01-11 12:01:34 +00:00
Samuel Pitoiset
8914efb5b7
radv: only re-initialize HTILE after ds compute resolves if compressed
...
If the current layout isn't compressed we don't have to re-initialize
the HTILE metadata.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8389 >
2021-01-11 11:27:05 +00:00
Samuel Pitoiset
1645d9ebab
radv: re-initialize HTILE properly after depth/stencil compute resolves
...
This was added to workaround some CTS failures which no longer happen.
Note that radv_clear_htile() will only clear the depth or stencil
bytes of the HTILE buffer based on the aspect.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8389 >
2021-01-11 11:27:05 +00:00
Samuel Pitoiset
52b6adfbfb
radv: disable TC-compat HTILE in GENERAL for Detroit: Become Human
...
The game has invalid usage of render loops and enabling TC-compat
HTILE in GENERAL introduces rendering issues.
Gitlab: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3063
Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8359 >
2021-01-11 11:15:56 +00:00
Samuel Pitoiset
8f9b2afe70
radv: fix crashes when fast-clearing in a secondary command buffer
...
iview can be NULL inside a secondary command buffer.
Fixes: 00064713a3 ("radv: determine at creation if an image view can be fast cleared")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8408 >
2021-01-11 11:07:09 +00:00
Erik Faye-Lund
84772b23dc
zink: use hardware int64 when supported
...
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8403 >
2021-01-11 10:47:58 +00:00
Erik Faye-Lund
5a11b374c5
zink: add missing 64-bit integer ops
...
This seems to be all that's missing to support hardware int64 instead of
lowering it.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8403 >
2021-01-11 10:47:58 +00:00
Erik Faye-Lund
6199651e91
zink: add missing opcodes
...
This fixes a bunch of conversion-tests in the arb_gpu_shader_int64
piglit test-suite for me.
Fixes: 55e2d836f3 ("zink: enable 64bit pipe caps")
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8403 >
2021-01-11 10:47:58 +00:00
Pierre-Eric Pelloux-Prayer
6f2017205e
dri: enable glthread + radeonsi workaround for CS:GO
...
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4021
Reviewed-by: Zoltán Böszörményi <zboszor@gmail.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8383 >
2021-01-11 10:28:06 +00:00
Pierre-Eric Pelloux-Prayer
c4427c2b53
ac/rgp: add missing include
...
The build would fail without this include if -std=gnu17 is used.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4057
Fixes: ffdfe136e6 ("ac/sqtt: move rgp/sqtt def to ac")
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8376 >
2021-01-11 10:11:09 +00:00
Samuel Pitoiset
94d1462def
ci: re-mark some depth/stencil resolve CTS as expected failures
...
They were removed during the last update but they still fail.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8385 >
2021-01-11 09:54:09 +00:00
Samuel Pitoiset
6e7008e94b
radv: do not predicate FMASK decompression when DCC+MSAA is used
...
Even if the FCE predicate is FALSE, we might still need to decompress
FMASK if compressed rendering was used. FMASK decompressions should
never been predicated.
This fixes a ton of CTS failures and a rendering issue with Control
when DCC+MSAA is force-enabled.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8331 >
2021-01-11 09:30:41 +00:00
Samuel Pitoiset
00064713a3
radv: determine at creation if an image view can be fast cleared
...
This can be determined earlier than every time a clear is performed
by the driver, it probably saves a bunch of CPU cycles.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8370 >
2021-01-11 08:31:11 +01:00
Adam Jackson
55ccc9eca5
ci: Add a few more drivers to the cross builds
...
This is mostly to get additional -Werror coverage to avoid introducing
unforced ILP32 or big-endian errors. i386 adds lavapipe, r600, nouveau,
zink, and all the classic drivers. ppc64le adds lavapipe and zink, and
also adds -Werror for symmetry with the other cross builds. s390x also
adds lavapipe and zink.
Reviewed-by: Eric Anholt <eric@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8394 >
2021-01-10 21:15:46 +00:00
Adam Jackson
a22a1c0324
zink: Fix VK_FORMAT_A8B8G8R8_SRGB_PACK32 mapping on big-endian
...
The PACK32 Vulkan formats need to map to the corresponding XYZWxxxx pipe
formats, since the latter take endianness into account.
Reviewed-by: Eric Anholt <eric@anholt.net >
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8394 >
2021-01-10 21:15:46 +00:00
Adam Jackson
1a8dcfc74c
nouveau: pacify gcc on ILP32
...
The gcc we're using (and quite possibly newer ones) throws a really
stupid error:
../src/gallium/drivers/nouveau/nouveau_buffer.c:765:22: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
buffer->address = (uint64_t)user_ptr;
Which... address is a uint64_t, and user_ptr is a void *, so this is
completely unambiguously safe to do. Apparently casting to uintptr_t
squelches this, so do that instead.
Reviewed-by: Eric Anholt <eric@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8394 >
2021-01-10 21:15:46 +00:00
Christian Gmeiner
a302de9a43
etnaviv: add set_stream_output_targets(..) stub
...
When running gles3 deqp's with ETNA_MESA_DEBUG=deqp we fake streamout support.
CSO thinks that streamout is supported and calls ctx->pipe->set_stream_output_targets(..)
in cso_destroy_context(..) which results in a null-pointer access.
Add a stub to make development easier.
Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8382 >
2021-01-10 20:42:37 +00:00
Erik Faye-Lund
6993109713
zink: setup compiler options during init
...
This avoids duplicating the options just to change a single one.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8402 >
2021-01-10 13:06:45 +00:00
Erik Faye-Lund
df82fb58d0
zink: rename zink vs pipe variables
...
The general convention we use is "pscreen" for the pipe_screen, and
"screen" for the zink_screen, so let's stick with that here also.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8402 >
2021-01-10 13:06:45 +00:00
X512
0b910cc019
util/u_thread: Disable pthread_barrier_t on Haiku
...
* Causes a lockup on SMP systems
Reviewed-by: Alexander von Gluck IV <kallisti5@unixzen.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8323 >
2021-01-09 20:51:39 -06:00
X512
065cf4f914
hgl: Major refactor and cleanup
...
* Drop old-timey GLDisplatcher
* Refactor haiku-softpipe fixing some hacks
* Bubble BBitmap up to winsys
Reviewed-by: Alexander von Gluck IV <kallisti5@unixzen.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8323 >
2021-01-09 20:51:35 -06:00
X512
bd6ea80d96
targets/haiku-softpipe: Restore GalliumContext
...
Reviewed-by: Alexander von Gluck IV <kallisti5@unixzen.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8323 >
2021-01-09 20:51:31 -06:00
X512
a534cd2827
aux/driver_ddebug: Normalize pid type from Haiku
...
Reviewed-by: Alexander von Gluck IV <kallisti5@unixzen.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8323 >
2021-01-09 20:51:27 -06:00
X512
f47feaa72b
frontends/hgl: set framebuffer id
...
Reviewed-by: Alexander von Gluck IV <kallisti5@unixzen.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8323 >
2021-01-09 20:51:24 -06:00
X512
19ed0f0803
frontends/hgl: set state_manager
...
Reviewed-by: Alexander von Gluck IV <kallisti5@unixzen.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8323 >
2021-01-09 20:51:22 -06:00
X512
98045b50f5
hgl: use local headers instead of system header
...
* We should choose the header we're building with
and not the one installed by a previous mesa install
Reviewed-by: Alexander von Gluck IV <kallisti5@unixzen.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8323 >
2021-01-09 20:51:21 -06:00
X512
17900983e0
include: fix export in Haiku OpenGL kit headers
...
Reviewed-by: Alexander von Gluck IV <kallisti5@unixzen.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8323 >
2021-01-09 20:51:19 -06:00
X512
99616fe799
meson: fix Haiku EGL build; no dri requirement
...
Reviewed-by: Dylan Baker <dylan@pnwbakers.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8323 >
2021-01-09 20:51:17 -06:00
X512
759f9b9874
hgl/meson: add version to libGL.so
...
Reviewed-by: Dylan Baker <dylan@pnwbakers.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8323 >
2021-01-09 20:51:15 -06:00
X512
dd959174cb
targets/haiku-softpipe/meson: add libswpipe.so to install directory
...
Reviewed-by: Dylan Baker <dylan@pnwbakers.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8323 >
2021-01-09 20:51:13 -06:00
X512
97520d8d48
util/meson: Add libnetwork dependency for Haiku
...
Reviewed-by: Dylan Baker <dylan@pnwbakers.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8323 >
2021-01-09 20:51:08 -06:00
X512
71f4a74368
util: implement GET_PROGRAM_NAME for Haiku
...
Reviewed-by: Alexander von Gluck IV <kallisti5@unixzen.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8323 >
2021-01-09 20:51:03 -06:00
Rhys Perry
b634d7f3e2
nir/opt_vectorize: fix srcs_equal() with two different non-const
...
To match hash_alu_src(), this should return false if both are different
non-const ssa defs.
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Eric Anholt <eric@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8391 >
2021-01-09 11:14:05 +00:00
Rhys Perry
bdf316ae7b
nir/opt_vectorize: fix typo in instr_can_rewrite()
...
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Eric Anholt <eric@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8391 >
2021-01-09 11:14:05 +00:00
Mauro Rossi
e7444bd3a6
android: ac/radv: fix typo in ac_rgp.h listed in Makefile.sources
...
Fixes the following building error:
error: external/mesa/src/amd/Android.mk: libmesa_amd_common: Unused source files: common/ac_rgph.
Fixes: 4ec5cf5318 ("ac/radv: move radv_rgp.c to ac")
Signed-off-by: Mauro Rossi <issor.oruam@gmail.com >
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8371 >
2021-01-09 11:15:09 +01:00
Marek Olšák
be50c7f329
gallium/u_threaded: skip draws if user index buffer size has size == 0
...
This happens when all draws have count == 0.
Fixes: 85b6ba136b "st/mesa: implement Driver.DrawGallium callbacks
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8345 >
2021-01-09 06:53:00 +00:00
Marek Olšák
c69b8fd651
vbo: fix a index buffer map failure with size = 0 in get_minmax_indices_gallium
...
Fixes: 85b6ba136b "st/mesa: implement Driver.DrawGallium callbacks
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8345 >
2021-01-09 06:53:00 +00:00
Marek Olšák
3c75473525
mesa: skip draws w/ count == 0 and instance_count == 0 in draw_gallium_fallback
...
Fixes: 85b6ba136b "st/mesa: implement Driver.DrawGallium callbacks
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8345 >
2021-01-09 06:53:00 +00:00
Marek Olšák
8fc6a19765
gallium: skip draws with count == 0 or instance_count == 0 in drivers
...
Fixes: 85b6ba136b "st/mesa: implement Driver.DrawGallium callbacks"
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8345 >
2021-01-09 06:53:00 +00:00
nia
275079e3ad
util: Avoid pthread_setaffinity_np on NetBSD
...
NetBSD's variant has a different prototype from the Linux version
the code expects. It might make sense to add support for NetBSD's
version, however, since NetBSD defaults to not allowing non-root
users to set processor affinity, there would be little gain here.
This is a build fix for NetBSD.
Signed-off-by: Nia Alarie <nia@NetBSD.org >
Reviewed-by: Dylan Baker <dylan@pnwbakers.com >
CC: 20.3 <mesa-stable@lists.freedesktop.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7947 >
2021-01-09 06:22:13 +00:00
Vinson Lee
5c59e4efe2
clover: Add constructor for clover::module.
...
Fix defect reported by Coverity Scan after commit 95527fe229
("clover/module: add a printf support to module (v5)").
Uninitialized scalar variable (UNINIT)
uninit_use_in_call: Using uninitialized value
m.printf_strings_in_buffer when calling module.
Signed-off-by: Vinson Lee <vlee@freedesktop.org >
Reviewed-by: Francisco Jerez <currojerez@riseup.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8322 >
2021-01-08 18:28:43 -08:00
Nanley Chery
fb4e67df1e
iris: Drop fast_clear_color's blorp_flags param
...
Now that conditional fast clears are disabled, the blorp_flags parameter
is unused.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7762 >
2021-01-08 23:23:31 +00:00
Nanley Chery
04ac3a6620
iris: Delete iris_resolve_conditional_render
...
This function has no more users.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7762 >
2021-01-08 23:23:31 +00:00
Nanley Chery
c3785c0c9d
iris: Disable conditional fast clears
...
For color buffers, conditional fast clears can cause aux-state tracking
to lose information necessary for resolves later on.
For depth buffers, they never actually worked because they occurred
unconditionally. Even if they were conditional, they would suffer from
the same issues as color buffers.
Enables iris to pass the nv_conditional_render-clear-bug piglit test.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3565
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7762 >
2021-01-08 23:23:31 +00:00