Alyssa Rosenzweig
e126338394
asahi: Precompile for shader-db
...
This gets shader-db's runner working, in conjunction with a shader-db ./run
modified to set ASAHI_MESA_DEBUG=precompile. This flag triggers precompiles of
all shaders witha default key so we can exercise the compiler.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18813 >
2022-10-22 14:54:07 -04:00
Alyssa Rosenzweig
46ae8e659d
asahi: Remove AGX_FAKE_DEVICE environment variable
...
The proper way to fake a device on Linux will be drm-shim.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18813 >
2022-10-22 14:54:07 -04:00
Alyssa Rosenzweig
13e90bebe1
agx: Remove command line compiler
...
It has not been used in quite some time but adds maintainence burden.
Its function is replaced by drm-shim in conjunction with shader-db's
./run, which goes through the actual driver.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18813 >
2022-10-22 14:54:07 -04:00
Alyssa Rosenzweig
80de33cf6a
nir/opt_preamble: Move load_texture_base_agx
...
nir_opt_preamble will be crucial to optimize out the lowering for array
textures on AGX, which involves this AGX-specific sysval.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Acked-by: Connor Abbott <cwabbott0@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18813 >
2022-10-22 14:48:04 -04:00
Alyssa Rosenzweig
ba551d293f
asahi: Hold a reference to BOs in a batch
...
Fixes GPU-side use after frees, e.g. in dEQP-GLES2.functional.texture.vertex.2d.wrap.clamp_mirror
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19215 >
2022-10-22 13:52:53 +00:00
Georg Lehmann
741dbadae0
nir: Fix ifind_msb_rev constant folding.
...
For example if src0 is 0x80000000 we should return 1, not 0.
Signed-off-by: Georg Lehmann <dadschoorse@gmail.com >
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Fixes: a5747f8ab3 ("nir: add opcodes for *find_msb_rev and lowering")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18951 >
2022-10-22 11:57:55 +02:00
Georg Lehmann
125741dbae
nir/opt_algebraic: Optimize various find_msb_rev patterns.
...
From dxvk, dxil-spirv, fxc, dxc and others.
Totals from 177 (0.13% of 134913) affected shaders:
CodeSize: 1079504 -> 1059872 (-1.82%)
Instrs: 195381 -> 192269 (-1.59%)
Latency: 3664137 -> 3631951 (-0.88%)
InvThroughput: 599479 -> 585675 (-2.30%)
Signed-off-by: Georg Lehmann <dadschoorse@gmail.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18951 >
2022-10-22 11:57:33 +02:00
Georg Lehmann
d57f5c9cac
radv,aco: Lower uclz in NIR.
...
Signed-off-by: Georg Lehmann <dadschoorse@gmail.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18951 >
2022-10-22 11:57:23 +02:00
Georg Lehmann
7505be3497
nir/opt_algebraic: Add an option to lower uclz.
...
Signed-off-by: Georg Lehmann <dadschoorse@gmail.com >
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18951 >
2022-10-22 11:57:10 +02:00
Georg Lehmann
049b60cf4b
ac/llvm: Implement [ui]find_msb_rev.
...
Signed-off-by: Georg Lehmann <dadschoorse@gmail.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18951 >
2022-10-22 11:57:06 +02:00
Georg Lehmann
058174c4de
aco: Implement [ui]find_msb_rev.
...
Signed-off-by: Georg Lehmann <dadschoorse@gmail.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18951 >
2022-10-22 11:57:00 +02:00
Georg Lehmann
1e552b9c95
nir/opt_algebraic: Mirror optimizations for find_msb_rev.
...
Signed-off-by: Georg Lehmann <dadschoorse@gmail.com >
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18951 >
2022-10-22 11:56:44 +02:00
Konstantin Seurer
b5ecb5388e
radv/rt: Fix setting tmax for opaque AABBs
...
data->vars->tmax will be overwritten by inner_vars.tmax so we have to
set inner_vars.tmax instead. This probably doesn't affect anything in
practise.
cc: mesa-stable
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19207 >
2022-10-22 08:55:58 +00:00
Emma Anholt
22f7f167cd
nir/opt_phi_precision: Fix missing swizzles when narrowing phi srcs.
...
This NIR:
vec4 32 ssa_169 = phi block_1: ssa_168, block_2: ssa_138
vec1 16 ssa_209 = f2fmp ssa_169.x
vec1 16 ssa_210 = f2fmp ssa_169.y
vec1 16 ssa_211 = f2fmp ssa_169.z
vec1 16 ssa_212 = f2fmp ssa_169.w
vec4 16 ssa_213 = vec4 ssa_209, ssa_210, ssa_211, ssa_212
intrinsic store_output (ssa_213, ssa_171) (base=0, wrmask=xyzw /*15*/, component=0, src_type=float16 /*144*/, io location=4 slots=1 mediump /*8388740*/, xfb() /*0*/, xfb2() /*0*/)
would turn into:
vec4 32 ssa_169 = phi block_1: ssa_168, block_2: ssa_138
vec4 16 ssa_216 = phi block_1: ssa_214, block_2: ssa_215
vec1 16 ssa_209 = f2fmp ssa_169.x
vec1 16 ssa_210 = f2fmp ssa_169.y
vec1 16 ssa_211 = f2fmp ssa_169.z
vec1 16 ssa_212 = f2fmp ssa_169.w
vec4 16 ssa_213 = vec4 ssa_216.x, ssa_216.x, ssa_216.x, ssa_216.x
intrinsic store_output (ssa_213, ssa_171) (base=0, wrmask=xyzw /*15*/, component=0, src_type=float16 /*144*/, io location=4 slots=1 mediump /*8388740*/, xfb() /*0*/, xfb2() /*0*/)
ignoring the swizzles from the f2fmp srcs. Fixes failures in
dEQP-GLES2.functional.shaders.random.all_features.fragment.20 on
turnip+ANGLE.
Fixes: c7b935962b ("nir: Add pass to lower phi precision")
Reviewed-by: Connor Abbott <cwabbott0@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19179 >
2022-10-22 03:06:31 +00:00
Yonggang Luo
783b416e65
ci/macos: Building both dri and xlib version of glx
...
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19221 >
2022-10-22 01:34:53 +00:00
Yonggang Luo
6c9f8d8662
xlib: Remove macro guard with GLX_INDIRECT_RENDERING in xlib.c
...
According meson about with_glx == 'xlib' check only defied '-DUSE_XSHM',
so the macro check GLX_INDIRECT_RENDERING make no-sense, removed it.
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19221 >
2022-10-22 01:34:53 +00:00
Yonggang Luo
5bed3d4ad6
meson: with_glx never assigned to 'gallium-xlib', remove 'gallium-xlib'
...
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19221 >
2022-10-22 01:34:53 +00:00
Yonggang Luo
814682d00c
meson: with_glx never assigned to 'gallium-xlib', so need add with_glx == 'xlib' for dep_glproto
...
Fixes: 76791db088 ("mesa/x11: Remove the swrast-classic-based fake libGL")
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19221 >
2022-10-22 01:34:53 +00:00
Thomas H.P. Andersen
9a7e93f1f6
vulkan: drop const for descriptor set
...
drivers should be able to update the reference count
member of the vk_descriptor_set_layout struct
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19132 >
2022-10-21 22:36:45 +00:00
Mike Blumenkrantz
5aa437a9f1
zink: fix ds3 line stipple enable handling
...
ds3 can be used without line stipple enable if the driver doesn't support
line stipple, so this needs special-casing
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19204 >
2022-10-21 21:27:13 +00:00
Mike Blumenkrantz
12fded5965
zink: fix duplicate VK_DYNAMIC_STATE_LINE_STIPPLE_EXT setting
...
if ds3 is used, this is already set above
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19204 >
2022-10-21 21:27:13 +00:00
Alyssa Rosenzweig
9de7e49e6f
panfrost: Remove NIR_SERIALIZED support
...
Only used by Clover (due to the dynamic pipeloader), which we never
shipped support for. We'll do OpenCL via Rusticl, which does not use the
dynamic pipeloader.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Acked-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18972 >
2022-10-21 21:12:14 +00:00
Rhys Perry
dfce433385
aco/gfx11: optimize LS/HS load_local_invocation_index
...
fossil-db (gfx1100):
Totals from 1361 (1.01% of 135032) affected shaders:
Instrs: 501227 -> 500469 (-0.15%); split: -0.16%, +0.01%
CodeSize: 2730012 -> 2724820 (-0.19%); split: -0.20%, +0.00%
VGPRs: 63716 -> 63688 (-0.04%)
Latency: 2228848 -> 2228858 (+0.00%); split: -0.00%, +0.00%
InvThroughput: 878418 -> 878275 (-0.02%); split: -0.02%, +0.00%
VClause: 14866 -> 14868 (+0.01%); split: -0.03%, +0.04%
SClause: 16674 -> 16645 (-0.17%); split: -0.22%, +0.05%
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19196 >
2022-10-21 20:01:30 +00:00
Rhys Perry
8c716525cf
ac/llvm: ignore g16 if the image opcode doesn't use derivatives
...
g16 is irrelevant in this case.
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19198 >
2022-10-21 19:09:49 +00:00
Rhys Perry
c492779924
ac/llvm: fix mixing non-uniform/uniform sampler/texture descriptors
...
Non-uniform descriptors are not loaded in NIR and instead the pointer is
passed to abi->load_sampler_desc. It can be the case that only the texture
or sampler uses this path.
For the descriptor which doesn't use the path, we would previously pass
NULL to abi->load_sampler_desc.
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19198 >
2022-10-21 19:09:49 +00:00
Damian Korczowski
5b47e32474
d3d12: Fix placed footprint of subresources
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19220 >
2022-10-21 18:57:54 +00:00
Sil Vilerino
479eb67aac
d3d12: HEVC Decode - Fix slice size and offsets translation from VA to DXVA
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19231 >
2022-10-21 17:56:38 +00:00
Samuel Pitoiset
897adcf7d7
radv: disable AMD_shader_explicit_vertex_parameter on GFX11
...
Not supported by ACO.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19230 >
2022-10-21 16:42:12 +00:00
Samuel Pitoiset
c18e39ebca
radv: disable VK_AMD_texture_gather_bias_lod on GFX11
...
image_gather4_b_o no longer exists apparently, so this is likely
broken.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19230 >
2022-10-21 16:42:12 +00:00
Samuel Pitoiset
59be3b8a8f
radv: advertise VK_EXT_extended_dynamic_state3
...
Some tricky dynamic states still need to be implemented for full ds3
support with Zink, I will implement them later.
Pass dEQP-VK.pipeline.*extended_dynamic_state* on NAVI21.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18882 >
2022-10-21 15:56:52 +00:00
Samuel Pitoiset
e48c0fbd8f
radv: add support for dynamic depth clamp enable
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18882 >
2022-10-21 15:56:52 +00:00
Samuel Pitoiset
31f946f4d2
radv: add support for dynamic provoking vertex mode
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18882 >
2022-10-21 15:56:52 +00:00
Samuel Pitoiset
e26d3cd9e8
radv: add support for dynamic depth clip negative one to one
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18882 >
2022-10-21 15:56:52 +00:00
Samuel Pitoiset
fbed3aed4a
radv: add support for dynamic conservative rasterization mode
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18882 >
2022-10-21 15:56:52 +00:00
Samuel Pitoiset
96282ceb9a
radv: add support for dynamic depth clip enable
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18882 >
2022-10-21 15:56:52 +00:00
Samuel Pitoiset
8682e09c33
radv: add support for dynamic sample mask
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18882 >
2022-10-21 15:56:52 +00:00
Samuel Pitoiset
7c38d94261
radv: add support for dynamic alpha to coverage enable
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18882 >
2022-10-21 15:56:52 +00:00
Samuel Pitoiset
6a98329b5e
radv: add support for dynamic line stipple enable
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18882 >
2022-10-21 15:56:52 +00:00
Samuel Pitoiset
17b9aa92b7
radv: add support for dynamic logic op enable
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18882 >
2022-10-21 15:56:52 +00:00
Samuel Pitoiset
f22290949d
radv: add support for dynamic tessellation domain origin
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18882 >
2022-10-21 15:56:52 +00:00
Samuel Pitoiset
6bf34e9f36
radv: add support for dynamic polygon mode
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18882 >
2022-10-21 15:56:52 +00:00
Samuel Pitoiset
e0b4b12066
radv: declare new dynamic states
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18882 >
2022-10-21 15:56:52 +00:00
David Heidelberg
5d23c94dd1
ci/freedreno: add Guilherme Gallo into restricted traces access list
...
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19210 >
2022-10-21 15:22:26 +00:00
Simon Ser
4c080cb8e5
egl: fix error string for dri2_create_image_dma_buf()
...
Using dri2_create_image_khr_texture_error() here prints an error
like so:
command: eglCreateImageKHR, error: EGL_BAD_ALLOC (0x3003), message: "dri2_create_image_khr_texture"
This is confusing, because dri2_create_image_khr_texture() is
unrelated to this error.
Instead, print a more accurate error manually.
Signed-off-by: Simon Ser <contact@emersion.fr >
Reviewed-by: Eric Engestrom <eric@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19156 >
2022-10-21 14:57:25 +00:00
Karol Herbst
e2d67765fa
zink: handle f2f16_rtz
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19212 >
2022-10-21 14:38:26 +00:00
Karol Herbst
813b76aeb6
zink: handle more opcodes for CL
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19212 >
2022-10-21 14:38:25 +00:00
Martin Roukala (né Peres)
4629fe2aab
zink: update the RADV expectations
...
We got 4 more tests passing, let's document that :)
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19190 >
2022-10-21 14:19:35 +00:00
Karol Herbst
4a125f790c
ci/llvmpipe: update to new RUSTICL_ENABLE var
...
Signed-off-by: Karol Herbst <kherbst@redhat.com >
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19149 >
2022-10-21 13:58:07 +00:00
Karol Herbst
cce02f0184
docs: Add documentation for Rusticl's env variables
...
Signed-off-by: Karol Herbst <kherbst@redhat.com >
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19149 >
2022-10-21 13:58:07 +00:00
Karol Herbst
feca63e37e
rusticl: add RUSTICL_ENABLE to have a global way of enabling devices
...
Signed-off-by: Karol Herbst <kherbst@redhat.com >
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19149 >
2022-10-21 13:58:07 +00:00