AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
173,702 Commits 1 Branch 0 Tags
df7be7323a300fe7f146ce07dd3d804849cd628a
Commit Graph

321 Commits

Author SHA1 Message Date
Connor Abbott df7be7323a vk/graphics_state: Don't track each vertex input field 
It's unlikely that anyone will call vkCmdSetVertexInputEXT() twice with
the exact same arguments, so this wasn't really doing anything, and it
hurt performance in the common case as shown via "vkoverhead -test 21"
on turnip.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22301>
 2023-07-03 19:51:05 +00:00
Connor Abbott 2a8e627e3a vulkan: Fix renderpass flags with driver-specific renderpass 
We need to use the driver's renderpass to get the flags if the driver
provides it.

Fixes: f3876db1ee ("vulkan: Plumb rendering flags through vk_graphics_pipeline_state")
Reviewed-by: Faith Ekstrand <faith.ekstrand@gmail.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22301>
 2023-07-03 19:51:05 +00:00
Connor Abbott ea52d0d9e0 vk/graphics_state: Track attachment count as state 
Even if this isn't dynamic state per-se because it always comes from the
pipeline, it's useful to be able to track it for the various dynamic
states that it affects, which may be either precompiled or not on
turnip.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22301>
 2023-07-03 19:51:05 +00:00
Connor Abbott f497cc9d56 vk/graphics_state: Add helpers for pre-baking state 
Previously, drivers have either not supported some dynamic state (like
vertex input or sample locations) at all or it's been always dynamic. In
order to be able to set dynamic state sometimes and other times leave it
up to driver-specific state packets, we need a few helpers.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22301>
 2023-07-03 19:51:05 +00:00
Connor Abbott 5405c9ed50 vk/graphics_state: Fix some assertions when copying state 
On turnip we support dynamic vertex input, but static vertex input is
precompiled and so we will copy from a source without VI to a
destination with VI and it's valid in this case to do nothing. On the
other hand, it should never be valid if VI state is set but the pointer
isn't there, which the code previously silently skipped over. There's a
similar issue with sample locations.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22301>
 2023-07-03 19:51:05 +00:00
Connor Abbott 7da44ef671 vk/graphics_state: Add VI_BINDINGS_VALID state 
This is a mirror of vi::bindings_valid, but we can track it and set it
properly even when vertex input state is precompiled, because it is also
needed on turnip for knowing the size of the vertex buffer and vertex
stride state packets even when vertex input state is precompiled.
Previously drivers that could pre-bake vertex input state were expected
to handle this themselves, but this would've been complicated for turnip
because we can handle both pre-baked and dynamic vertex input state. Now
we have the one field which is correctly set in all circumstances and we
never have to setup space for vertex input state in the pipeline.

Reviewed-by: Faith Ekstrand <faith.ekstrand@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22301>
 2023-07-03 19:51:05 +00:00
Connor Abbott ea4257be32 vk/graphics_state: Add feedback_loop_input_only 
On turnip, there are two cases for feedback loops:

- For feedback loops that involve input attachments, everything works as
  normal in GMEM mode but have to do a workaround in sysmem.
- For feedback loops that may involve any texture, GMEM mode is
  impossible and we have to disable it.

Currently we track this through a special flag on the pipeline, but this
won't be practical in the future. Add a flag to the common renderpass
state struct to patch this info through when using our own renderpass.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22301>
 2023-07-03 19:51:05 +00:00
Connor Abbott 1d5eeefd9b vk/graphics_state: Remove vk_subpass_info 
It only has a subset of the renderpass state, whereas with turnip we
need to use pretty much all of it at one point or another. Just allow
the driver to pass in the entire vk_render_pass_state if it's using its
own renderpass implementation.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22301>
 2023-07-03 19:51:05 +00:00
Tatsuyuki Ishi a9c6f7ffdf vulkan/pipeline_cache: Introduce weak reference mode. 
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23877>
 2023-07-03 13:53:05 +00:00
Tatsuyuki Ishi 47c9fba322 vulkan/pipeline_cache: Move cache_object_unref out of header. 
For future use where private functions are called from unref code.

Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23877>
 2023-07-03 13:53:05 +00:00
Tatsuyuki Ishi 44bfeb77d9 vulkan/pipeline_cache: Move locking outside of remove_object. 
To match a future use case better.

Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23877>
 2023-07-03 13:53:04 +00:00
Tatsuyuki Ishi 64c959e46c vulkan/pipeline_cache: Do not consume object passed into remove_object. 
Future use case will require removing an object with zero ref count, so
leave it up to the caller to call unref.

Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23877>
 2023-07-03 13:53:04 +00:00
Erik Faye-Lund c69dc01796 vulkan: avoid needless constant-folding 
While we're at it, also switch to the nir_f{add,mul}_imm helpers.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23855>
 2023-06-29 07:08:18 +00:00
Konstantin Seurer b0beca8c7a vulkan/rmv,radv: Use common trace trigger 
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20573>
 2023-06-27 06:25:56 +00:00
Konstantin Seurer 291fa05545 vulkan/wsi/x11: Capture traces using a hotkey 
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20573>
 2023-06-27 06:25:56 +00:00
Konstantin Seurer 70489edce4 vulkan: Common trace capturing infrastructure 
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20573>
 2023-06-27 06:25:56 +00:00
Hyunjun Ko e2f95ad296 vulkan/video: keep delta weight and offsets of predicted weight tables in h265 slice parsing 
Signed-off-by: Hyunjun Ko <zzoon@igalia.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23790>
 2023-06-26 15:07:53 +09:00
Tatsuyuki Ishi b69a1b4153 vulkan: Migrate shader module hash to BLAKE3. 
Shaders are the largest thing we hash now, so they benefit from a faster
hash.

Change the field name from `sha1` to `hash` to avoid tying the definition
to a particular algorithm. This doubles down as a precaution against
callers still assuming a 20-byte hash (in which case the compilation will
error out).

Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22571>
 2023-06-23 09:28:04 +00:00
Michel Zou badb85edb8 util: reinstate ENUM_PACKED 
gets rid of warning: 'gcc_struct' attribute ignored [-Wattributes] introduced by !23338

Fixes: 86532fa21d ("util: Use the gcc_struct attribute for packed structures in mingw")
Reviewed-by: Yonggang Luo <luoyonggang@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23478>
 2023-06-21 21:51:59 +00:00
Hyunjun Ko 240b419c03 vulkan/video: consider removed bits when calculating the size of comsumed data. 
Closes: mesa/mesa#9170

Signed-off-by: Hyunjun Ko <zzoon@igalia.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23688>
 2023-06-21 19:24:49 +09:00
Hyunjun Ko 6f2e260d2b vulkan/video: move parsing longterm rps in h265 slice parsing. 
It was just by mistake.

Fixes: efdcacb230 ("vulkan/video: add to parse h265 slice.")

Signed-off-by: Hyunjun Ko <zzoon@igalia.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23688>
 2023-06-21 19:24:08 +09:00
Hyunjun Ko b10631865d vulkan/video: adds more conditions for setting loop_filter_across_slices_enable in h265 slice parsing. 
Fixes: efdcacb230 ("vulkan/video: add to parse h265 slice.")

Signed-off-by: Hyunjun Ko <zzoon@igalia.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23688>
 2023-06-21 19:20:59 +09:00
Caio Oliveira 59a72570b6 compiler: Move spirv into a module of its own 
For historical reasons, nir and vtn were compiled together,
and a bunch of vtn specific targets were defined in
src/compiler/meson.build.

Now that we can, make src/compiler/spirv produce an internal
library that depends on NIR, and is used by the drivers/tools.
Also move the vtn specific targets into that directory's
meson.build.

Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23668>
 2023-06-20 16:18:08 +00:00
Samuel Pitoiset 0432a748ee vulkan/runtime: call CmdSetDepthBias2EXT() from CmdSetDepthBias() 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23696>
 2023-06-20 12:46:28 +00:00
Lionel Landwerlin f39fa39809 vulkan/runtime: add support for EXT_depth_bias_control 
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23716>
 2023-06-20 03:05:01 +00:00
Yonggang Luo b687fa4ccb vulkan: move nir_convert_ycbcr into vulkan runtime 
This only used by vulkan drivers and depends on vulkan util, so do the move to decouple
nir from vulkan utils

Reviewed-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23444>
 2023-06-07 08:42:03 +00:00
Dave Airlie 45a92f14b2 vk/video: add a common function to get block alignments for profiles 
This is to be used by drivers for internal image alignments.

This just adds a common profile to alignment helper.

Cc: mesa-stable
Reviewed-by: Lynne <dev@lynne.ee>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23227>
 2023-05-30 02:53:32 +00:00
Víctor Manuel Jáquez Leal 0e886a93ce vulkan: complete the usage flags for video layouts 
Otherwise Vulkan decoding with FFmpeg crashes on anv.

Reviewed-by: Dave Airlie <airlied@redhat.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23184>
 2023-05-29 02:59:05 +00:00
Samuel Pitoiset 8126e0287d vulkan/pipeline_cache: remove a bogus assert when inserting objects 
If two threads deserialize the raw object at the same time, the
refcount could be more than 1 temporarily.

This can be reproduced with Granite during the multi-threaded pipeline
cache pre-warm on startup, and also with Dota2.

Fixes: cbab396f54 ("vulkan/pipeline_cache: replace raw data objects on cache insertion of real objects")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22853>
 2023-05-25 10:07:35 +00:00
Mike Blumenkrantz dfc01aea83 vk/graphics_state: handle null pipeline state structs in creation 
when these members are null, the corresponding graphics states should be
initialized with sensible default values

Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22236>
 2023-05-22 23:51:22 +00:00
Hyunjun Ko b08614b96b vulkan/video: add h265 reference structures and relevant util functions. 
Signed-off-by: Hyunjun Ko <zzoon@igalia.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22202>
 2023-05-19 06:15:01 +00:00
Hyunjun Ko efdcacb230 vulkan/video: add to parse h265 slice. 
Vulkan spec doesn't provide any interface for slice decoding while some
devices may require them. So we need to keep this inside.

Signed-off-by: Hyunjun Ko <zzoon@igalia.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22202>
 2023-05-19 06:15:01 +00:00
Daniel Schürmann 8bfd18b8c5 vulkan/pipeline_cache: don't log warnings for client-invisible caches 
Fixes: d3f06cf5ce ('vulkan/pipeline_cache: don't log warnings for internal caches')
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22986>
 2023-05-17 20:40:12 +00:00
Jesse Natalie c9146794d4 vulkan: Win32 sync import/export support 
Acked-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22879>
 2023-05-15 17:14:20 +00:00
Chia-I Wu 47b37651f8 vulkan: add vk_image_format_to_ahb_format 
There should be no functional change.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22619>
 2023-05-11 22:18:03 +00:00
Chia-I Wu 380180516c anv,hasvk,radv: do not fall back to AHARDWAREBUFFER_FORMAT_BLOB 
When allocating a VkDeviceMemory exportable as AHB, it seems incorrect
to fall back to AHARDWAREBUFFER_FORMAT_BLOB when the image has no known
AHB format.  We should fail the allocation instead.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22619>
 2023-05-11 22:18:03 +00:00
Chia-I Wu 50e703f347 vulkan: add vk_ahb_format_to_image_format 
There should be no functional change.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22619>
 2023-05-11 22:18:02 +00:00
Chia-I Wu 2bbe0462e8 vulkan: define inline stubs when android api level < 26 
This allows us to reduce ANDROID #ifdef's.

v2: always include vk_android.h in radv_formats.c

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22619>
 2023-05-11 22:18:02 +00:00
Chia-I Wu f81dce9bcc vulkan: rename vk_image::ahardware_buffer_format 
Rename it to ahb_format.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22619>
 2023-05-11 22:18:02 +00:00
Chia-I Wu 5561abcb2c vulkan: make sure vk_image_view::format is never UNDEFINED 
Remove redundant override in anv and hasvk as well.

Fixed
android.graphics.cts.BasicVulkanGpuTest#testBasicBufferImportAndRenderingExternalFormat
for radv.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22619>
 2023-05-11 22:18:02 +00:00
Chia-I Wu df8ec99c81 vulkan: make sure vk_image::format is never UNDEFINED 
vk_image::android_external_format is only used for sanity check and is
removed.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22619>
 2023-05-11 22:18:02 +00:00
Daniel Schürmann d3f06cf5ce vulkan/pipeline_cache: don't log warnings for internal caches 
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22850>
 2023-05-11 08:36:12 +00:00
Mike Blumenkrantz ae4692db49 vulkan/runtime: add VK_DYNAMIC_STATE_ATTACHMENT_FEEDBACK_LOOP_ENABLE_EXT 
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22849>
 2023-05-09 13:29:34 +00:00
Faith Ekstrand fcdf28ad94 vulkan: Document vk_physical_device::supported_features 
While we're here, move it to after supported extensions to stay
consistent with the vk_physical_device_init parameters.

Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Constantine Shablya <constantine.shablya@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22845>
 2023-05-04 17:38:30 +00:00
Dave Airlie fa938dd975 vulkan: write beta extensions into generator scripts. 
Updated by: Hyunjun Ko <zzoon@igalia.com>

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21806>
 2023-05-04 02:40:06 +00:00
Constantine Shablya 64f4b277ea vulkan: inline vk_get_physical_device_features into vk_common_GetPhysicalDeviceFeatures2 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22333>
 2023-05-03 03:27:54 +00:00
Constantine Shablya 61413d70a0 vulkan: introduce supported_features parameter to vk_physical_device_init 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22333>
 2023-05-03 03:27:54 +00:00
Constantine Shablya cc02214304 vulkan: add common implementation of vkGetPhysicalDeviceFeatures2 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22333>
 2023-05-03 03:27:54 +00:00
Emma Anholt c93b179d76 vulkan: Actually increment the count of objects in GetPipelineCacheData. 
Otherwise a load of the cache won't load any of the objects in it!

Fixes: 591da98779 ("vulkan: Add a common VkPipelineCache implementation")
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22700>
 2023-05-03 00:27:49 +00:00
Emma Anholt bc257928d7 vulkan: Handle alignment failure in the pipeline cache. 
On malloc failure, or more likely a passed in pDataSize < pipeline cache
data size, we should return incomplete.  Otherwise,
vk_pipeline_cache_object_serialize will assertion fail about the start not
being aligned.

Closes: #8868
Fixes: 591da98779 ("vulkan: Add a common VkPipelineCache implementation")
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22700>
 2023-05-03 00:27:49 +00:00