AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

vulkan: Handle alignment failure in the pipeline cache.

Browse Source 
On malloc failure, or more likely a passed in pDataSize < pipeline cache
data size, we should return incomplete.  Otherwise,
vk_pipeline_cache_object_serialize will assertion fail about the start not
being aligned.

Closes: #8868
Fixes: 591da98779 ("vulkan: Add a common VkPipelineCache implementation")
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22700>
This commit is contained in:
Emma Anholt
2023-04-25 13:17:26 -07:00
committed by Marge Bot
parent 888bfa7f04
commit bc257928d7
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/vulkan/runtime/vk_pipeline_cache.c
View File

@@ -710,7 +710,10 @@ vk_common_GetPipelineCacheData(VkDevice _device,
intptr_t data_size_resv = blob_reserve_uint32(&blob);
blob_write_bytes(&blob, object->key_data, object->key_size);
blob_align(&blob, VK_PIPELINE_CACHE_BLOB_ALIGN);
if (!blob_align(&blob, VK_PIPELINE_CACHE_BLOB_ALIGN)) {
result = VK_INCOMPLETE;
break;
}
uint32_t data_size;
if (!vk_pipeline_cache_object_serialize(cache, object,