ce79b8a799
radv/ci: move radv-kabini-vkd3d out of gitlab-ci-inc.yml
...
It's currently disabled, which is probably why it was accidentally moved there.
While at it, fix its name to match the rest of the jobs.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34710 >
2025-04-25 12:16:28 +00:00
aecdf762ce
amd/ci: ci yaml indentation
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34710 >
2025-04-25 12:16:27 +00:00
35816d6422
ci/test: fix annoying yamllint warning about 2 spaces before comments
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34710 >
2025-04-25 12:16:27 +00:00
aca1a332c2
ci/build: drop unnecessary shellcheck disables
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34710 >
2025-04-25 12:16:27 +00:00
ab0e505d7f
ci/build: rename variable to avoid changing the meaning of existing variable
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34710 >
2025-04-25 12:16:27 +00:00
8c28f77bd1
ci/build: split git commit sha command out of echo
...
This prevents errors from being masked, eg. when `git` is not installed.
While at it, use `--short=10` instead of piping through `cut`.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34710 >
2025-04-25 12:16:27 +00:00
621aebe046
ci/build: drop unused VERSION from python-artifacts
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34710 >
2025-04-25 12:16:27 +00:00
5be4799734
ci/build: drop lava scripts from builds artifacts
...
The ones used come from the "python-artifacts" job.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34710 >
2025-04-25 12:16:27 +00:00
1f08d75272
ci/build: drop expectation files from python-artifacts
...
The ones used come from the mesa build artifacts.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34710 >
2025-04-25 12:16:27 +00:00
d35c630483
ci/build: drop b2c files from the builds artifacts
...
They haven't been used in a long time.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34710 >
2025-04-25 12:16:27 +00:00
cd8d8ca795
ci: Update kernel to fix GPU recovery issues on sm8350
...
This new revision contains one new commit, fixing GPU recovery failures
on sm8350.
https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/dea4d930f22fc7c52bff7924bc1024a7537ad2d8
Signed-off-by: Valentine Burley <valentine.burley@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34694 >
2025-04-25 11:04:16 +00:00
b03e071583
aco/gfx11: create waitcnt for workgroup vmem barriers
...
It seems this is necessary on GFX11.
Similar to 576a2e798cpendingchaos02@gmail.com >
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com >
Backport-to: 25.0
Backport-to: 25.1
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34634 >
2025-04-25 10:41:52 +00:00
d432fd9e32
panvk: Advertise support for VK_EXT_extended_dynamic_state[2]
...
We added CmdBindVertexBuffers2(), the rest is handled by the core.
Advertising this feature also works around a CTS bug that was
calling CmdSetPatchControlPointsEXT() without checking for this
extension.
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Olivia Lee <benjamin.lee@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34696 >
2025-04-25 09:04:55 +02:00
e3cbb2c131
panvk: Implement CmdBindVertexBuffers2()
...
The vk runtime has a helper to help us with the strides, we just
need to use vi_binding_strides[] when emitting the attributes.
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Olivia Lee <benjamin.lee@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34696 >
2025-04-25 09:02:51 +02:00
1d11872828
etnaviv: nir: Use nir_shader_tex_pass(..)
...
Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com >
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34706 >
2025-04-24 23:12:15 +02:00
3eb7575679
asahi: do not use "Null" layout
...
This is the most serious bug we've had in a long time due to a fundamental
misunderstanding of the hardware (due to incomplete reverse-engineering). It
caught me off guard.
The texture descriptor has "mode" bits which configure two aspects of how the
address pointer is interpreted:
* whether it is indirected, pointing to a secondary page table for sparse
* whether it writes texture access counters (for Metal's idea of sparse).
...Neither of these is a "null texture" mode.
So why did I see Apple's blob using a non-normal mode for null textures, and why
did I copy those settings?
1. Because the hardware texture access counters provide a cheap way to detect
null texture accesses after the fact, which I think their GPU debug tools
use. I'm not sure why release builds of the driver do/did that, but whatever.
2. Because I assumed Cupertino knew best and I didn't bother looking too close.
We can't use them here (without doing extra memory allocations), since then
the GPU will increment access counters. And since our null texture address used
to just be a pointer in the command buffer, that mean the GPU will trash
whatever memory happened to be 0x400 bytes after the start of the null texture
descriptor. The symptom being random faults.
This bug was caught when trying to use the zero-page instead, which raised a
permission fault when the GPU tried to write counts. Then I remembered the
sparse mechanism and had a bit of a eureka moment. Immediately followed by an
"oh, f#$&" moment as I realized how many random bugs could potentially be root
caused to this.
The fix is two-fold:
1. Use normal layout instead.
2. Set the address to the zero-page (which is a fixed VA) and detect null
textures by checking the address, instead of the mode.
The latter is a good idea anyway, but both parts needs to be done atomically to
maintain bisectability.
Backport-to: 25.1
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34703 >
2025-04-24 19:05:07 +00:00
614b66529d
etnaviv: nir: Add support for txf texture operation
...
The src[2] value 0x1100 is set based on observed behavior of the blob driver,
though its exact meaning remains to be documented.
Passes all dEQP-GLES3.functional.shaders.texture_functions.texelfetch.*
tests on GC7000.
Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34685 >
2025-04-24 20:19:37 +02:00
eefe486533
etnaviv: nir: Legalize txf lod src
...
The LOD must be a float, unlike the GLSL function, which expects an integer.
Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com >
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34685 >
2025-04-24 20:19:37 +02:00
da90fca609
etnaviv: isa: Add txf instruction
...
This instruction is used to implement texelfetch.
Blob generates such txf's for
dEQP-GLES3.functional.shaders.texture_functions.texelfetch.+
Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34685 >
2025-04-24 20:19:37 +02:00
6325868bbe
svga: handle null target pointers in svga_set_stream_output_targets()
...
Fixes crash in Piglit arb_separate_shader_object-xfb-explicit-location-array
test.
Signed-off-by: Brian Paul <brian.paul@broadcom.com >
Reviewed-by: Roland Scheidegger <roland.scheidegger@broadcom.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34635 >
2025-04-24 17:03:30 +00:00
65411350ac
aco/insert_exec: disable empty quads when leaving divergent control, even if not top level
...
We don't restore exec after uniform top level branches, so nothing disabled
empty quads after a demote in divergent control flow in a uniform branch.
Foz-DB Navi31:
Totals from 17 (0.02% of 79789) affected shaders:
Instrs: 34573 -> 34572 (-0.00%)
CodeSize: 186876 -> 186872 (-0.00%)
Latency: 324145 -> 324141 (-0.00%)
Copies: 1467 -> 1458 (-0.61%)
PreSGPRs: 802 -> 800 (-0.25%)
SALU: 2531 -> 2530 (-0.04%)
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34670 >
2025-04-24 15:43:09 +00:00
3ad385b9cc
radv: Clear dirty flag for clip rects state after emitting it.
...
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com >
Tested-by: Marcus Seyfarth <m.seyfarth@gmail.com >
Fixes: 0ba3a8b3cchttps://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34686 >
2025-04-24 15:13:44 +00:00
3a05477ac6
radv: Clear dirty flag for MSAA state after emitting it.
...
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com >
Tested-by: Marcus Seyfarth <m.seyfarth@gmail.com >
Fixes: 08918f0880https://gitlab.freedesktop.org/mesa/mesa/-/issues/13022
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34686 >
2025-04-24 15:13:44 +00:00
e60416b4e4
anv: use companion batch for operations with HIZ/STC_CCS destination
...
We're currently crashing a couple of tests :
dEQP-VK.pipeline.monolithic.depth.xfer_queue_layout.*
deqp-vk: ../src/intel/blorp/blorp_blit.c:2935:
blorp_copy: Assertion `blorp_copy_supports_blitter(batch->blorp, src_surf->surf, dst_surf->surf, src_surf->aux_usage, dst_surf->aux_usage)' failed.
Tested on:
dEQP-VK.api.copy_and_blit.copy_commands2.image_to_image_transfer_queue.all_formats.depth_stencil.*
dEQP-VK.api.copy_and_blit.multiplanar_xfer.*
dEQP-VK.pipeline.monolithic.depth.xfer_queue_layout.*
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Fixes: 31eeb72e45nanley.g.chery@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34023 >
2025-04-24 14:47:40 +00:00
3aec638a8b
rusticl: remove unnecessary check for device in kernel list
...
There is no need to verify that `kernel.prog.devs` contains a device
when that device ref was pulled from `kernel.prog.devs` immediately
beforehand.
Reviewed-by: Karol Herbst <kherbst@redhat.com >
Reviewed-by: @LingMan
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34167 >
2025-04-24 14:23:05 +00:00
4be2a49e02
rusticl: improve use of Rust idioms
...
Reduce unnecessary function calls, collect from iterators instead of
adding to mutable collections, and remove unnecessary trait bounds.
v2: split change to associated device check into new commit
Reviewed-by: Karol Herbst <kherbst@redhat.com >
Reviewed-by: @LingMan
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34167 >
2025-04-24 14:23:05 +00:00
2c202eb787
rusticl: verify validity of property names and values
...
v2: separate from using type aliases based on signature and reorder
v3: verify validity in two additional locations
Reviewed-by: Karol Herbst <kherbst@redhat.com >
Reviewed-by: @LingMan
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34167 >
2025-04-24 14:23:05 +00:00
62d8541f39
rusticl: improve internal typing
...
Shuffle some integer types to reduce the necessity of casting.
Additionally, clean up some unnecessary use of `Vec` to avoid
allocations.
v2: revert changes to `PipeContext` to avoid hiding truncation errors,
move change to fallible conversions to separate patch
Reviewed-by: Karol Herbst <kherbst@redhat.com >
Reviewed-by: @LingMan
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34167 >
2025-04-24 14:23:05 +00:00
ec314aa358
rusticl: align memory utilities with std
...
Rename `is_alligned()` util to match std naming and move it alongside
similar utilities which copy upstream functionality and annotate those
utilities with their first stable version where applicable.
Replace use of `mesa_rust_util::offset_of!()` in one case where nested
field support is not needed.
v2: revert removal of `offset_of!()` for nested field support
Reviewed-by: Karol Herbst <kherbst@redhat.com >
Reviewed-by: @LingMan
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34167 >
2025-04-24 14:23:05 +00:00
26867670b2
rusticl/device: set maximum work dimension to match implicit bounds
...
Much of the kernel code implicitly depends on a maximum work dimension
of 3, and in practice, gallium will never give a grid dimension of less
than 3, constraining the value to a constant.
v2: use a const for max dimension instead of a `min` call
Reviewed-by: Karol Herbst <kherbst@redhat.com >
Reviewed-by: @LingMan
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34167 >
2025-04-24 14:23:05 +00:00
845611bb43
panvk: Take resource index in valhall_lower_get_ssbo_size
...
Previously we were not extracting the resource index from the resource
handle.
This fixes failures with PanVK+ANGLE on "dEQP-GLES31.functional.ssbo.array_length.unsized_*".
Fixes: e4613f8b23mary.guillemard@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34697 >
2025-04-24 13:28:53 +00:00
7ec937b81e
v3d/vc4/ci: Add -gl suffix to the GL suite names
...
As we have a -vk suffix for the Vulkan-related suites, add a -gl one for
the OpenGL/ES related suites.
Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com >
Reviewed-by: Eric Engestrom <eric@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34680 >
2025-04-24 12:40:38 +00:00
9ab13e1ed0
v3d/vc4/ci: update fraction and parallel values
...
The aim is to increase the coverage as maximum as possible while using
the less possible DuTs, everything under a testing budget of 10 minutes.
Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com >
Reviewed-by: Eric Engestrom <eric@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34680 >
2025-04-24 12:40:38 +00:00
8dd578e2a4
panvk: Enable VK_EXT_direct_mode_display
...
Panvk already enables VK_EXT_acquire_xlib_display, but not
VK_EXT_direct_mode_display which is a dependency. This causes a failure
in dEQP-VK.info.instance_extensions.
Fixes: 8c2bfa279derik.faye-lund@collabora.com >
Acked-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34672 >
2025-04-24 12:11:32 +00:00
419a9e9d42
mesa-clc: add an option to force inclusion of OpenCL headers
...
Currently mesa-clc bundles OpenCL headers from Clang only if the static
LLVM is used (which means Clang / LLVM are not present on the target
system). In some cases (e.g. when building in OpenEmbedded environemnt)
it is desirable to have shared LLVM library, but skip installing the
whole Clang runtime just to compile shaders. Add an option that forces
OpenCL headers to be bundled with the mesa-clc binary.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34551 >
2025-04-24 11:40:15 +00:00
680752d97f
ci: Use hyphens in make-git-archive job name
...
Spaces in job names make me uncomfortable.
Signed-off-by: Valentine Burley <valentine.burley@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34689 >
2025-04-24 11:05:23 +00:00
b758e49085
ci: Update ci-fairy to use shared ref from ci-templates
...
The /templates/ci-fairy.yml include was pinned to an old revision of
ci-templates that wasn't able to upload to S3 with s3cp following the
infrastructure transition.
Signed-off-by: Valentine Burley <valentine.burley@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34689 >
2025-04-24 11:05:23 +00:00
bf4fa82af9
ci: use curl instead of wget in download-git-cache.sh
...
Note that this code is executed on the generic FDo gitlab runners, not
in our docker images. This change is merely to avoid the confusion that
lead to the code in the previous commit.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34684 >
2025-04-24 10:36:00 +00:00
74809ce0e3
ci: drop dead wgetrc as there are no uses of wget in our CI images
...
Note that if you grep, you'll find two instances of `wget`, but those are not
executed in our docker images, but on the generic FDo gitlab runners, so the
/etc/wgetrc file in our docker images cannot affect them.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34684 >
2025-04-24 10:36:00 +00:00
006f5c20bd
panfrost: Allow max effective tile size of 64x64 on v12+
...
This is supported since v12 and we fixed the last remaining issues
related to it.
Signed-off-by: Mary Guillemard <mary.guillemard@collabora.com >
Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34674 >
2025-04-24 10:11:22 +00:00
943a59c8f9
panvk: Emit sample count and tile size when emitting framebuffer/tiler descriptors
...
This move the logic around tile size budget to be able to handle
rasterization_samples properly in case no render target is defined.
We now select the tile size right before emitting the tiler and framebuffer
descriptors.
This fixes "dEQP-VK.pipeline.monolithic.multisample.mixed_count.*" on
v12 when 64x64 tile size is allowed.
Signed-off-by: Mary Guillemard <mary.guillemard@collabora.com >
Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34674 >
2025-04-24 10:11:21 +00:00
c7f2bc6bed
panvk: Take rasterization sample into account in indirect draw on v10+
...
This has been an oversight when implementing indirect draw.
Fixes: 1f3b8bb918mary.guillemard@collabora.com >
Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34674 >
2025-04-24 10:11:21 +00:00
765801fd9e
intel/dev: add note about PAT entries and Wa_18038669374
...
Signed-off-by: Tapani Pälli <tapani.palli@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34665 >
2025-04-24 09:48:34 +00:00
a0407a6ecf
ci/vkd3d: fail shell pipeline when part of it fails
...
We use pipes in several places and don't want to ignore their failures.
A couple of exceptions are allowed with explicit `|| true`.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34639 >
2025-04-24 09:00:37 +00:00
104f21c27b
ci/vkd3d: treat reading undefined variables as an error
...
This would've prevented the bug in the previous commit.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34639 >
2025-04-24 09:00:37 +00:00
89d4ddce0e
ci/vkd3d: fix RESULTS_DIR variable name
...
The bug in the previous commit was hiding this bug...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34639 >
2025-04-24 09:00:37 +00:00
3c0d414cbf
ci/vkd3d: only keep logs of failed tests
...
This is what I meant to do from the start but messed up.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34639 >
2025-04-24 09:00:36 +00:00
7f0fe34758
ci/vkd3d: quieten the mesa version check
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34639 >
2025-04-24 09:00:36 +00:00
0f8fd5da7a
ci/vkd3d: fix test failure list when no test failed
...
This becomes important once the bugfix in the next commit is applied.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34639 >
2025-04-24 09:00:36 +00:00
d21e300f33
ci/vkd3d: drop misguided "something failed" error message
...
Luckily the check was broken, but let's not fix it because this would
cause any failure to fail the job, regardless of expectations.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34639 >
2025-04-24 09:00:36 +00:00
Eric Engestrom