Eric Engestrom
b9cdcd2cbe
ci/android: move virgl-specific fails/flakes/skips lists to virgl-defined variables
...
Signed-off-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: Helen Koike <helen.koike@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21157 >
2023-02-07 16:28:35 +00:00
Eric Engestrom
515ea48523
ci/android: move virgl-specific gpu_mode to virgl-defined variables
...
Signed-off-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: Helen Koike <helen.koike@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21157 >
2023-02-07 16:28:35 +00:00
Eric Engestrom
eb0f85dd8c
ci/android: move common config to common job
...
Signed-off-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: Helen Koike <helen.koike@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21157 >
2023-02-07 16:28:35 +00:00
José Roberto de Souza
eb9ab4efeb
intel/genxml/gen125: Tune 3DSTATE_WM Walker direction
...
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21105 >
2023-02-07 07:34:44 -08:00
José Roberto de Souza
bea93f7058
intel/genxml/gen125: Add walker configuration fields to 3DSTATE_WM
...
Setting default expected values as default in the xml.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21105 >
2023-02-07 07:34:35 -08:00
Rhys Perry
fad1f716dd
aco: fix out-of-bounds access when moving s_mem(real)time across SMEM
...
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com >
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8224
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21138 >
2023-02-07 14:50:43 +00:00
Mike Blumenkrantz
7d8e2db9f9
lavapipe: disable VK_FORMAT_FEATURE_2_COLOR_ATTACHMENT_BLEND_BIT for int formats
...
this is unsupported and undefined by the spec
cc: mesa-stable
Reviewed-by: Roland Scheidegger <sroland@vmware.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21099 >
2023-02-07 14:23:01 +00:00
Iago Toral Quiroga
fec15a225f
v3dv: ensure we apply binning syncs to secondary command buffers
...
Currently, we postpone binning syncs until we record draw calls
and can validate if any of them require accessing protected
resources in the binning stage, however, if the draw calls are
recorded in a secondary command buffer and the barriers have
been recorded in the primary command buffer, we won't apply the
binning sync in the secondary when we record the draw calls
and so we must apply it when we execute the secondary in the
primary.
Fixes flakyness in:
dEQP-VK.api.command_buffers.record_many_draws_secondary_2
cc: mesa-stable
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21162 >
2023-02-07 14:07:19 +01:00
Iago Toral Quiroga
c2601f0690
v3dv: ensure at least V3D_CL_MAX_INSTR_SIZE bytes in last CL instruction
...
The CLE parser in the sim will read this many bytes for each instruction
in a CL, so we should ensure we have at least that many bytes available
in the BO when reading the last instruction, otherwise we can trigger
a GMP violation. It is not clear whether this behavior applies to real
hardware too.
cc: mesa-stable
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21162 >
2023-02-07 14:06:57 +01:00
Frank Binns
079247e046
pvr: remove start/stop transfer flags
...
These are ignored by the pvrsrvkm KMD and don't exist in the new KMD.
Signed-off-by: Frank Binns <frank.binns@imgtec.com >
Reviewed-by: Luigi santivetti <luigi.santivetti@imgtec.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21132 >
2023-02-07 10:34:05 +00:00
pal1000
4347072443
meson: Ignore unused variables when assertions are disabled
...
Fixes: 46b099e3
("meson: Ignore unused variables in release builds")
46b099e3 has some issues:
- it doesn't enable unused variables warning on release builds
with assertions enabled;
- it doesn't disable unused variables warning on debug builds
with assertions disabled;
- it doesn't disable unused variables warning when building
with MSVC and assertions are disabled regardless of buildtype,
see #8147 . 3/4 regressions reported there have this limitation
alone as root cause.
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21154 >
2023-02-07 08:44:14 +00:00
Qiang Yu
4888dd7391
radv: use amd common force_vrs option
...
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Signed-off-by: Qiang Yu <yuq825@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21010 >
2023-02-07 08:09:39 +00:00
Qiang Yu
1e3198c766
radv: move radv_consider_force_vrs above radv_fill_shader_info
...
It will be used by radv_fill_shader_info, no function change.
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Signed-off-by: Qiang Yu <yuq825@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21010 >
2023-02-07 08:09:39 +00:00
Lionel Landwerlin
bee8e47048
anv: use malloc for host only descriptor sets
...
On integrated products this makes almost no difference but on discrete
it's pretty important.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Ivan Briano <ivan.briano@intel.com >
Tested-by: Chuansheng Liu <chuansheng.liu@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21131 >
2023-02-07 07:28:32 +00:00
Dave Airlie
3e2c768aa8
radv/vcn: enable dynamic dpb tier 2 for h264/h265 on navi21+
...
navi21 can do separate image support, using tier 2 DPB messages.
This enables support for doing that in the vulkan video driver.
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20388 >
2023-02-07 12:48:28 +10:00
Dave Airlie
6c3c242361
radv/video: add h265 decode UVD support
...
Add support for h265 decode on older UVD GPUs
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20388 >
2023-02-07 12:48:26 +10:00
Dave Airlie
db62c38091
radv: add vcn h265 decode.
...
This adds support for HEVC decode in VCN
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20388 >
2023-02-07 12:48:24 +10:00
Dave Airlie
8a29291dbe
radv/video: add h264 support for uvd
...
This adds support for the older UVD h264 decoder.
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20388 >
2023-02-07 12:48:22 +10:00
Dave Airlie
1693c03a39
radv/video: add initial h264 decoder for VCN
...
This adds support for H264 decode on VCN hardware.
It uses the full DPB method, and relies on the application
to allocate an arrayed texture for the DPB to be stored into.
RADV_PERFTEST=video_decode is required to enable this.
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20388 >
2023-02-07 12:47:53 +10:00
Dave Airlie
9477f117f4
radv/video: add initial frameworking.
...
This just adds the basic commands and objects, and hooks up some
of the queues and extensions.
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20388 >
2023-02-07 12:47:50 +10:00
Dave Airlie
3253340916
radv: add video decoder register setup.
...
This just assigns the correct registers depending on the gpu family.
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20388 >
2023-02-07 12:47:48 +10:00
Dave Airlie
85eead4198
radv: adding video decode queue support
...
This adds the video queue interactions to radv and builds
on the winsys code previously added.
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20388 >
2023-02-07 12:47:46 +10:00
Dave Airlie
30b6e9797d
ac: add name to codec info struct
...
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20388 >
2023-02-07 12:47:43 +10:00
Dave Airlie
ee7837aae2
radv: add new upload alloc aligned api
...
The video buffers need to have objects aligned at certain ranges,
this enhances the uploader to allow an alignment to be specified.
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20388 >
2023-02-07 12:47:39 +10:00
Dave Airlie
855ad612e1
radv: remove the status query mark it unsupported.
...
The current firmware can't support the status query requirements.
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20388 >
2023-02-07 12:47:25 +10:00
Rob Clark
284547af55
freedreno+ir3: Move storage_16bit to compiler options
...
This isn't a thing in gl.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21152 >
2023-02-07 01:26:45 +00:00
Kenneth Graunke
79caf8a44b
anv: Make a batch decoder for each queue family
...
The decoder context needs to know what engine it's associated with.
Nowadays, we have render, compute, blitter, even video engines being
used from the same driver. Rather than trying to have a single decoder
and thwacking the engine field back and forth between calls, we make
one per queue family, and stash a pointer in anv_queue for easy access.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21149 >
2023-02-06 23:21:55 +00:00
Alejandro Piñeiro
1a1fa2393e
v3d/v3dv: use shader_info->var_copies_lowered
...
Instead of passing allow_copies as a parameter for v3d_optimize_nir
(so manually doing that tracking).
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19338 >
2023-02-06 22:11:34 +00:00
Alejandro Piñeiro
ba0bc7182d
anv: use shader_info->var_copies_lowered
...
Instead of passing allow_copies as a parameter for brw_nir_optimize
(so manually doing that tracking).
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19338 >
2023-02-06 22:11:34 +00:00
Alejandro Piñeiro
a12a71e6c0
radv: use shader_info->var_copies_lowered
...
Instead of passing allow_copies as a parameter for radv_optimize_nir
(so manually doing that tracking).
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19338 >
2023-02-06 22:11:34 +00:00
Alejandro Piñeiro
3685528c1e
nir: track if var copies lowering was called
...
In general we should only call it once, and then we should avoid to
call any lowering that introduce back copies. So far we were tracking
that manually out of the nir shader on several places.
Ideally we would like to add a nir_validate rule, but right now there
are some exceptions to this rule. For example right now the Intel
compiler calls nir_lower_io_to_temporaries as part of linking
tess_ctrl/mesh/task sahders.
One option would be to allow drivers to reset the value, but for now
let's not add that validation rule.
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19338 >
2023-02-06 22:11:34 +00:00
Yuxuan Shui
27a89a0903
loader: unregister special event in loader_dri3_drawable_fini
...
This was inadvertently removed in 98a6cfd3953 and causes continuous
memory leaks as events are being received after the context has been
unbound.
Fixes: 3170b63314 ("loader: Add infrastructure for tracking active CRTC resources")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8238
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com >
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21128 >
2023-02-06 20:45:32 +00:00
Pavel Ondračka
f56f277ba0
r300: set register file to none if swizzles are constant only
...
In constant folding when converting multiply by zero to mov.
Signed-off-by: Pavel Ondračka <pavel.ondracka@gmail.com >
Reviewed-by: Filip Gawin <filip@gawin.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21141 >
2023-02-06 20:31:56 +00:00
Kai Wasserbäch
1d5d07e565
fix: gallivm: limit usage of LLVMContextSetOpaquePointers() to LLVM 15
...
LLVMContextSetOpaquePointers() was a temporary workaround offered to
allow transitioning to opaque pointers. Mesa is ready for this now with
recent versions of LLVM (16+). Therefore we limit the workaround of
using LLVMContextSetOpaquePointers() to LLVM 15 now, that this C
interface was removed in LLVM 17.
Reference: https://github.com/llvm/llvm-project/commit/1270879376025457e266572c7cccc51eb5de9276
Suggested-by: Dave Airlie <airlied@redhat.com >
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8183
Reviewed-by: Roland Scheidegger <sroland@vmware.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21124 >
2023-02-06 19:50:35 +00:00
Konstantin Seurer
569517d7ad
radv: Use common ycbcr conversion lowering
...
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20731 >
2023-02-06 18:36:29 +00:00
Konstantin Seurer
9104dafb6f
vulkan,nir: Refactor ycbcr conversion state into a struct
...
This will be useful for RADV since it hashes the state.
v3dv changes:
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20731 >
2023-02-06 18:36:29 +00:00
Konstantin Seurer
dae893cb96
radv: Remove radv_indirect_unaligned_dispatch
...
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21071 >
2023-02-06 17:50:53 +00:00
Konstantin Seurer
b9d7306edc
radv: Use an ordered dispatch for BVH encoding
...
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21071 >
2023-02-06 17:50:53 +00:00
Konstantin Seurer
22a028ea99
radv: Implement ordered compute dispatches
...
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21071 >
2023-02-06 17:50:53 +00:00
Konstantin Seurer
77b0a4c025
radv: Make radv_compute_dispatch non-static
...
To avoid adding yet another radv_*_dispatch helper.
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21071 >
2023-02-06 17:50:53 +00:00
Guilherme Gallo
26754f658e
Revert "ci: disable Collabora's LAVA lab for maintance"
...
This reverts commit 60d7e15a7e .
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20903 >
2023-02-06 17:22:11 +00:00
Guilherme Gallo
95b5cc3a53
radeonsi/ci: Skip slow traces on raven
...
Two traces timed out during Collabora's LAVA farm re-enablement.
Possibly, some commit made them slower during farm downtime.
- https://gitlab.freedesktop.org/mesa/mesa/-/jobs/35934124
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20903 >
2023-02-06 17:22:11 +00:00
Guilherme Gallo
53cc509288
radeonsi/ci: Update stoney test expectations
...
Some jobs failed during the re-enablement of Collabora's LAVA farm.
The trace job radeonsi-stoney-traces:amd64 produced some traces with
almost unnoticeable lighting spread difference, so I updated all the
traces.
Now the test spec@ext_texture_lod_bias@lodbias is failing after running
a couple of times.
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20903 >
2023-02-06 17:22:11 +00:00
Jonathan Gray
f15f08c3de
intel/dev: Add another EHL pci id
...
described as "32 Execution Unit (EU) Super SKU" in:
Intel Atom x6000E Series, and Intel Pentium and Celeron N and
J Series Processors for IoT Applications
Datasheet, Volume 1
Document Number: 636112-1.6
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: José Roberto de Souza <jose.souza@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21129 >
2023-02-06 16:48:39 +00:00
Jonathan Gray
a23e04b673
intel/dev: remove invalid EHL pci id
...
removed in linux
0e8e272f1368 ("drm/i915/ehl: Remove invalid PCI ID")
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: José Roberto de Souza <jose.souza@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21129 >
2023-02-06 16:48:39 +00:00
Mike Blumenkrantz
89cf0a3bdc
zink: fix max acquired image count
...
according to spec, the maximum number of acquired images can be calculated with
swapchain_size - VkSurfaceCapabilitiesKHR::minImageCount + 1
the previous calculation was both wrong and occurring in the wrong place,
so this corrects both issues
cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21095 >
2023-02-06 16:35:48 +00:00
SoroushIMG
22e91af1a7
zink: clear null image surfaces to 0
...
GL Spec says that imageLoad from incomplete images must return 0.
This is not really spec compliant as for proper behavior nullDescriptor
and robustImageAccess2 is needed.
A workaround for lack of either of these requires a shader variant.
Clearing the null surface and hoping the app doesn't write to the image
is closer to spec, while avoiding a shader recompile.
KHR-GL46.shader_image_load_store.incomplete_textures tests this.
cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21135 >
2023-02-06 15:55:57 +00:00
Samuel Pitoiset
2fe3cef367
radv: do not insert fast-linked libraries to the shaders cache
...
Similar to fast-linked pipelines that aren't added to the cache.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21133 >
2023-02-06 15:01:30 +00:00
SoroushIMG
104040b5c7
zink: fix leak when rebinding same image surface
...
simple way to reproduce this is to run these 4 together:
KHR-GL46.gpu_shader5.images_array_indexing
KHR-GL46.shader_image_load_store.advanced-allMips
KHR-GL46.shader_image_load_store.advanced-sso-simple
KHR-GL46.shader_image_load_store.incomplete_textures
cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21134 >
2023-02-06 14:47:47 +00:00
SoroushIMG
4c647c9e25
zink: only save frag const buffers when used by blit
...
fixes upload manager constant buffer leak.
zink only needs to save the const buffer for stencil fallback blits.
cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21134 >
2023-02-06 14:47:47 +00:00