Rhys Perry
b70ecfa588
aco: only join barrier_imm/barrier_events for logical edges
...
fossil-db (gfx1201):
Totals from 3 (0.00% of 79653) affected shaders:
Instrs: 2904 -> 2893 (-0.38%)
CodeSize: 14944 -> 14900 (-0.29%)
Latency: 14703 -> 14248 (-3.09%)
InvThroughput: 1237 -> 1210 (-2.18%)
fossil-db (navi31):
Totals from 3 (0.00% of 79653) affected shaders:
Instrs: 2742 -> 2731 (-0.40%)
CodeSize: 14136 -> 14092 (-0.31%)
Latency: 14744 -> 14287 (-3.10%)
InvThroughput: 1241 -> 1213 (-2.26%)
fossil-db (navi21):
Totals from 3 (0.00% of 79653) affected shaders:
Instrs: 2326 -> 2315 (-0.47%)
CodeSize: 12472 -> 12428 (-0.35%)
Latency: 14921 -> 14465 (-3.06%)
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34978 >
2025-06-06 11:51:08 +01:00
Rhys Perry
62a9b4b976
aco: set vmem_types for args_pending_vmem
...
fossil-db (gfx1201):
Totals from 0 (0.00% of 79653) affected shaders:
fossil-db (navi31):
Totals from 11 (0.01% of 79653) affected shaders:
Instrs: 4543 -> 4554 (+0.24%)
CodeSize: 23256 -> 23300 (+0.19%)
fossil-db (navi21):
Totals from 8 (0.01% of 79653) affected shaders:
Instrs: 2333 -> 2341 (+0.34%)
CodeSize: 12328 -> 12360 (+0.26%)
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Backport-to: 25.0
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34978 >
2025-06-06 11:51:08 +01:00
Erik Faye-Lund
fb0a422be2
panfrost: plug leak of modifier conversion shaders
...
We were allocating these, but never freeing the actual CSOs here.
Let's wire things up so we delete the data when we destroy the
hash-table. Because we don't have access to the context in that
callback, we can't call the pipe-level function to delete a CSO,
but luckily we don't actually need the context for the
driver-logic. So let's add an internal helper for that.
Fixes: ae3fb3089f ("panfrost: Add infrastructure for internal AFBC compute shaders")
Fixes: f39194cdd3 ("panfrost: support MTK 16L32S detiling")
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35336 >
2025-06-06 08:35:35 +00:00
Erik Faye-Lund
cc66651fc1
panfrost: do not double-insert shader into hash-table
...
We were inserting twice here, once without holding the lock before
compiling the shaders, and once after while holding it. Let's remove
the insert without the lock.
Fixes: ae3fb3089f ("panfrost: Add infrastructure for internal AFBC compute shaders")
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35336 >
2025-06-06 08:35:35 +00:00
Yiwei Zhang
69b458fdd7
panvk: fix imported external multi-planar image support
...
This change and the prior preparations have fixed the false assumption
of ordered image planes for external multi-planar image (YV12 has the
chroma planes swapped to map to the Vulkan format). We no longer need to
use plane data size to advance plane offset. The code paths for
subresource reporting, memroy reporting and memory binding are now
consistent across native disjoint/non-disjoint and imported external
images no matter single-planar or multi-planar.
Test:
- No regressions in dEQP-VK.ycbcr.*
- NV12 camera preview works on Android
- YV12 video playback works on Android
- Android graphics cts passing
- BasicVulkanGpuTest
- MediaVulkanGpuTest
- CameraVulkanGpuTest
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35299 >
2025-06-06 07:25:27 +00:00
Yiwei Zhang
a9006ebde0
pan/layout: document and prepare to fix planar plane offset
...
This change:
1. Rename pan_image_wsi_layout to pan_image_layout_constraints.
1. Document that pan_image_layout_constraints::offset_B will be used to
pass planar plane offset for native images as well. Update
array_stride_B to exclude such offset accordingly.
2. Document that whether explicit layout is used further depends on if
the passed wsi_row_pitch_B is non-zero or not. Updated the checks to
base on the new boolean use_explicit_layout.
3. Update and document the intended slice offset_B behavior so that
native and imported images are aligned.
No behavior change from this commit since the client (panvk) hasn't set
the pan_image_layout_constraints->offset_B for planar plane yet.
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35299 >
2025-06-06 07:25:27 +00:00
Yiwei Zhang
6690c74f6d
pan/layout: refactor wsi layout query
...
This change splits pan_image_layout_get_wsi_layout into separate queries
to prepare for making pan_image_wsi_layout an input layout constraint.
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35299 >
2025-06-06 07:25:27 +00:00
Yiwei Zhang
1d77569cbc
pan/layout: exclude plane offset from plane data size for import
...
This doesn't affect gallium side behavior since data_size_B is never
looked at for imported planar plane. For panvk, it doesn't affect
imported single planar image, and multi-planar side is still broken.
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35299 >
2025-06-06 07:25:26 +00:00
Yiwei Zhang
360c08a3dc
pan/layout: add const to immutable local vars in pan_image_layout_init
...
Putting compiler optimization aside, this at least improves readability
by making it clean which vars are mutable and which are immutable.
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35299 >
2025-06-06 07:25:26 +00:00
Caleb Callaway
a633d3f71f
docs: Add CPU frequency governor perf tip
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33744 >
2025-06-06 07:20:09 +00:00
Caleb Callaway
f64dbfd08a
anv: ANV_DEBUG_WAIT_FOR_ATTACH
...
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35324 >
2025-06-06 07:02:07 +00:00
Erik Faye-Lund
ad6e1afe74
panvk: add EXT_texture_compression_astc_hdr support
...
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34828 >
2025-06-06 06:40:59 +00:00
Erik Faye-Lund
a271b9a9a3
vulkan/format: map ASTC HDR formats
...
Because the ASTC HDR formats are extension formats, we need to convert
it manually in vk_format_to_pipe_format() instead of using the table.
Otherwise, the compiler tries to create a gigantic array and ends up
dying.
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34828 >
2025-06-06 06:40:59 +00:00
Dave Airlie
ade742db14
nvk/headers: sync up the latest blackwell compute class headers
...
These should unblock a few things.
Signed-off-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35378 >
2025-06-06 12:46:51 +10:00
Guilherme Gallo
83f80dc4aa
ci/lava: Update image tag to apply the changes
...
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35222 >
2025-06-05 22:32:37 +00:00
Guilherme Gallo
9024e0df83
ci/lava: Don't fail if the section times mismatches
...
Time drift can occur during LAVA job execution due to transitions
between three different clocks.
The process begins in the GitLab job [1], using the CI_JOB_STARTED_AT
variable. If SSH is enabled, we then connect to the DUT through an
Alpine-based SSH client container inside the LAVA dispatcher [2], where
some GitLab-related steps are timestamped by lava_job_submitter.
Finally, the DUT [3] runs and uses the setup-test-env.sh helper to
handle GitLab sections, potentially using a third distinct clock.
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35222 >
2025-06-05 22:32:37 +00:00
Guilherme Gallo
7322e44833
ci/lava: Style fixes in test_lava_log
...
Fix the formatting according flake8
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35222 >
2025-06-05 22:32:36 +00:00
Guilherme Gallo
19357b9a84
ci/lava: Fix type hint errors in GitlabSection
...
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35222 >
2025-06-05 22:32:36 +00:00
Wenfeng Gao
c4dd9027db
mediafoundation: enable new CODECAPI properties for frame stats
...
CODECAPI_AVEncVideoEnableFramePsnrYuv
CODECAPI_AVEncVideoEnableSpatialAdaptiveQuantization
CODECAPI_AVEncVideoOutputQPMapBlockSize
CODECAPI_AVEncVideoOutputBitsUsedMapBlockSize
Reviewed-By: Sil Vilerino <sivileri@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35264 >
2025-06-05 22:02:01 +00:00
Pohsiang (John) Hsu
9f22e3f98c
ci: build mediafoundation frontend in windows-msvc
...
Reviewed-by: Sil Vilerino <sivileri@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35264 >
2025-06-05 22:02:01 +00:00
Sil Vilerino
38d2133e3e
ci: Add Windows SDK 26100 to msvc image
...
Keep older 10.0.20348.0 SDK as well. Also change:
mesa_deps_test_piglit - Add CMAKE_POLICY_VERSION_MINIMUM=3.5 and _UCRT_NOISY_NAN
mesa_deps_test_deqp - Add CMAKE_POLICY_VERSION_MINIMUM=3.5 and CMAKE_SYSTEM_VERSION=10.0.20348.0
meson: When building with MSVC, add -D_UCRT_NOISY_NAN to workaround Win SDK 26100
D_UCRT_NOISY_NAN is for SDK 26100 issue:
https://developercommunity.visualstudio.com/t/NAN-is-no-longer-compile-time-constant-i/10688907
Reviewed-by: Pohsiang Hsu <pohhsu@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35264 >
2025-06-05 22:02:01 +00:00
Wenfeng Gao
9b1c4f2e04
mediafoundation: Support new MFSampleExtension for PSNR, QPMap, and BitsUsedMap.
...
Added a helper function MFAttachPipeResourceAsSampleExtension that converts pipe_resource into D3D12 resource, attached as IMFMediaBuffer to IMFSample.
Conditionally applied MFAttachPipeResourceAsSampleExtension to:
MFSampleExtension_FramePsnrYuv
MFSampleExtension_VideoEncodeQPMap
MFSampleExtension_VideoEncodeBitsUsedMap
Reviewed-by: Yubo Xie <yuboxie@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35264 >
2025-06-05 22:02:01 +00:00
Pohsiang (John) Hsu
4df6954219
mediafoundation: Allow to build multiple codec MFT DLLs in one build pass
...
Reviewed-by: Sil Vilerino <sivileri@microsoft.com >
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/13235
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35264 >
2025-06-05 22:02:01 +00:00
Sil Vilerino
d9f0ddf336
mediafoundation: Request PSNR frame stats
...
Reviewed-by: Yubo Xie <yuboxie@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35264 >
2025-06-05 22:02:00 +00:00
Sil Vilerino
caa74854ec
mediafoundation: Implement full/lower resolution two pass
...
Reviewed-by: Yubo Xie <yuboxie@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35264 >
2025-06-05 22:02:00 +00:00
Wenfeng Gao
d7022698ff
mediafoundation: Added new CODECAPIs for GetValue and SetValue.
...
CODECAPI_AVEncVideoEnableFramePsnrYuv
CODECAPI_AVEncVideoEnableSpatialAdaptiveQuantization
CODECAPI_AVEncVideoOutputQPMapBlockSize
CODECAPI_AVEncVideoOutputBitsUsedMapBlockSize
Reviewed-by: Yubo Xie <yuboxie@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35264 >
2025-06-05 22:01:59 +00:00
Sil Vilerino
a81ffa7747
mediafoundation: Fill RefPicListL0/L1 sizes in pipe_h265_enc_picture_desc
...
Reviewed-by: Yubo Xie <yuboxie@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35264 >
2025-06-05 22:01:59 +00:00
Sil Vilerino
5e44557686
mediafoundation: Upgrade to use DirectX-Headers 717 SDK from previous 716 version
...
Reviewed-by: Yubo Xie <yuboxie@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35264 >
2025-06-05 22:01:58 +00:00
Connor Abbott
b6c1881d29
tu: Add perf debug for FDM being disabled
...
It's important to know when FDM is being disabled to a load/store of an
MSAA attachment as this is likely not what the user intended.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35373 >
2025-06-05 21:18:07 +00:00
Alyssa Rosenzweig
3c5c3d7819
hk: fix texture state count
...
default is 256 which is not what we want! perf issue maybe.
Backport-to: 25.1
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35189 >
2025-06-05 18:57:43 +00:00
Alyssa Rosenzweig
01c59030e8
hk: clarify A8_UNORM issue
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35189 >
2025-06-05 18:57:43 +00:00
Alyssa Rosenzweig
dffee5abc8
hk: enable another format
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35189 >
2025-06-05 18:57:43 +00:00
Alyssa Rosenzweig
df6c52ff2a
hk: enable ETC, ASTC
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35189 >
2025-06-05 18:57:42 +00:00
Alyssa Rosenzweig
a52c5fbc35
asahi: fix shader-db with fbfetch
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35189 >
2025-06-05 18:57:42 +00:00
Alyssa Rosenzweig
25d24b5a59
hk: clean out unused driconf
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35189 >
2025-06-05 18:57:42 +00:00
Alyssa Rosenzweig
870bde17d0
agx: drop encoding masks
...
unused and will now never be used, since we have the XML for this instead.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35189 >
2025-06-05 18:57:42 +00:00
Alyssa Rosenzweig
65a5ff67e9
agx: add XML-based disassembler
...
autogenerate a disassembler from the XML. also add a simple pure Python
reference disassembler, since autogenerated C code can be annoying to work with
in various contexts (we might drop this down the line, TBD if it's useful to
port over the current non-Mesa consumers of dougallj/applegpu). both
disassemblers produce identical output, unit tested via Meson.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35189 >
2025-06-05 18:57:42 +00:00
Alyssa Rosenzweig
53a2ada9d7
agx: add instruction encoding cases
...
for unit testing disassembly. this is the new syntax.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35189 >
2025-06-05 18:57:41 +00:00
Alyssa Rosenzweig
2dccbf8c7f
agx: add XML description of the AGX2 ISA
...
for our disassembler and later more stuff. should cover everything mesa uses,
not 100% complete to what applegpu has but mostly there.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35189 >
2025-06-05 18:57:41 +00:00
Alyssa Rosenzweig
c16bb0365a
agx: fix sample_mask packing overflow
...
identified with new disassembler. truncated immediate masks to 63
Backport-to: 25.1
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35189 >
2025-06-05 18:57:41 +00:00
Rohan Garg
248b8cb8c5
anv: drop anv_can_hiz_clear_ds_view in favor of anv_can_hiz_clear_image
...
Signed-off-by: Rohan Garg <rohan.garg@intel.com >
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34824 >
2025-06-05 20:27:33 +02:00
Rohan Garg
658b89ac86
anv: Support fast-clears in vkCmdClearDepthStencilImage
...
Signed-off-by: Rohan Garg <rohan.garg@intel.com >
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com >
Closes : #11897
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34824 >
2025-06-05 20:27:30 +02:00
Rohan Garg
db8b07f88d
anv: use the float qualifier to denote the right value
...
Signed-off-by: Rohan Garg <rohan.garg@intel.com >
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34824 >
2025-06-05 20:26:54 +02:00
Samuel Pitoiset
babeb975c4
radv,radeonsi: fix emitting UPDATE_DB_SUMMARIZER_TIMEOUT on GFX12
...
Not all PFP firmwares for GFX12 have this packet.
Fixes: 47f5d25f93 ("radv,radeonsi: emit UPDATE_DB_SUMMARIZER_TIMEOUT on GFX12")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/13312
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35370 >
2025-06-05 16:51:07 +00:00
David Rosca
c72987350b
radeonsi/vcn: Fix encoding multiple tiles with recent VCN4 firmwares
...
Cc: mesa-stable
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35369 >
2025-06-05 15:47:31 +00:00
Valentine Burley
02256a5aa3
ci/android: Close the Android tools section
...
This was missing.
Signed-off-by: Valentine Burley <valentine.burley@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35362 >
2025-06-05 15:18:23 +00:00
Valentine Burley
9a52a25a9e
ci: Allow ANGLE_TAG to be unset in -runner scripts
...
The android-runner scripts use `set -u`, which causes them to fail if
ANGLE_TAG is not defined. This issue went unnoticed because all current
Android jobs set ANGLE_TAG.
Update all -runner scripts to tolerate ANGLE_TAG being unset.
Signed-off-by: Valentine Burley <valentine.burley@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35362 >
2025-06-05 15:18:23 +00:00
Valentine Burley
c99c67c490
ci/android: Only replace ANGLE if needed
...
Only replace the stock ANGLE libraries if the job inherits .test-angle.
Signed-off-by: Valentine Burley <valentine.burley@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35362 >
2025-06-05 15:18:23 +00:00
Ashley Smith
95c508d950
panfrost: Fix shader_clock support for v6+
...
This code sets PANFROST_JD_REQ_CYCLE_COUNT when using LD_GCLK to enable
shader_clock
Fixes: c1ce2dcc ("pan/bi: Enable ARB_shader_clock extension support")
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Signed-off-by: Ashley Smith <ashley.smith@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35363 >
2025-06-05 14:57:20 +00:00
Christoph Pillmayer
6d4d42e328
panvk: Add support for 64bit conditionals in CSF
...
This will be used to implement timestamp queries for CSF GPUs.
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35368 >
2025-06-05 14:20:54 +00:00