Alyssa Rosenzweig
13ee87c8b9
pan/midgard: Document branch combination LUT
...
This took way longer to figure out than it should have..
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
2019-07-31 09:39:16 -07:00
Kenneth Graunke
2037478702
st/mesa: Skip scissor rect updates when scissor is entirely disabled.
...
If any scissor rectangles are enabled, then we need to set proper
scissor rectangles for all viewports. But if the scissor test is
entirely disabled, then we can skip updating any scissor rectangles.
Without this step, we were updating the scissor rectangles based on
the current framebuffer size. So if an app rendered to a variety of
render targets at different sizes, with scissor test disabled each
time, we'd still be continually updating the scissor rectangles,
even though it's not necessary.
In Civilization VI, this drops us from 310-350 set_scissor_state
calls per frame to 0, as it doesn't appear to use scissor testing.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
2019-07-31 08:33:50 -07:00
Emil Velikov
72b97ad9b2
egl/drm: ensure the backing gbm is set before using it
...
Currently, if we error out before gbm_dri is set (say due to a different
name of the backing GBM implementation, or otherwise) the tear down will
trigger a NULL ptr deref and crash out.
Move the gbm_dri initialization as early as possible.
v2: Drop check in dri2_teardowm_drm (Eric)
Reported-by: Christian Gmeiner <christian.gmeiner@gmail.com >
Cc: Christian Gmeiner <christian.gmeiner@gmail.com >
Cc: mesa-stable@lists.freedesktop.org
Signed-off-by: Emil Velikov <emil.velikov@collabora.com >
Reviewed-by: Eric Engestrom <eric.engestrom@intel.com >
2019-07-31 14:18:12 +01:00
Eric Engestrom
4bf7e7b170
docs: update required meson version
...
Fixes: f7b6a8d12f ("meson: bump required version to 0.46")
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com >
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com >
2019-07-31 11:50:39 +01:00
Samuel Pitoiset
c66021069e
radv/gfx10: implement a GE bug workaround
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2019-07-31 12:14:29 +02:00
Samuel Pitoiset
9a3fc7b6fa
radv/gfx10: remove an obsolete VGT_REUSE_OFF workaround
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2019-07-31 12:14:29 +02:00
Samuel Pitoiset
bb8f25233a
radv/gfx10: disable LATE_ALLOC_GS on Navi14
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2019-07-31 12:14:29 +02:00
Samuel Pitoiset
e041a74588
radv/gfx10: implement a bug workaround for GE_PC_ALLOC
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2019-07-31 12:14:29 +02:00
Samuel Pitoiset
0e1724af61
radv/gfx10: implement a bug workaround for NGG -> legacy transitions
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2019-07-31 12:14:29 +02:00
Samuel Pitoiset
29cca5f381
radv: skip draw calls with 0-sized index buffers
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2019-07-31 12:14:29 +02:00
Eric Engestrom
fed6aa2fec
autotools: delete leftover script wrapper
...
Randomly came across this file, which was likely only used by autotools
to pass arguments to the test.
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com >
Reviewed-by: Eric Anholt <eric@anholt.net >
2019-07-31 10:16:30 +01:00
Eric Engestrom
53b98b0185
virgl: make use of local variable
...
Otherwise that variable is only used in an assert() and would need an
ASSERTED to avoid the warning.
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
2019-07-31 09:41:05 +01:00
Eric Engestrom
20c89b060f
mesa: add an ASSERTED
...
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
2019-07-31 09:41:05 +01:00
Eric Engestrom
bbeb507543
compiler/nir: add an ASSERTED
...
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
2019-07-31 09:41:05 +01:00
Eric Engestrom
7e2fe85a40
intel: add a couple of ASSERTED
...
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
2019-07-31 09:41:05 +01:00
Eric Engestrom
abc226cf41
tree-wide: replace MAYBE_UNUSED with ASSERTED
...
Suggested-by: Jason Ekstrand <jason@jlekstrand.net >
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
2019-07-31 09:41:05 +01:00
Eric Engestrom
ab9c76769a
r600: replace MAYBE_UNUSED with specific #ifdef
...
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
2019-07-31 09:41:05 +01:00
Eric Engestrom
745bae40ad
gallium/aux: replace MAYBE_UNUSED with UNUSED
...
MAYBE_UNUSED is going away, so let's replace legitimate uses of it with
UNUSED, which the former aliased to so far anyway.
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
2019-07-31 09:41:05 +01:00
Eric Engestrom
513e67d2e4
mesa: replace MAYBE_UNUSED with UNUSED
...
MAYBE_UNUSED is going away, so let's replace legitimate uses of it with
UNUSED, which the former aliased to so far anyway.
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
2019-07-31 09:41:05 +01:00
Eric Engestrom
c8a453a770
v3d: replace MAYBE_UNUSED with UNUSED
...
MAYBE_UNUSED is going away, so let's replace legitimate uses of it with
UNUSED, which the former aliased to so far anyway.
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
2019-07-31 09:41:05 +01:00
Eric Engestrom
d470f1acce
v3d: drop incorrect MAYBE_UNUSED
...
While at it, use that `screen` variable everywhere.
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
2019-07-31 09:41:05 +01:00
Eric Engestrom
84b8a50540
st/tests: drop incorrect MAYBE_UNUSED
...
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
2019-07-31 09:41:05 +01:00
Eric Engestrom
aed15fa799
radv: drop incorrect MAYBE_UNUSED
...
`compressed` is clearly always used on the line right after.
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
2019-07-31 09:41:05 +01:00
Eric Engestrom
21196ec927
r600: move variable to proper scope
...
It helps show when it's actually used.
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
2019-07-31 09:41:05 +01:00
Eric Engestrom
5febd4d575
compiler: replace MAYBE_UNUSED with UNUSED
...
MAYBE_UNUSED is going away, so let's replace legitimate uses of it with
UNUSED, which the former aliased to so far anyway.
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
2019-07-31 09:41:05 +01:00
Eric Engestrom
bac5760e7b
mesa: drop MAYBE_UNUSED var
...
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
2019-07-31 09:41:05 +01:00
Eric Engestrom
e1dd6c2575
anv: drop MAYBE_UNUSED var
...
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
2019-07-31 09:41:05 +01:00
Eric Engestrom
644cca65d3
i965: drop unused MAYBE_UNUSED function
...
Added in 1b85c605a6 but never used.
Cc: Jordan Justen <jordan.l.justen@intel.com >
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
2019-07-31 09:41:05 +01:00
Eric Engestrom
7a3fb14609
i965: replace MAYBE_UNUSED with GEN condition
...
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
2019-07-31 09:41:05 +01:00
Eric Engestrom
eee70e09bf
intel: replace MAYBE_UNUSED with UNUSED
...
MAYBE_UNUSED is going away, so let's replace legitimate uses of it with
UNUSED, which the former aliased to so far anyway.
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
2019-07-31 09:41:05 +01:00
Eric Engestrom
e775b938b2
intel: drop incorrect MAYBE_UNUSED
...
All these are actually always used.
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
2019-07-31 09:41:05 +01:00
Eric Engestrom
14be04fb2b
egl: replace MAYBE_UNUSED with UNUSED
...
MAYBE_UNUSED is going away, so let's replace legitimate uses of it with
UNUSED, which the former aliased to so far anyway.
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
2019-07-31 09:41:05 +01:00
Samuel Pitoiset
ea38565011
radv/gfx10: add Wave32 support for compute shaders
...
It can be enabled with RADV_PERFTEST=cswave32.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2019-07-31 09:35:04 +02:00
Kenneth Graunke
3a22a8bf49
iris: Skip repeated depth buffer disables.
...
Often times, the depth buffer is entirely disabled, but color render
targets change. For example, GenerateMipmaps will change the color
render target for each miplevel, but there is no depth buffer.
In the Civilization VI benchmark, this drops the median number of
3DSTATE_DEPTH_BUFFER etc. packets emitted per frame from 472 to 34.
2019-07-30 19:47:41 -07:00
Marek Olšák
665989d98b
radeonsi: release NIR in the right place to fix crashes
2019-07-30 22:06:23 -04:00
Marek Olšák
9ac7d0a0e2
radeonsi: fix packing of key.mono.u.ps
2019-07-30 22:06:23 -04:00
Marek Olšák
033c39a660
ac/nir: fix incorrect Phis if callbacks use control flow inside control flow
2019-07-30 22:06:23 -04:00
Marek Olšák
d3c80733cd
ac/nir: handle abs modifier
2019-07-30 22:06:23 -04:00
Marek Olšák
efe2d8c5f9
ac: fix a memory leak in the error path of ac_build_type_name_for_intr
2019-07-30 22:06:23 -04:00
Marek Olšák
f6eca14f1b
ac: allow control flow statements in NIR callbacks
...
This fixes a crash when compiling geometry shaders on radeonsi.
2019-07-30 22:06:23 -04:00
Marek Olšák
bfea7e4d29
ac/nir: handle negate modifier
2019-07-30 22:06:23 -04:00
Marek Olšák
33a8eab7a9
radeonsi: don't use lp_build_if for the prim discard compute shader
2019-07-30 22:06:23 -04:00
Marek Olšák
5562b6b067
radeonsi: don't use lp_build_if for the wrapping if block in the VS prolog
2019-07-30 22:06:23 -04:00
Marek Olšák
0ef4c1c04d
radeonsi: don't use lp_build_if for the wrapping if block in merged shaders
2019-07-30 22:06:23 -04:00
Marek Olšák
6ec7d603f5
radeonsi: don't use lp_build_if (in most common places)
2019-07-30 22:06:23 -04:00
Marek Olšák
3406a57ff3
radeonsi: don't use lp_build_alloca
2019-07-30 22:06:23 -04:00
Marek Olšák
9234275320
radeonsi/nir: implement FBFETCH for KHR_blend_equation_advanced
2019-07-30 22:06:23 -04:00
Marek Olšák
925161c84c
radeonsi/nir: set input_interpolate_loc for color inputs
...
Reviewed-by: Connor Abbott <cwabbott0@gmail.com >
2019-07-30 22:06:23 -04:00
Marek Olšák
5787bbf90d
radeonsi/nir: set tgsi_shader_info::num_memory_instructions
2019-07-30 22:06:23 -04:00
Marek Olšák
0993dbcbef
radeonsi/nir: accurately set input_usage_mask for doubles (v2)
...
v2: fix doubles
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com >
2019-07-30 22:06:23 -04:00