AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
190,341 Commits 1 Branch 0 Tags
b0c0cca3a7daa4b827d4e074bc503ce44bd8a81b
Commit Graph

190341 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Marek Olšák b0c0cca3a7 radeonsi: switch the old compute image copy to the new one using the blit 
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28917>
 2024-06-08 05:48:10 +00:00
Marek Olšák f3a59fe216 radeonsi: add a new version of si_compute_copy_image using the compute blit 
It's faster and handles more stuff.

This is mostly the same code as the old version, but it calls
si_compute_blit at the end.

A later commit will remove the old version, so that there is no code
duplication.

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28917>
 2024-06-08 05:48:10 +00:00
Marek Olšák b7389615c6 radeonsi: rename si_compute_copy_image -> si_compute_copy_image_old 
It will be replaced in several stages.

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28917>
 2024-06-08 05:48:10 +00:00
Marek Olšák 8b030ac588 radeonsi: rename si_compute_blit "testing" parameter to "fail_if_slow" 
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28917>
 2024-06-08 05:48:10 +00:00
Marek Olšák a4602395d2 radeonsi: switch compute image clears to the compute blit shader 
The compute blit shader is faster and handles more stuff.
This removes the old clear_render_target shader.

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28917>
 2024-06-08 05:48:10 +00:00
Marek Olšák 9915289bdf radeonsi: extend the compute blit to do image clears as well 
The compute blit is faster and handles more stuff than
the clear_render_target shader. We can just pass a clear value to it
to replace the source image.

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28917>
 2024-06-08 05:48:10 +00:00
Marek Olšák e41887c6a4 radeonsi: cosmetic and robustness changes for the compute blit 
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28917>
 2024-06-08 05:48:10 +00:00
Marek Olšák 0c5d727a5e radeonsi: document better how X/Y flipping in the compute blit works 
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28917>
 2024-06-08 05:48:10 +00:00
Marek Olšák bb86366fee radeonsi/gfx11: enable MSAA image stores in the compute blit 
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28917>
 2024-06-08 05:48:10 +00:00
Marek Olšák 5897dde3f7 radeonsi: don't fail due to DCC when using the compute blit on compute queues 
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28917>
 2024-06-08 05:48:10 +00:00
Marek Olšák fcd9f0069f radeonsi: don't use si_can_use_compute_blit in the compute blit 
It makes supporting compute queues on all chips more complicated.
Other uses of si_can_use_compute_blit will be removed, so the function
will be removed too.

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28917>
 2024-06-08 05:48:10 +00:00
Marek Olšák 1b924bad5e radeonsi: reject unsupported parameters as the first thing in the compute blit 
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28917>
 2024-06-08 05:48:10 +00:00
Marek Olšák 993c30af06 radeonsi: fix sample0_only for the compute blit 
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28917>
 2024-06-08 05:48:10 +00:00
Marek Olšák 0ca93e8090 radeonsi: optimize unaligned compute blits 
If a blit starts on a coordinate that is not at the beginning of a tile
(e.g. 8x8), launch extra threads before 0,0,0 to make all following blocks
start at the beginning of such tiles. This makes such blits faster.

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28917>
 2024-06-08 05:48:10 +00:00
Marek Olšák 2423c5ad2f radeonsi: use MIMG D16 (16-bit data) for image instructions in compute blits 
This reduces VGPR usage.

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28917>
 2024-06-08 05:48:10 +00:00
Marek Olšák d3638a9f58 radeonsi: remove fp16_rtz from the compute blit 
it's not useful to have precisely the same behavior as u_blitter,
and D16 image stores are not supported by gfx6-7.

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28917>
 2024-06-08 05:48:10 +00:00
Marek Olšák 78ab033ae8 radeonsi: ignore PIPE_SWIZZLE_1 for 40% VGPR usage reduction for compute blits 
It had no effect on correctness and it was very inefficient because all
formats without alpha have SWIZZLE_1 in the last channel.
util_format_get_last_component is the same, but ignores PIPE_SWIZZLE_1.

It improves MSAA compute blit performance.

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28917>
 2024-06-08 05:48:10 +00:00
Marek Olšák 144fe156ef radeonsi: use better workgroup sizes for compute blits to improve perf 
It depends on the copy area and the tiling of the destination image.

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28917>
 2024-06-08 05:48:10 +00:00
Marek Olšák 269ab6cc62 radeonsi: don't declare 3D coordinates in the compute blit if they aren't needed 
This eliminates the 3rd coordinate VGPR.

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28917>
 2024-06-08 05:48:10 +00:00
Marek Olšák 07fa635f11 gallium/u_blitter: add option to override fragment shader for util_blitter_blit 
radeonsi will use a custom MSAA resolving shader

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28917>
 2024-06-08 05:48:10 +00:00
Marek Olšák 9ab9644c1f radeonsi/gfx12: fix stencil corruption 
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Tested-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29564>
 2024-06-08 00:11:28 -04:00
Marek Olšák 1b9ce2625f ac/nir/lower_ngg: don't use gfx12 xfb defs outside their basic block on gfx11 
Move the defs after nir_pop_if and phis and inside the gfx12 branch.

Fixes: 1ea96a47cd - ac/nir/lower_ngg: use voffset in global_atomic_add for xfb

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29564>
 2024-06-08 00:11:18 -04:00
Marek Olšák ea99c3fcb9 amd: update addrlib 
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29564>
 2024-06-08 00:11:17 -04:00
Marek Olšák 2ea3cb054b ac/surface: pass the correct addrlib handle to Addr3GetPossibleSwizzleModes 
Fixes: d22564d29c - ac/surface: add gfx12

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29564>
 2024-06-08 00:11:15 -04:00
Guilherme Gallo 41dd1c52b1 ci/lava: Fix cmdline for UART/fastboot devices 
Fastboot devices need an indirection for creating a boot image via
`mkbootimg`, so we need to propagate the cmdline from LAVA and our extra
arguments to it properly.

This commit fixes it by retrieving the default cmdline from LAVA and
sending it, together with the `extra_nfsroot_args` to the `mkbootimg`
command.

Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29611>
 2024-06-07 22:03:22 +00:00
Roland Scheidegger eead805919 lavapipe: add option to enable snorm blending 
This is disabled by default because it fails CTS, however this may
still be useful (as it generally works), hence use LVP_SNORM_BLEND
env var to enable it.

Acked-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Brian Paul <brian.paul@broadcom.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29587>
 2024-06-07 21:33:12 +00:00
Jianxun Zhang 9654aa4c31 intel/isl: Allow multi-sample on depth aux usage (xe2) 
The restriction on depth aux mode is gone on Xe2 in spec.

Fix: piglit
arb_post_depth_coverage-multisampling -auto -fbo
isl_surface_state.c:723: isl_gfx20_surf_fill_state_s:
Assertion `info->surf->samples == 1' failed.

Signed-off-by: Jianxun Zhang <jianxun.zhang@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29274>
 2024-06-07 21:06:37 +00:00
Eric Engestrom bd6ace73f3 radv/ci: document navi31 regression from !29235 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29596>
 2024-06-07 20:57:01 +00:00
Eric Engestrom 89666be1b9 nvk+zink/ci: add another flake seen in nightly 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29601>
 2024-06-07 20:47:01 +00:00
Eric Engestrom 46247b3827 v3d/drm-shim: emulate a rpi4 instead of a rpi3 
7278 is the chip on the rpi3, while the rpi4 that made it to market has
the 2711 chip.

When this was introduced (82bf1979), the rpi4 was probably still in
flux, which is why the rpi3 chip was put there (and v3d doesn't care
about that, but v3dv does).

cc: mesa-stable

Reviewed-by: Juan A. Suarez <jasuarez@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29584>
 2024-06-07 20:28:44 +00:00
Mike Blumenkrantz 2a90e16709 zink: add HKP to tiler mode switch 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29609>
 2024-06-07 20:02:19 +00:00
Mike Blumenkrantz 9a28f69ee7 vulkan: Update XML and headers to 1.3.287 
Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29610>
 2024-06-07 19:06:46 +00:00
Craig Stout d0b3b2eb54 util: os_time: add Fuchsia support 
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29539>
 2024-06-07 18:29:20 +00:00
C Stout d39faf7f3d util: u_dl: add Fuchsia support 
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Eric Engestrom <eric@igalia.com>
Acked-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29539>
 2024-06-07 18:29:20 +00:00
C Stout 2a3f53bd3b util: os_misc: add Fuchsia support 
v2: cleaner detect os check (robclark@)

Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Eric Engestrom <eric@igalia.com>
Acked-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29539>
 2024-06-07 18:29:20 +00:00
C Stout d6096ce8c8 util: u_thread: add Fuchsia support 
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Eric Engestrom <eric@igalia.com>
Acked-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29539>
 2024-06-07 18:29:20 +00:00
C Stout ebe4a8d75f util: detect_os: add DETECT_OS_FUCHSIA and DETECT_OS_POSIX_LITE 
Fuchsia is a microkernel-like OS.  It strategically implements
some POSIX and Unix APIs to promote software re-use.

It considers itself POSIX lite.

"In order to reduce the amount of source modification needed to
run on Fuchsia, Fuchsia offers a POSIX compatibility layer, POSIX
Lite, that this software can target. POSIX Lite is layered on
top of the underlying Fuchsia System ABI as a client library.

However, POSIX Lite is not a complete implementation of POSIX."

In the case of Fuchsia + src/util, these heavy-weight POSIX
functions shouldn't be used:

- file descriptors
- syslog.h
- signals
- process creation

To differentiate POSIX Lite, which Fuchsia and all heavy-weight
POSIX implementations support, add DETECT_OS_POSIX_LITE.

The use case is incrementally upstreaming functionality used in
downstream drivers (lavapipe, ..). Being in-tree for obvious
patches helps until the full driver can be merged.

Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Eric Engestrom <eric@igalia.com>
Acked-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29539>
 2024-06-07 18:29:20 +00:00
Mike Blumenkrantz 9cdbb099ee gallium: stop dropping drawid_offset param with util_draw_indirect 
this breaks indirect draws with offsets

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29462>
 2024-06-07 17:47:53 +00:00
Mike Blumenkrantz 27cd4b061c gallium: add drawid_offset to draw_mesh_tasks interface 
this matches the other draw interfaces

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29462>
 2024-06-07 17:47:53 +00:00
Alyssa Rosenzweig 761d79ec3e agx: fix indirect CF accounting 
if we have a non-compact indirectly indexed array of scalars

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29607>
 2024-06-07 16:57:03 +00:00
Alyssa Rosenzweig 30c8d55a71 asahi: extract agx_calculate_vbo_clamp 
honeykrisp will use.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29607>
 2024-06-07 16:57:03 +00:00
Alyssa Rosenzweig ad85c043e7 agx: prepare for lower_wpos_center 
required for correct sample shading in vk

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29607>
 2024-06-07 16:57:03 +00:00
Alyssa Rosenzweig 55724ec9aa asahi: implement rba2 for storage texel buffers 
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29607>
 2024-06-07 16:57:03 +00:00
Alyssa Rosenzweig 71fbd329fc asahi: implement rba2 for uniform texel buffers 
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29607>
 2024-06-07 16:57:03 +00:00
Alyssa Rosenzweig e5e3cac409 asahi: move null descriptor routines to common 
HK will use.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29607>
 2024-06-07 16:57:03 +00:00
Alyssa Rosenzweig e08d99063c asahi: use scalar outputs for rast shaders 
where applicable, so we can point size lower the result

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29607>
 2024-06-07 16:57:03 +00:00
Alyssa Rosenzweig f6439f8c77 asahi: add flag controlling sample mask without MSAA 
GL vs VK spec difference

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29607>
 2024-06-07 16:57:03 +00:00
Alyssa Rosenzweig 8998034fa9 agx: switch to combined clip/cull 
don't swim against the tide.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29607>
 2024-06-07 16:57:03 +00:00
Alyssa Rosenzweig 24bd46aa10 asahi: pack blend key 
reduce hashing for fs epilogs, hopefully

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29607>
 2024-06-07 16:57:03 +00:00
Alyssa Rosenzweig 65e64b6e2d agx: handle discard with force early tests 
we need to predicate the store, since we can't do a hardware demote after
running tests. this is similar to what the blob does.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29607>
 2024-06-07 16:57:03 +00:00