AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
183,406 Commits 1 Branch 0 Tags
a69b7f1b19cf2cf87eef1c4a87a189515f092c3b
Commit Graph

183406 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Faith Ekstrand a69b7f1b19 nouveau/mme/fermi: Stop truncating iadd immediates 
It's better to leave it in signed form so that we can assert that it's
an int18 later if we want.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27126>
 2024-01-17 21:26:07 +00:00
Samuel Pitoiset 10e2dbb63b radv: delay emitting streamout enable at draw time 
Since Vulkan 1.3.271, the spec allowed vkCmdBeginTransformFeedbackEXT
to be called without an active graphics pipeline bound when using
shader objects.

That means that the last VGT shader would be NULL once VKCTS is
updated accordingly. This change delays emitting streamout enable at
draw time to make sure the last VGT shader is present, regarldess if
ESO is enabled or not.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27075>
 2024-01-17 17:33:17 +00:00
Eric Engestrom bdfce158bd amd/ci: add flakes seen today 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27117>
 2024-01-17 17:01:59 +00:00
Vignesh Raman 79422eccd8 ci: Add kmod 
modprobe is required in drm-ci for vkms testing.
So add kmod to DEPS.

Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27088>
 2024-01-17 16:17:43 +00:00
Friedrich Vock a9831caa14 radv/rt: Add workaround to make leaves always active 
DOOM Eternal builds acceleration structures with inactive primitives and
tries to make them active in later AS updates. This is disallowed by the
spec and triggers a GPU hang. Fix the hang by working around the bug.

Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27034>
 2024-01-17 15:14:48 +00:00
Lionel Landwerlin a18ea091af nir/comparison_pre_tests: update expectations 
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Sviatoslav Peleshko <sviatoslav.peleshko@globallogic.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27087>
 2024-01-17 16:01:12 +02:00
Lionel Landwerlin 873fe637e2 nir/alu_srcs_negative_equal: bail earlier if possible 
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Sviatoslav Peleshko <sviatoslav.peleshko@globallogic.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27087>
 2024-01-17 16:00:30 +02:00
Ian Romanick 4740ee8d67 nir: Minor clean up in nir_alu_srcs_negative_equal 
Eliminate some cruft left after a8013644a1.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27087>
 2024-01-17 16:00:30 +02:00
Helen Koike b289028d0a ci/ci_gantt_chart: show duration on hover 
Show the duration of the given phase on hover.

Signed-off-by: Helen Koike <helen.koike@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25793>
 2024-01-17 13:10:07 +00:00
Helen Koike ffaa247b4f ci/ci_gantt_chart: add option to save output to a file 
Allow saving in html and in image formats.

Signed-off-by: Helen Koike <helen.koike@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25793>
 2024-01-17 13:10:07 +00:00
Helen Koike cf86e97ace ci/ci_gantt_chart: add timeout vertical line 
Add pipeline total duration and add a timeout vertical line to indicate
the 1h Timeout mark.

Signed-off-by: Helen Koike <helen.koike@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25793>
 2024-01-17 13:10:07 +00:00
Helen Koike 61ab9ae2af ci/ci_gantt_chart: add tool to analyse pipeline execution time 
ci_gantt_chart.py generates a gantt chart from a given pipeline url

Signed-off-by: Helen Koike <helen.koike@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25793>
 2024-01-17 13:10:07 +00:00
Helen Koike 9e8cbc8e91 ci/ci_run_n_monitor: move get_gitlab_pipeline_from_url() to gitlab_common 
Move this code to gitlab_common since it can be re-used by other
scripts.

Signed-off-by: Helen Koike <helen.koike@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25793>
 2024-01-17 13:10:07 +00:00
Samuel Pitoiset ce200669b1 radv: rename radv_pipeline_key to radv_graphics_pipeline_key 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27073>
 2024-01-17 12:08:24 +00:00
Samuel Pitoiset c5a5ab46c9 radv: remove radv_generate_pipeline_key() 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27073>
 2024-01-17 12:08:24 +00:00
Samuel Pitoiset 72d2eb39fb radv: pass radv_graphics_state_key to radv_hash_shaders() 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27073>
 2024-01-17 12:08:24 +00:00
Boris Brezillon b18bfed2c5 panvk: Fix access to unitialized panvk_pipeline_layout::num_sets field 
Commit 73eecffabd ("panvk: Use the vk_pipeline_layout base struct")
reworked the panvk logic to use vk_pipeline_layout, which contains the
number of descriptor set layout referenced by a pipeline layout, thus
deprecating panvk_pipeline_layout::num_sets.

Make panvk_fill_non_vs_attribs() use vk_pipeline_layout::set_count
instead of panvk_pipeline_layout::num_sets and kill the latter so we
can't introduce new users.

Fixes: 73eecffabd ("panvk: Use the vk_pipeline_layout base struct")
Cc: mesa-stable
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Constantine Shablya <constantine.shablya@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27107>
 2024-01-17 11:42:25 +00:00
Boris Brezillon 35a02560c8 panvk: Fix tracing 
pandecode_next_frame() take a decode context. Passing NULL leads to a
NULL deref.

Fixes: 56be9a55be ("pan/decode: handle more than one panfrost_device")
Cc: mesa-stable
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Constantine Shablya <constantine.shablya@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27107>
 2024-01-17 11:42:25 +00:00
Ray Smith c5ba55314c panfrost: Fix format tables for v4 and v5 
pan_format.c was only being built with PAN_ARCH in [6, 7, 9], but has
conditional compilation for PAN_ARCH <= 5 which never got compiled.

Signed-off-by: Ray Smith <rsmith@brightsign.biz>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26980>
 2024-01-17 11:07:48 +00:00
Ray Smith 404da63a0e panfrost: Don't try to set bifrost blendable format on midgard 
pan_blendable_format.bifrost is only accessed on bifrost, but we set it
to bogus values on midgard. Set it to 0/invalid instead.

Signed-off-by: Ray Smith <rsmith@brightsign.biz>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26980>
 2024-01-17 11:07:48 +00:00
Marek Olšák 969ed85110 radeonsi: don't flush CS before and after every blitter invocation 
u_blitter always calls set_stream_output_targets before and after clears
and blits, which always flushes here. Strengthen the flushing condition
and add an early exit.

No clue why this fixes the test.

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27059>
 2024-01-17 05:16:09 -05:00
Marek Olšák da49e9dcc2 radeonsi/gfx11: flush DB before Z/S clear to work around dEQP failures 
u_blitter calls set_stream_output_targets, which flushed the context
for clears. Put the workaround in the right place.

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27059>
 2024-01-17 05:16:01 -05:00
Marek Olšák 5fd31c1301 radeonsi/ci: update gfx11 flakes 
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26917>
 2024-01-17 09:05:55 +00:00
Marek Olšák 3601c1b2cf radeonsi/gfx11: clean up MAX_ALLOWED_TILES_IN_WAVE programming 
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26917>
 2024-01-17 09:05:55 +00:00
Marek Olšák 15f88ea46e radeonsi: rename *trivial_vs_prolog -> *trivial_vs_inputs 
This is a better name.

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26917>
 2024-01-17 09:05:55 +00:00
Marek Olšák b8c23cd4cd radeonsi: remove unused preloaded instance_divisor_constbuf 
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26917>
 2024-01-17 09:05:55 +00:00
Marek Olšák 9dbd3437c6 radeonsi: remove no-op additions for viewport0_y_inverted 
adding the same value to both sides of the equation has no effect

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26917>
 2024-01-17 09:05:55 +00:00
Marek Olšák bad2530a40 radeonsi: pack GS_STATE_ESGS_VERTEX_STRIDE better to save 2 bits 
Change it to the number of ES outputs, then compute the stride from that.

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26917>
 2024-01-17 09:05:55 +00:00
Marek Olšák 8eed352e05 radeonsi: split si_update_ngg_prim_state_sgpr into 2 functions 
GS_STATE_PROVOKING_VTX_FIRST no longer depends on the primitive type,
so we don't have to call it in si_set_rasterized_prim anymore.

Reviewed-by: Qiang Yu <yuq825@gmail.com>
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26917>
 2024-01-17 09:05:55 +00:00
Marek Olšák b3326bb947 radeonsi: change GS_STATE_PROVOKING_VTX_INDEX to 1 bit PROVOKING_VTX_FIRST 
to save 1 bit for later

Reviewed-by: Qiang Yu <yuq825@gmail.com>
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26917>
 2024-01-17 09:05:55 +00:00
Marek Olšák 6c74fc6bfb radeonsi: deduplicate gfx10_ngg_get_vertices_per_prim / get_num_vert_per_prim 
it was almost identical

Reviewed-by: Qiang Yu <yuq825@gmail.com>
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26917>
 2024-01-17 09:05:55 +00:00
Marek Olšák da20c6c73f radeonsi: don't use staging uploads for buffers & shaders with all VRAM visible 
Reviewed-by: Qiang Yu <yuq825@gmail.com>
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26917>
 2024-01-17 09:05:55 +00:00
Marek Olšák b7af7efee4 radeonsi: expose shader profiles to other .c files 
This will be used by NIR options for nir_opt_varyings.

Reviewed-by: Qiang Yu <yuq825@gmail.com>
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26917>
 2024-01-17 09:05:55 +00:00
Marek Olšák 767048f8b2 radeonsi: report more detailed output stats for shader-db 
Reviewed-by: Qiang Yu <yuq825@gmail.com>
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26917>
 2024-01-17 09:05:55 +00:00
Marek Olšák b9b00a0e7a ac,radeonsi: emulate GS primitive pipeline stat on gfx11 because of culling 
GS culls too, so the pipeline stat is incorrect. This can be exposed by
forcing monolithic shader use, which makes culling shaders immediately
available for tests to use.

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26917>
 2024-01-17 09:05:55 +00:00
Marek Olšák 1d3f937142 ac/nir: simplify code at the beginning of ac_nir_gs_shader_query 
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26917>
 2024-01-17 09:05:54 +00:00
Marek Olšák 4747bd6ba8 ac/nir: optimize out multiplications in small line culling 
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26917>
 2024-01-17 09:05:54 +00:00
Marek Olšák 0d74123633 ac/nir: rename clipdist_enable_mask -> clip_cull_dist_mask 
Reviewed-by: Qiang Yu <yuq825@gmail.com>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26917>
 2024-01-17 09:05:54 +00:00
Marek Olšák af4e91f6b8 ac/nir: don't write TCS outputs to memory if no_varying is set 
nir_opt_varyings() will set this, making it unnecessary to look
at the TES input mask.

Reviewed-by: Qiang Yu <yuq825@gmail.com>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26917>
 2024-01-17 09:05:54 +00:00
Marek Olšák 4880c1e12e amd: unify NIR options between RADV and radeonsi 
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26917>
 2024-01-17 09:05:54 +00:00
Sviatoslav Peleshko 6b0bfdfa9e nir: Use alu source components count in nir_alu_srcs_negative_equal 
When we use source from ALU instruction directly, the default swizzle array
should be populated with the same amount of components as the src has.

Otherwise, if we use nir_ssa_alu_instr_src_components, it can return
the destination components count that is lower than component index
actually used in that source. This can lead to false equality
between 0 (uninitialized) and 0 (.x) in swizzle comparison below.

Fixes: c6ee46a7 ("nir: Add nir_alu_srcs_negative_equal")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8704
Signed-off-by: Sviatoslav Peleshko <sviatoslav.peleshko@globallogic.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22655>
 2024-01-17 08:05:30 +00:00
Samuel Pitoiset e19ecf49ea radv: remove an extra new line in radv_shader.h 
To make clang-format CI job happy again.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27036>
 2024-01-17 07:25:49 +00:00
Samuel Pitoiset ee96de53e4 radv: remove the pipeline key for ray tracing pipelines 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27036>
 2024-01-17 07:25:49 +00:00
Samuel Pitoiset e799907071 radv: remove the pipeline key for compute pipelines 
Eveyerthing needed is already in radv_shader_stage_key.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27036>
 2024-01-17 07:25:49 +00:00
Samuel Pitoiset e017eb3b58 radv: stop hashing radv_pipeline_key for compute/rt pipelines 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27036>
 2024-01-17 07:25:49 +00:00
Samuel Pitoiset 739c8eb681 radv: hash radv_shader_stage_key 
This will allow us to remove the pipeline key completely for compute/rt
pipelines.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27036>
 2024-01-17 07:25:49 +00:00
Samuel Pitoiset 853298edb1 radv/rt: cleanup radv_parse_rt_stage() 
To avoid calling radv_pipeline_stage_init() twice.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27036>
 2024-01-17 07:25:49 +00:00
Samuel Pitoiset ffe997d71d radv: add radv_pipeline_get_shader_key() 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27036>
 2024-01-17 07:25:49 +00:00
Samuel Pitoiset 844004c335 radv: cleanup radv_generate_pipeline_key() 
Move everything in the same loop to prepare for a new helper.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27036>
 2024-01-17 07:25:49 +00:00
Samuel Pitoiset 3615bcdde3 radv: make sure to retain shaders key for imported shaders with GPL 
Now that everything is moved to the per-stage key, this information
needs to be retained/loaded with GPL, otherwise some flags might be
missing.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27036>
 2024-01-17 07:25:49 +00:00