Jordan Justen
761bcc3716
intel/genxml: Align "Texture Coordinate Mode" naming
...
Some older gens used '_' (underscore) while newer gens used a ' '
(space).
$ sed -i 's/Texture_Coordinate_Mode/Texture\ Coordinate\ Mode/' \
src/intel/genxml/*.xml
The naming needs to be aligned for importing enums later on.
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24547 >
2023-08-08 08:58:36 +00:00
Martin Stransky
87ec9456be
llvmpipe: fix UAF in lp_scene_is_resource_referenced.
...
reworked slightly by airlied
Reviewed-by: Roland Scheidegger <sroland@vmware.com >
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24414 >
2023-08-08 08:02:28 +00:00
Vinson Lee
9dd6866958
nvk: Fix assert
...
Fix defect reported by Coverity Scan.
Assign instead of compare (PW.ASSIGN_WHERE_COMPARE_MEANT)
assign_where_compare_meant: use of "=" where "==" may have been intended
Fixes: e41031d8ff ("nvk: Enable multiplane images and image views")
Signed-off-by: Vinson Lee <vlee@freedesktop.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24530 >
2023-08-08 07:40:55 +00:00
Karol Herbst
43f7d9693b
nouveau/mme: fix OOB inside tu104 simulator
...
Signed-off-by: Karol Herbst <git@karolherbst.de >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24544 >
2023-08-08 07:10:38 +00:00
Karol Herbst
1bee6a35ec
nouveau/mme: fix OOB access inside while_ine builder test
...
Signed-off-by: Karol Herbst <git@karolherbst.de >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24544 >
2023-08-08 07:10:38 +00:00
José Roberto de Souza
8483a59dde
anv: Override vendorID for Hogwarts Legacy
...
This is another game that makes use of XeSS but works when we fake
the vendorID.
With this temporary hack it works on i915 and Xe KMDs.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24506 >
2023-08-08 06:16:16 +00:00
Timothy Arceri
a7850f8cf3
glsl: fix spirv sso validation
...
The api validation calls will segfault without this as it will
try to fallback to string matching names which are NULL. This
would be incorrect behaviour even if the names weren't NULL so
here we correctly set the explicit location flag.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9483
Fixes: ffdb44d3a0 ("nir/linker: Add inputs/outputs to the program resource list")
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24529 >
2023-08-08 05:36:39 +00:00
Dave Airlie
ae6be7a44a
zink: turn off threaded cpu access if not visible.
...
This turns off the threaded cpu access it the resource isn't visible.
Fixes a bunch of crashes with current nvk.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24548 >
2023-08-08 05:06:11 +00:00
Faith Ekstrand
4f217e9670
nvk: Remove plane sources from tex instructions
...
The plane source is entirely handled by lower_tex() so there's no need
to keep it around. Codegen currently just ignores these but NAK will
assert if it sees an unknown source type.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24549 >
2023-08-08 04:48:33 +00:00
Mike Blumenkrantz
ac00f5a361
nir/linking_helpers: force type matching in does_varying_match
...
this otherwise breaks when i/o is scalarized in the producer but not
the consumer
cc: mesa-stable
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24458 >
2023-08-08 03:55:06 +00:00
Mike Blumenkrantz
58ba2bcc8c
nir/lower_io_to_scalar: fix 64bit io splitting
...
this was creating broken 64bit loads/stores using 32bit component
size
cc: mesa-stable
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24458 >
2023-08-08 03:55:06 +00:00
Benjamin Cheng
4755276baf
anv/video: copy from correct H264 scaling lists
...
Vulkan defines the scaling lists according to the H264 ITU spec, which
only defines ScalingList8x8[0] and ScalingList8x8[1] for
non-444 formats.
Reviewed-by: Lynne <dev@lynne.ee >
Reviewed-by: Hyunjun Ko <zzoon@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24474 >
2023-08-08 03:21:39 +00:00
Benjamin Cheng
0e4b1b8f23
radv/video: copy from correct H264 scaling lists
...
Vulkan defines the scaling lists according to the H264 ITU spec, which
only defines ScalingList8x8[0] and ScalingList8x8[1] for
non-444 formats. Since RADV only supports 420, just directly use those.
Reviewed-by: Lynne <dev@lynne.ee >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24413 >
2023-08-08 02:48:49 +00:00
Dave Airlie
08ca37645e
nvk: align sampler allocation counts with nvidia.
...
Fill out the missing property as well.
found running some zink piglit runs.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24532 >
2023-08-08 02:28:47 +00:00
Faith Ekstrand
f2f4e811be
nir/gl: Move glsl_type::sampler_target() into a helper in its one caller
...
The new version also doesn't need to worry about arrays of textures
because the caller already takes care of that.
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24503 >
2023-08-08 01:50:05 +00:00
Rob Clark
f17c5297d7
tu: Add virtgpu support
...
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23533 >
2023-08-08 00:20:48 +00:00
Rob Clark
006342be8b
tu/drm: Split out helper for iova alloc
...
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23533 >
2023-08-08 00:20:48 +00:00
Rob Clark
84524cfdfa
tu/drm: Add missing error path cleanup
...
Fixes: bea6290ca0 ("turnip: device global bo list")
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23533 >
2023-08-08 00:20:48 +00:00
Rob Clark
811f332d81
tu/drm: Factor out shared helpers
...
Factor out a few things that we can re-use between virtio and msm
backends.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23533 >
2023-08-08 00:20:48 +00:00
Rob Clark
c14a13d40d
tu: close submitqueues before device_finish()
...
Otherwise we would have already closed the device.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23533 >
2023-08-08 00:20:48 +00:00
Rob Clark
2196fdb2cf
freedreno/drm/virtio: Use global_faults
...
Rather than doing a synchronous round trip to the host to query fault
count, use the shmem->global_faults field if available. The kernel is
already only reporting faults associated with the same drm_file (which
in this case maps 1:1 to guest process), so the only thing we really
miss is, if the app is using multiple contexts, _which_ context the
fault was in. But vulkan doesn't even use that, which sounds like a
good enough argument that per-submitqueue granularity isn't really
needed.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23533 >
2023-08-08 00:20:48 +00:00
Rob Clark
0be8fab6c8
freedreno: Update virtgpu proto
...
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23533 >
2023-08-08 00:20:48 +00:00
Rob Clark
b0deba6210
drm-uapi: Update virtgpu header
...
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23533 >
2023-08-08 00:20:48 +00:00
Rob Clark
5d701d4eba
tu/knl: Remove some random const'ness
...
This gets in the way with virtio_gpu backend.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23533 >
2023-08-08 00:20:48 +00:00
Rob Clark
3a3a658797
tu/msm: staticify a couple things
...
Stop leaking some private implementation details as global symbols.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23533 >
2023-08-08 00:20:48 +00:00
Rob Clark
37834e3d7c
freedreno/drm/virtio: Remove unused header
...
A remnant from a very early version, prior to refactoring out
fd_ringbuffer_sp to share more code btwn msm and virtgpu backends.
Somehow this never got removed.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23533 >
2023-08-08 00:20:48 +00:00
Rob Clark
6ae6536ed9
freedreno: move virtgpu msm_proto.h to common
...
src/freedreno/virtgpu seems a bit overkill for a single header.. but
maybe there are some other bits we could share?
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23533 >
2023-08-08 00:20:48 +00:00
Gert Wollny
f7226181b4
r600/sfn: take number of dest values into account
...
With the write mask removed we have to run the loop correctly.
Fixes: b870988b77
r600/sfn: Stop referencing legacy functionality
Related: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9490
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24533 >
2023-08-08 00:02:18 +00:00
Kevron Rees
0bce97ce83
Force vk vendor for spider-man remastered
...
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24194 >
2023-08-07 23:06:44 +00:00
Mike Blumenkrantz
122ffb0c88
zink: unset line stipple ds3 state flags when stipple not available
...
Fixes: 7b4c1b3a42 ("zink: track and apply ds3 states only on change")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24478 >
2023-08-07 22:12:38 +00:00
Mike Blumenkrantz
b2a9881475
zink: use VK_WHOLE_SIZE when binding null db buffer descriptors
...
using range=0 is illegal
cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24478 >
2023-08-07 22:12:38 +00:00
Mike Blumenkrantz
4e9b20beb9
ci: bump VVL to 1.3.261
...
Reviewed-by: Eric Engestrom <eric@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24478 >
2023-08-07 22:12:38 +00:00
José Roberto de Souza
d686cadfbf
intel: Sync xe_drm.h and rename engine to exec_queue
...
Sync with commit f16c04291100 ("drm/xe: Rename engine to exec_queue").
With that Iris and ANV had some major renames that were done manually
as there is to many "engine" in non-related code.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24476 >
2023-08-07 21:34:14 +00:00
Eric Engestrom
6db246c960
egl: fixup _eglFilterConfigArray() params and drop _eglFallbackMatch() wrapper
...
Signed-off-by: Eric Engestrom <eric@engestrom.ch >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24292 >
2023-08-07 19:58:30 +00:00
Eric Engestrom
78714a4328
egl: make _eglFilterConfigArray static
...
Signed-off-by: Eric Engestrom <eric@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24292 >
2023-08-07 19:58:30 +00:00
Italo Nicola
109a6b8cd7
panfrost: add PAN_MESA_DEBUG=yuv for debugging yuv sampler
...
Signed-off-by: Italo Nicola <italonicola@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21109 >
2023-08-07 19:35:13 +00:00
Italo Nicola
bba74a84a9
panfrost: mandate proper alignment requirement depending format and arch
...
v7+ mandates row_stride alignment to be equal to surface alignment.
AFBC surface alignment is always 16-bytes.
NV12/NV21 formats on v7+ have 16-byte surface alignment.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21109 >
2023-08-07 19:35:12 +00:00
Italo Nicola
c1ad78476d
panfrost: advertise support for YUYV and variants
...
Signed-off-by: Italo Nicola <italonicola@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21109 >
2023-08-07 19:35:12 +00:00
Italo Nicola
4685628411
panfrost: prepare the driver to support YUYV and variants
...
Signed-off-by: Italo Nicola <italonicola@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21109 >
2023-08-07 19:35:12 +00:00
Italo Nicola
9692815293
panfrost: prepare pan_image_view for multiplanar formats
...
Signed-off-by: Italo Nicola <italonicola@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21109 >
2023-08-07 19:35:12 +00:00
Italo Nicola
3fff7f3d0e
pan/decode: decode Multiplanar Surface descriptors
...
Signed-off-by: Italo Nicola <italonicola@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21109 >
2023-08-07 19:35:12 +00:00
Italo Nicola
6a15167b81
panfrost: refactor (un)packing of surface descriptors
...
Use the genxml helpers to pack/unpack midgard and bifrost surface
descriptors. Also changed how we describe midgard's descriptors, to make
it more straightforward. We currently only use SURFACE_WITH_STRIDE for
midgard, but pandecode should still be able to decode other surface
descriptor types.
This commit shouldn't change panfrost/pandecode behavior.
Consequenctly, this refactor also prepares pandecode to handle the
SURFACE_YUV descriptor for bifrost in the following patch.
Signed-off-by: Italo Nicola <italonicola@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21109 >
2023-08-07 19:35:12 +00:00
Italo Nicola
f27b02838d
panfrost/genxml: add Multiplanar Surface descriptor
...
Signed-off-by: Italo Nicola <italonicola@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21109 >
2023-08-07 19:35:12 +00:00
Italo Nicola
0d5bf46272
panfrost/genxml: fix Surface With Stride descriptor alignment
...
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21109 >
2023-08-07 19:35:12 +00:00
Luigi Santivetti
c5a6e88c4e
pvr: do not claim support for ASTC texture compression
...
We don't support any ASTC formats yet, but the textureCompressionASTC_LDR
feature was incorrectly set to true. Fix this by setting it to false and
don't advertise ASTC support for texture compression.
Fixes dEQP-VK.api.info.format_properties.compressed_formats
Fixes: 8991e646 ("pvr: Add a Vulkan driver for Imagination Technologies PowerVR Rogue GPUs")
Signed-off-by: Luigi Santivetti <luigi.santivetti@imgtec.com >
Reviewed-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24448 >
2023-08-07 14:06:44 +00:00
antonino
6c25dc0909
freedreno: add ci flake
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24539 >
2023-08-07 13:30:18 +00:00
antonino
d2d0f4a28a
virgl: add ci flake
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24539 >
2023-08-07 13:30:18 +00:00
Daniel Stone
cfa23e6690
panfrost/vk: Use correct sampler dimensions for MSAA
...
2D-MS samplers are SAMPLER_DIM_MS, not SAMPLER_DIM_2D. There is no MSAA
for non-2D textures.
Signed-off-by: Daniel Stone <daniels@collabora.com >
Closes : mesa/mesa#9474
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24494 >
2023-08-07 10:39:37 +00:00
Lionel Landwerlin
f5074adeb5
anv: enable INTEL_DEBUG=nofc
...
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24510 >
2023-08-07 12:02:57 +03:00
Iago Toral Quiroga
85c5b68823
v3dv: drop cpu path for buffer to image copies
...
We really want to avoid cpu jobs as much as possible. Also,
the texel buffer path we have for this should be able to
handle most cases.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24466 >
2023-08-07 06:48:40 +00:00