AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
143,302 Commits 1 Branch 0 Tags
97b0981ed9599365d760ee866adfc49628b95145
Commit Graph

143302 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Danylo Piliaiev 97b0981ed9 tu: disable gmem in primary cmdbuffer if secondary has it disabled 
If secondary command buffer is emitted within a subpass it may have
barriers which forces us to disable gmem for current renderpass.

Fixes: 20547a110e "tu: delay decision of forcing sysmem due to subpass self-dependencies"

Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12219>
 2021-08-05 18:51:51 +03:00
Michel Dänzer 6ccf11ac2b ci: Drop "success" job 
It was added to make sure every pipeline for a merge request has at
least one job which passes (otherwise it's not possible to merge the
MR). Now the "sanity" job always exists in such pipelines, so this
isn't needed anymore.

Fixes: 4c41d1900e "ci: Add jobs running ci-fairy checks"
Reviewed-by: Daniel Stone <daniels@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12198>
 2021-08-05 12:24:58 +00:00
Rhys Perry 5a536eca9c aco: calculate correct register demand for branch instructions 
Since copies for the successor's linear phis are inserted before the
branch, we should consider the definitions and operands of the successor's
linear phis.

Fixes a Detroit: Become Human spilling failure with GCM+GVN.

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12035>
 2021-08-05 12:01:58 +00:00
Juan A. Suarez Romero 87a8349411 ci/v3dv: update expected results 
v1:
 - Include CTS fix comment (Juan)

Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com>
Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12168>
 2021-08-05 11:43:42 +00:00
Erik Faye-Lund d762a01e18 microsoft/compiler: harmonize num_psv_inputs with outputs 
This doesn't seems to make a practical difference, but it seems better
to do it the same way as we do for outputs, as well as what DXC does.

Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12197>
 2021-08-05 09:17:40 +00:00
Erik Faye-Lund 63dae1bd8b microsoft/compiler: fix psv-output calculation 
Rather surprisingly, the value stored in the NumVectors field of the
DXIL PSV header isn't the number of vectors, but rather the *maximum*
vector used.

This makes a difference when we're not writing to the first element of
an array, where we would previously generate a validation error.

Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12197>
 2021-08-05 09:17:40 +00:00
Antonio Caggiano 50e849fb94 freedreno/ci: Add a manual job for tracking performance 
Use Piglit's replay profile to measure and store the time that frames
take to render in the GPU.

This job won't run automatically in regular pipelines, but will be
triggered automatically by a script for every successful pre-merge
pipeline.

This is because we want to generate performance data for every relevant
commit merged in main, but we don't want to keep a device busy during
the pre-merge run.

Signed-off-by: Antonio Caggiano <antonio.caggiano@collabora.com>
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Reviewed-by: Michel Dänzer <mdaenzer@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12185>
 2021-08-05 07:55:32 +00:00
Dave Airlie 518b94e8e1 clover/llvm: turn off optional CL 3 features. 
We don't support these with clover yet, so turn them off to get
clang back to the older llvm 12 behaviour.

Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Acked-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11752>
 2021-08-05 07:07:44 +00:00
Samuel Pitoiset 16793c8efa ac/surface: implement CmaskAddrFromCoord in NIR on GFX10+ 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12182>
 2021-08-05 06:37:09 +00:00
Samuel Pitoiset 1d67fa4d73 ac/surface: add tests for CmaskAddrFromCoord on GFX10+ 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12182>
 2021-08-05 06:37:09 +00:00
Samuel Pitoiset 0926b268fc amd/addrlib: expose CMASK address equations to drivers on GFX10+ 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12182>
 2021-08-05 06:37:09 +00:00
Tomeu Vizoso 19670129c5 ci: Update canvas_text trace 
The previous one had all rendering and setup in a single frame, so
repeatedly replaying it for performance tracking was reaching OOM due to
the repeated creation of resources that weren't being released.

Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12195>
 2021-08-05 05:44:57 +00:00
Dylan Baker da00a11bf2 bin/gen_release_notes: Fix commits with multiple Closes: 
Currently we'd only handle the last one, not all of them. Which is
clearely not correct.

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12201>
 2021-08-04 23:03:57 +00:00
Dylan Baker 30f7b55e47 bin/gen_release_notes: Don't consider issues for other projects 
We have enough commits in mesa that have external dependencies that we
need to be sure that a Closes: https://... is actually for mesa and not
for another project.

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12201>
 2021-08-04 23:03:57 +00:00
Dylan Baker 9dc3672b00 bin/gen_release_notes: Add basic tests for parsing issues 
Since test coverage here is pretty important for a heuristic like this.

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12201>
 2021-08-04 23:03:57 +00:00
Dylan Baker 7055282231 docs: Add calendar entries for 21.2 release. 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12202>
 2021-08-04 12:12:47 -07:00
Dylan Baker c2a241faa9 docs: update calendar and link releases notes for 21.2.0 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12202>
 2021-08-04 12:09:26 -07:00
Dylan Baker 98f0db5321 docs: update calendar for 21.2.0-rc3 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12202>
 2021-08-04 12:09:23 -07:00
Dylan Baker ac428b5305 docs: update calendar for 21.2.0-rc2 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12202>
 2021-08-04 12:09:21 -07:00
Dylan Baker 04adf1834c docs: add release notes for 21.2.0 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12202>
 2021-08-04 12:09:11 -07:00
Mike Blumenkrantz c886ce2991 zink: simplify else clause for mem info gathering 
it doesn't matter if this is host-visible, it just has to not be device-local

Fixes: 73f6bff07f ("zink: fix mem info query to be more permissive")

Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12199>
 2021-08-04 14:07:58 -04:00
Mike Blumenkrantz 42442a0d4e zink: sum available memory heaps instead of assigning 
this is supposed to accumulate now

Fixes: 73f6bff07f ("zink: fix mem info query to be more permissive")

Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12199>
 2021-08-04 14:07:58 -04:00
Emma Anholt 8cfa6b4d75 ci/freedreno: Mark border_color as passing on a5xx. 
They're marked as flaky, but they're all passing on my board, and maybe in
CI too.  Let's see if CI still sees them as flaky once the expectations
are right.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12192>
 2021-08-04 17:21:43 +00:00
Emma Anholt 1f66fcf5a6 freedreno/a5xx: Don't try to emit FS images in binning command streams. 
We don't have a compiled FS in that case, so the shader deref fails.  We
don't need the state, anyway.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12192>
 2021-08-04 17:21:43 +00:00
Emma Anholt c20287f8e4 freedreno/a5xx: Disable TF when pausing or transitioning to non-TF. 
This is not as clean as on a6xx where we just re-emit the SO state, but it
cleans up our dEQP results a ton.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12192>
 2021-08-04 17:21:43 +00:00
Emma Anholt 1f89ea419d ci/freedreno: Clear out TF API errors xfails. 
These tests are flaky and sometimes segfault in CI, but usually pass.  We
hadn't noticed their change due to the test being marked as flaky.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12192>
 2021-08-04 17:21:43 +00:00
Timur Kristóf 8918a809ce ac: Remove deprecated use_late_alloc field as nobody uses it anymore. 
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11905>
 2021-08-04 15:37:05 +00:00
Timur Kristóf d911259c3a radv: Use ac_compute_late_alloc in radv_pipeline. 
This aligns RADV with RadeonSI in how it handles late alloc,
making it easier for us to deal with deadlocks and such.

Also move setting the RSRC3 registers for VS, GS and NGG
into radv_pipeline.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11905>
 2021-08-04 15:37:05 +00:00
Timur Kristóf 61eb3debcf radv: Don't toggle PC oversubscription for NGG culling. 
We are going to add this directly to the pipeline.
If a pipeline has such a shader, NGG culling is turned on
most of the time, so it's not useful to toggle this setting.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11905>
 2021-08-04 15:37:05 +00:00
Timur Kristóf 448592b9ae aco: Use Navi 10 empty NGG output workaround on NGG culling shaders. 
Navi 10 can hang when an NGG workgroup has no output,
so we work around that by always exporting a single zero-area
triangle with a single vertex that has all-NaN coordinates.

Thus far, we only employed this for NGG GS, because on all
other stages, the output can't be empty.

However, with NGG culling, the output can be empty, so let's
apply the same workaround there too.

Cc: mesa-stable
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12169>
 2021-08-04 12:28:34 +00:00
Rhys Perry 566970f273 aco: use image_dim and image_array intrinsic indices 
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12190>
 2021-08-04 12:09:07 +00:00
Rhys Perry 39db5a569b radv: set image_dim and image_array intrinsic indices 
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12190>
 2021-08-04 12:09:07 +00:00
Dave Airlie 513f9b5dc9 ci: bump to latest virglrenderer for anisotropic support 
Update ci results

Reviewed-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11944>
 2021-08-04 10:49:55 +00:00
Dave Airlie 2116a4f5cc virgl: add support for anisotropic texture filtering 
This is the guest side for adding correct anisotropic filtering support

Reviewed-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11944>
 2021-08-04 10:49:55 +00:00
Dave Airlie e831c4a537 virgl: disable anisotropic filtering. 
virgl doesn't yet support anisotropic filtering so don't advertise it.

Fixes: a8987b88ff ("virgl: add driver for virtio-gpu 3D (v2)")
Reviewed-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11944>
 2021-08-04 10:49:55 +00:00
Sergii Melikhov d16b9b27b0 iris: Fix Null pointer dereferences 
Fix the error from Coverity report: CID 1489765

Signed-off-by: Sergii Melikhov <sergii.v.melikhov@globallogic.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12179>
 2021-08-04 07:52:35 +00:00
Charmaine Lee 6751d832c5 aux/draw: Check for preferred IR to take nir-to-tgsi path in draw module 
When a vertex program is translated to nir, it uses
nir_to_tgsi_compile_options for drivers with only nir-to-tgsi based
NIR support. But this compile option might not be the same as the NIR
compile option from llvmpipe, hence when the nir shader is bound
to the draw module, it hits an assertion in do_alu_action() when
encounters nir_op_fdot3.

With this patch, draw will take the nir-to-tgsi path if preferred IR
from the driver is TGSI.

Fixes assert running Maya on SVGA device.

Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Neha Bhende <bhenden@vmware.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12176>
 2021-08-03 22:13:10 +00:00
Jason Ekstrand 0ddac113f8 nir: Removing uses of SSA defs destroys SSA liveness 
The liveness information will be a superset of real liveness so it's
unlikely something will explode if it tries to use it.  However, it is
out-of-date and should be re-run if someone really wants it.

Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12186>
 2021-08-03 21:36:53 +00:00
Ian Romanick 9dfe7fbc6b isl: Use CLAMP macro instead of MIN of MAX 
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12177>
 2021-08-03 12:55:11 -07:00
Ian Romanick 72259a870f util: Add and use functions to calculate min and max int for a size 
Many places need to know the maximum or minimum possible value for a
given size integer... so everyone just open-codes their favorite
version.  There is some potential to hit either undefined or
implementation-defined behavior, so having one version that Just Works
seems beneficial.

v2: Fix copy-and-pasted bug (INT64_MAX instead of INT64_MIN) in
u_intmin.  Noticed by CI.  Lol.  Rename functions
`s/u_(uint|int)(min|max)/u_\1N_\2/g`.  Suggested by Jason.  Add some
unit tests that would have caught the copy-and-paste bug before wasting
CI time.  Change the implementation of u_intN_min to use the same
pattern as stdint.h.  This avoids the integer division.  Noticed by
Jason.

v3: Add changes to convert_clear_color
(src/gallium/drivers/iris/iris_clear.c).  Suggested by Nanley.

Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Suggested-by: Jason Ekstrand <jason@jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12177>
 2021-08-03 12:55:02 -07:00
Emma Anholt 08d6361591 ci: Update piglit to 4545a28cd8fea03fbab0e5f90bfbd812c32f3be1 
Brings in duplicate subtest fixes, gpu_shader4 tests, and more.  This
shuffles the radeonsi fractional test run, so we get to catch up with more
failing subtests.

Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12110>
 2021-08-03 18:32:01 +00:00
Emma Anholt f04f8ac692 ci/zink: Use deqp-runner suite support to reduce the CI job count. 
The tests were passing so quickly, and the 1/4th GLES3 subset changed on
the transition to multiple testsuites, so I promoted it to a full run.

Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Acked-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12110>
 2021-08-03 18:32:01 +00:00
Emma Anholt 55bd582598 ci/virgl: Use deqp-runner suite support to reduce CI job count. 
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12110>
 2021-08-03 18:32:01 +00:00
Emma Anholt cd3b6689b2 ci: Save dEQP results on all tests. 
Everyone can get artifacts now.  Let's make those artifacts useful.

Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12110>
 2021-08-03 18:32:01 +00:00
Emma Anholt ad2995d1e1 ci/i915g: Merge the two dEQP runs together. 
Fewer buttons for me to have to click for manual MR testing.

Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12110>
 2021-08-03 18:32:01 +00:00
Emma Anholt 6f7a921c99 ci/llvmpipe: Use the deqp-runner suite support to consolidate jobs. 
5 jobs become 2, plus we add KHR-GLES3 and 31 to the test set since
it's cheap.

Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12110>
 2021-08-03 18:32:01 +00:00
Emma Anholt 4658a9a479 ci: Uprev deqp-runner and use "suite" support to merge softpipe runs. 
The deqp-runner "suite" support lets us specify all the deqp variants at
once and shard them across gitlab jobs, so we reduce docker overhead and
get fewer jobs to review the output of.

Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12110>
 2021-08-03 18:32:01 +00:00
Emma Anholt 1bdab45594 ci/i915: Update deqp expectations for another test passing. 
!11411 made this one start passing thanks to reducing instruction counts.

Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Acked-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12110>
 2021-08-03 18:32:01 +00:00
Lionel Landwerlin 97be8e42e4 intel/disasm: fix missing oword index decoding 
Also switch to array of strings to show high/low dwords.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: daba2894ff ("intel/disasm: decode/describe more send messages")
Acked-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12183>
 2021-08-03 17:26:37 +00:00
Pierre Moreau b4e5bf0637 clover/nir: Set constant buffer pointer size to host 
The `argument::size` is supposed to represent the size of a pointer on
the host and not on the device (for which argument::target_size`
exists).

v3: Use `sizeof(buf)` instead of `marg.size`. (Francisco Jerez)

Fixes: 7c6f1d3bf9 ("clover/nir: extract constant buffer into its own section")

Reviewed-by: Francisco Jerez <currojerez@riseup.net>
Signed-off-by: Pierre Moreau <dev@pmoreau.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10256>
 2021-08-03 16:43:49 +00:00