AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
176,268 Commits 1 Branch 0 Tags
6ae2844c520b16d19f7f51650bf4b87e2d6f3749
Commit Graph

163176 Commits

Author SHA1 Message Date
Iago Toral Quiroga 6ae2844c52 v3d: fix texture packing lowering 
For texture instructions that don't have sampler state we have
been incorrectly using sampler index to retrive texture packing
information. This is incorrect for two reasons:

1. These instructions don't have a defined sampler index by
   definition.
2. The driver was not setting it either, so effectively, we
   have always been using whatever we had set for the first
   texture, which is obviously bogus.

Fix this by running a lowering pass that sets the index to use
in backend_flags, which is what the compiler expects, based on
the texture index, which is what we want in GL since we make
this decision based on the texture format.

Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24537>
 2023-08-10 07:10:01 +00:00
Iago Toral Quiroga d28e5960e5 v3dv: assert that only tex instructions with sampler state have a sampler src 
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24537>
 2023-08-10 07:10:01 +00:00
Iago Toral Quiroga da625903c7 squash! v3dv,broadcom/compiler: don't abuse sampler index 
For tex instructions that don't have sampler state use backend_flags
instead of sampler index to bind default sampler state.

Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24537>
 2023-08-10 07:10:01 +00:00
Iago Toral Quiroga b2de3f71dc nir/lower_tex: use a callback to check sampler return size packing 
The lower_tex_packing pass relies on the sampler index to access packing
information, but this is only valid for tex instructions that have sampler
state (so not txf, etc). Instead, let backends provide a callback to inform
the lowering about the packing used with a given texture instruction which
is more flexible.

Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24537>
 2023-08-10 07:10:00 +00:00
Iago Toral Quiroga 374c660582 nir/lower_tex: copy backend_flags field when copying a tex instruction 
Fixes: 29c4417fb8 ('nir: Add a backend_flags field to nir_tex_instr')
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24537>
 2023-08-10 07:10:00 +00:00
Iago Toral Quiroga a95c33eeaf v3dv: remove unused code 
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24537>
 2023-08-10 07:10:00 +00:00
Lionel Landwerlin 6f694432e4 intel/fs: add variable for output of debug backend optimizer 
It can be useful to compare 2 runs with different compiler changes.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24552>
 2023-08-10 06:39:57 +00:00
Lionel Landwerlin 0e244d56e3 intel/fs: track more steps with INTEL_DEBUG=optimizer 
One particular nice thing to have is the first generated backend IR
before validation. Especially if you made a mistake in the NIR
translation, you can at least look at it before validation tells you
off.

Then the last 2 steps of the optimize() function can be interesting to
look at.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24552>
 2023-08-10 06:39:57 +00:00
Vinson Lee f9cd8446ef lavapipe: Fix struct initialization 
Fix defect reported by Coverity Scan.

Evaluation order violation (EVALUATION_ORDER)
write_write_typo: In box.x = box.x = copy->imageOffset.x, box.x is written twice with the same value.

Fixes: 9e9d90c6c3 ("lavapipe: VK_EXT_host_image_copy")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24531>
 2023-08-09 23:15:10 -07:00
Dave Airlie 81cae3d8d2 nvk: enable KHR_shader_clock. 
This should all be wired up.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24595>
 2023-08-10 03:39:49 +00:00
Samuel Pitoiset ba49f2bef1 radv: advertise VK_KHR_maintenance5 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24392>
 2023-08-10 03:05:02 +00:00
Samuel Pitoiset 54caa8d346 radv: implement radv_Get{Device}ImageSubresourceLayout2KHR() 
Not really possible without creating an image internally.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24392>
 2023-08-10 03:05:02 +00:00
Samuel Pitoiset 6861c5275b radv: allow VK_REMAINING_ARRAY_LAYERS with VkImageSubresourceLayers 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24392>
 2023-08-10 03:05:02 +00:00
Samuel Pitoiset 2ed52ca578 radv: add support for VkBufferUsageFlags2CreateInfoKHR 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24392>
 2023-08-10 03:05:02 +00:00
Samuel Pitoiset 9089b091b2 radv: add support for VkPipelineCreateFlags2CreateInfoKHR 
If the structure is present in pNext, it's used instead of flags.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24392>
 2023-08-10 03:05:02 +00:00
Samuel Pitoiset f4b9c5b1d0 radv: store pipeline create flags to radv_pipeline::create_flags 
This is a common practice in vulkan/runtime and this will be easier
to use extended pipeline create flags.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24392>
 2023-08-10 03:05:02 +00:00
Samuel Pitoiset 15548d8a5f radv/rmv: remove unused pipeline create flags when logging pipelines 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24392>
 2023-08-10 03:05:02 +00:00
Samuel Pitoiset 3f617b8e4a radv: allow VK_WHOLE_SIZE for pSizes in vkCmdBindVertexBuffers2() 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24392>
 2023-08-10 03:05:02 +00:00
Samuel Pitoiset cbfd2931bb radv: implement vkCmdBindIndexBuffer2KHR() 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24392>
 2023-08-10 03:05:02 +00:00
Samuel Pitoiset bbb5cdcf40 vulkan/render_pass: add common vkGetRenderingAreaGranularityKHR() 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24392>
 2023-08-10 03:05:02 +00:00
Thomas H.P. Andersen 95feb95c95 nvk: advertise VK_EXT_tooling_info 
Use the implementation in common code to report no tools in use.

Passes:
dEQP-VK.api.tooling_info.validate_getter
dEQP-VK.api.tooling_info.validate_tools_properties

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24594>
 2023-08-10 02:30:45 +00:00
Mike Blumenkrantz 134014dfc7 lavapipe: maintenance5 
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24589>
 2023-08-10 01:56:03 +00:00
Mike Blumenkrantz e70179f3c6 lavapipe: VK_REMAINING_ARRAY_LAYERS for copy ops 
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24589>
 2023-08-10 01:56:03 +00:00
Mike Blumenkrantz 6522b55a39 lavapipe: GetDeviceImageSubresourceLayoutKHR 
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24589>
 2023-08-10 01:56:03 +00:00
Mike Blumenkrantz c5a8c97098 lavapipe: BindIndexBuffer2 
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24589>
 2023-08-10 01:56:03 +00:00
Mike Blumenkrantz cee494aafd lavapipe: block yuv formats from getting blit feature flags 
this is illegal

cc: mesa-stable

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24589>
 2023-08-10 01:56:03 +00:00
Mike Blumenkrantz 9e2f95eae3 lavapipe: fix resolves where src image has a layer offset 
cc: mesa-stable

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24589>
 2023-08-10 01:56:03 +00:00
Mike Blumenkrantz 8a5936ae2f lavapipe: fix BindVertexBuffers2 buffer size handling 
if the size specified is smaller than the buffer, the buffer needs to
be clamped

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24589>
 2023-08-10 01:56:03 +00:00
Mike Blumenkrantz ce09458917 llvmpipe: fix early depth + alpha2coverage + occlusion query interaction 
in this scenario, sample counting must happen before a2c, as a2c may eliminate
coverage if alpha is zero, leading to a sample count of zero

dEQP-VK.fragment_operations.early_fragment.sample_count_early_fragment_tests_depth_alpha_to_coverage_samples_4_maintenance5

cc: mesa-stable

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24589>
 2023-08-10 01:56:03 +00:00
Mike Blumenkrantz 632d4de214 llvmpipe: block weird uses of subsampled formats in buffers 
cc: mesa-stable

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24589>
 2023-08-10 01:56:03 +00:00
Mike Blumenkrantz 6cd51fc1d9 lavapipe: GetRenderingAreaGranularityKHR 
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24589>
 2023-08-10 01:56:03 +00:00
Mike Blumenkrantz db7304fe3c llvmpipe: export PIPE_CAP_IMAGE_LOAD_FORMATTED 
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24589>
 2023-08-10 01:56:03 +00:00
Mike Blumenkrantz b60ac8b52a llvmpipe: enable A8_UNORM for shader images 
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24589>
 2023-08-10 01:56:03 +00:00
Mike Blumenkrantz ba7efa4dfa gallivm: handle A8_UNORM image stores 
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24589>
 2023-08-10 01:56:03 +00:00
timmac-qmc ae5a08de67 glsl: fix potential crash with DisableUniformArrayResize 
We still need to gather information on uniform use when skipping
uniform array resize.

Fixes: ac5af6c0 ("util/driconf: add Dune: Spice Wars workaround")
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24576>
 2023-08-10 01:12:51 +00:00
Georg Lehmann 5c70a55bf3 nir/opt_intrinsics: optimize (exclusive_scan(op, a) op a) to inclusive scan 
D3D only has exclusive scans so some games use this pattern.

Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24557>
 2023-08-09 23:10:13 +00:00
Georg Lehmann 7a3e5dd2ec aco: use s_bitreplicate_b64_b32 to set exec to 0xffff0000ffff0000 
Foz-DB Navi21:
Totals from 29 (0.02% of 132657) affected shaders:
Instrs: 19342 -> 19301 (-0.21%)

Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24561>
 2023-08-09 20:29:01 +00:00
Mike Blumenkrantz ca2e2f4bd0 zink: apply ZINK_DEBUG=noopt to linked separate shaders 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24581>
 2023-08-09 14:13:47 +00:00
Mike Blumenkrantz 717ad8c5c8 zink: generated tcs is on the tes, not the vs 
not sure how I screwed this up

Fixes: 4c47d83051 ("zink: use EXT_shader_object to implement generic separate shader precompile")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24581>
 2023-08-09 14:13:47 +00:00
David Heidelberg 39e281073a ci/zink: Add flake seen in the wild 
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24577>
 2023-08-09 10:36:24 +00:00
Georg Lehmann 42ab786e52 ac/nir: handle more special cases in ac_nir_unpack_arg 
Foz-DB Navi21:
Totals from 60972 (45.96% of 132657) affected shaders:
CodeSize: 158371336 -> 158127376 (-0.15%)

Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24534>
 2023-08-09 10:04:53 +00:00
Feng Jiang 82dd60dfb0 virgl/video: Enable AV1 decoding 
Signed-off-by: Feng Jiang <jiangfeng@kylinos.cn>
Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com>
Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23386>
 2023-08-09 09:04:58 +00:00
Feng Jiang c4a1b4e100 virgl/video: Add support for AV1 decoding 
Signed-off-by: Feng Jiang <jiangfeng@kylinos.cn>
Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com>
Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23386>
 2023-08-09 09:04:58 +00:00
Feng Jiang ea5054a94a virgl/video: Add definition of virgl_av1_picture_desc 
The virgl_av1_picture_desc references to pipe_av1_picture_desc.

Signed-off-by: Feng Jiang <jiangfeng@kylinos.cn>
Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com>
Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23386>
 2023-08-09 09:04:58 +00:00
Feng Jiang 82ee420b15 frontends/va: Add slice_count to AV1 slice_parameter 
Save the number of slice in AV1 slice parameter, so that the
underlying driver (such as virgl) can handle the slice parameters
better.

Signed-off-by: Feng Jiang <jiangfeng@kylinos.cn>
Suggested-by: Sil Vilerino <sivileri@microsoft.com>
Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com>
Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>
Reviewed-by: Sil Vilerino <sivileri@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23386>
 2023-08-09 09:04:58 +00:00
Lionel Landwerlin c87d5c67d9 anv: implement VK_EXT_pipeline_robustness 
v2:
 - Use vk_pipeline_robustness_state

Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17545>
 2023-08-09 09:03:45 +03:00
Lionel Landwerlin 9934613c74 anv/hasvk: track robustness per pipeline stage 
And split them into UBO and SSBO

v2 (Lionel):
 - Get rid of robustness fields in anv_shader_bin
v3 (Lionel):
 - Do not pass unused parameters around

Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17545>
 2023-08-09 09:00:12 +03:00
Lionel Landwerlin c4ec60e87d hasvk: remove descriptor array bounds checking 
Same reason as Anv.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17545>
 2023-08-09 09:00:12 +03:00
Lionel Landwerlin 059e82a469 anv: remove descriptor array bounds checking 
We cannot find anything in the Vulkan spec requiring this. D3D12 [1]
says it's undefined as long as it doesn't crash the OS :

   "Out of bounds indexing of any descriptor table from the shader
    results in a largely undefined memory access, including the
    possibility of reading arbitrary in-process memory as if it is a
    hardware state descriptor and living with the consequence of what
    the hardware does with that. This could produce a device reset, but
    will not crash Windows."

[1] : https://learn.microsoft.com/en-us/windows/win32/direct3d12/advanced-use-of-descriptor-tables#out-of-bounds-indexing

Found 2 titles affected by this change

Some pretty good results on Cyberpunk 2077 :

  Totals from 10285 (100.00% of 10285) affected shaders:
  Instrs: 7638709 -> 7517360 (-1.59%); split: -1.64%, +0.05%
  Cycles: 148047414 -> 148470916 (+0.29%); split: -0.83%, +1.12%
  Subgroup size: 112544 -> 112576 (+0.03%); split: +0.04%, -0.01%
  Spill count: 98 -> 90 (-8.16%)
  Fill count: 90 -> 82 (-8.89%)
  Max live registers: 495274 -> 479502 (-3.18%); split: -3.21%, +0.03%
  Max dispatch width: 87824 -> 91168 (+3.81%); split: +4.10%, -0.29%

  Gaining 297 shaders in SIMD16/32, loosing 16 SIMD32 shaders

Some not so good results on Strange Brigade :

  Totals from 4027 (100.00% of 4027) affected shaders:
  Instrs: 2080355 -> 2013880 (-3.20%); split: -3.20%, +0.01%
  Cycles: 25405149 -> 25170579 (-0.92%); split: -1.37%, +0.45%
  Max live registers: 167303 -> 168958 (+0.99%)
  Max dispatch width: 33264 -> 32496 (-2.31%)

  Loosing 96 SIMD16 shaders.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17545>
 2023-08-09 09:00:12 +03:00
Lionel Landwerlin 0e5b4b1b43 hasvk: fix null descriptor handling with A64 messages 
This replicates the same fix we did for Anv and null descriptors with
A64 messages from commit efcda1c530 ("anv: fix null descriptor
handling with A64 messages").

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: mesa-stable
Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17545>
 2023-08-09 09:00:12 +03:00