AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
182,193 Commits 1 Branch 0 Tags
6a92af158dc132eee449c175bdee66d92c68d191
Commit Graph

182193 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Lionel Landwerlin 6a92af158d anv: wait for CS write completion before executing secondary 
Got a error state on DG2 with a jump to secondary. The secondary is
empty and padded with MI_NOOPs to workaround the CS prefetching.
According to the error state, the return jump address from the
secondary to the primary is 0x0. The ACTHD register value is 0x10, so
it seems that the command streamer indeed jumped to 0x0 and hanged on
a few dwords after that.

The return address should have been set edited by a previous
MI_STORE_DATA_IMM instruction. So it appears it did not complete in
time for the command stream to catch it. On Gfx12+ this can happend if
we do not set ForceWriteCompletionCheck.

This change also takes the opportunity to remove the padding MI_NOOPs
at the end of secondaries on Gfx12+ by using disabling the prefetching
just before jumping into secondaries and reenabling it at the
beginning of each secondary.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: mesa-stable
Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26665>
 2023-12-14 11:28:31 +02:00
Samuel Pitoiset 98ea540158 radv: add support for MRT compaction with PS epilogs 
Now that PS epilogs are always compiled during cmdbuf recording, we
have all information to enable MRT compaction, for optimal performance.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26667>
 2023-12-14 09:51:26 +01:00
Samuel Pitoiset 8760b7fab7 radv: cleanup radv_pipeline_generate_ps_epilog_key() 
This has no effects because key->spi_shader_col_format isn't used when
the graphics pipeline needs to compile a PS epilog.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26663>
 2023-12-14 08:18:46 +00:00
Samuel Pitoiset 60e6e3f8e6 radv: cleanup gathering PS info with/without PS epilogs 
To make it clear that some fields aren't used with PS epilogs.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26663>
 2023-12-14 08:18:46 +00:00
Samuel Pitoiset a39c3920fb radv: cleanup ac_nir_lower_ps options 
To make it clear that some fields aren't used with PS epilogs.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26663>
 2023-12-14 08:18:46 +00:00
Samuel Pitoiset 78e45221bd radv: emit the task shader in radv_emit_graphics_pipeline() 
It's a better place to do so.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26414>
 2023-12-14 07:57:32 +00:00
Sagar Ghuge 8375609235 docs: Document INTEL_COPY_CLASS 
Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26409>
 2023-12-14 00:53:15 +00:00
Sagar Ghuge 135a7d5031 iris: Handle aux map init for copy engine 
We don't setup any state for the copy engine but platforms that supports
aux map, we need to init the aux map at context creation in order to
support compression.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9231

Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26409>
 2023-12-14 00:53:15 +00:00
Sagar Ghuge 46f5359238 anv: Invalidate aux map for copy/video engine 
Make sure to invalidate the aux map table for copy/video engines on
platforms that has the aux map.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9231

Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26409>
 2023-12-14 00:53:15 +00:00
Sagar Ghuge 108f880986 anv: Handle video/copy engine queue initialization 
We don't need to setup any state for video/copy usually but platform
that supports the aux map, we need to init the aux map by programming
equivalent registers.

Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26409>
 2023-12-14 00:53:15 +00:00
Sagar Ghuge 2aea09c8de intel/genxml: Add BCS/VD0 aux table base address register 
Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26409>
 2023-12-14 00:53:15 +00:00
Robert Foss e46e9ee46c egl/surfaceless: Don't overwrire disp->Device if using EGL_DEVICE_EXT 
Make sure that disp->Device is never overwritten during probe
function calls.

If EGL_DEVICE_EXT is provided, the probing should rather fail
than switch the device being used.

Signed-off-by: Robert Foss <rfoss@kernel.org>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26131>
 2023-12-13 23:15:17 +00:00
Robert Foss 208894c94f egl: Add _eglHasAttrib() function 
Provide a simple function for checking if an EGLDisplay
is using a specific EGLAttrib.

This can be useful when trying to inhibit platform behavior
depending on the EGLAttribs provided.

Signed-off-by: Robert Foss <rfoss@kernel.org>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26131>
 2023-12-13 23:15:17 +00:00
Robert Foss cda9980f96 egl/surfaceless: Fix EGL_DEVICE_EXT implementation 
The native_display checks are incorrect and partially never
executed due to native_display always being NULL.

Fixes: 1efaa85889 ("egl: Fix attrib_list[0] == EGL_NONE check")
Signed-off-by: Robert Foss <rfoss@kernel.org>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26131>
 2023-12-13 23:15:17 +00:00
Daniel Stone 59a7fc2054 ci/radeonsi: Occlusion queries are flaky on stoney 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26678>
 2023-12-13 22:51:52 +00:00
Eric Engestrom e46702f7ae ci: deduplicate constructing the ARTIFACTS_BASE_URL 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26670>
 2023-12-13 21:12:22 +00:00
Eric Engestrom d024da3900 docs: update calendar for 23.3.1 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26673>
 2023-12-13 21:03:25 +00:00
Eric Engestrom efa24268ce docs: add sha256sum for 23.3.1 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26673>
 2023-12-13 21:03:25 +00:00
Eric Engestrom d5bf161706 docs: add release notes for 23.3.1 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26673>
 2023-12-13 21:03:25 +00:00
Chris Spencer 342dba5102 vulkan/android: Only limit advertised extensions in strict mode 
Signed-off-by: Chris Spencer <spencercw@gmail.com>
Acked-by: Chia-I Wu <olvaffe@gmail.com>
Acked-by: Yiwei Zhang <zzyiwei@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25101>
 2023-12-13 20:09:37 +00:00
Chris Spencer 3c618d23d1 vn/android: Only limit advertised Vulkan version in strict mode 
Signed-off-by: Chris Spencer <spencercw@gmail.com>
Reviewed-by: Chia-I Wu <olvaffe@gmail.com>
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25101>
 2023-12-13 20:09:37 +00:00
Chris Spencer 30788edbcc v3dv/android: Only limit advertised Vulkan version in strict mode 
Signed-off-by: Chris Spencer <spencercw@gmail.com>
Acked-by: Chia-I Wu <olvaffe@gmail.com>
Acked-by: Yiwei Zhang <zzyiwei@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25101>
 2023-12-13 20:09:37 +00:00
Chris Spencer 9385f1d4e2 radv/android: Only limit advertised Vulkan version in strict mode 
Signed-off-by: Chris Spencer <spencercw@gmail.com>
Reviewed-by: Chia-I Wu <olvaffe@gmail.com>
Acked-by: Yiwei Zhang <zzyiwei@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25101>
 2023-12-13 20:09:37 +00:00
Chris Spencer ebc3032245 anv/android: Only limit advertised Vulkan version in strict mode 
Signed-off-by: Chris Spencer <spencercw@gmail.com>
Acked-by: Chia-I Wu <olvaffe@gmail.com>
Acked-by: Yiwei Zhang <zzyiwei@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25101>
 2023-12-13 20:09:37 +00:00
Chris Spencer 257ecaca88 android.mk: Add option to pass arbitrary parameters to meson 
Signed-off-by: Chris Spencer <spencercw@gmail.com>
Acked-by: Chia-I Wu <olvaffe@gmail.com>
Acked-by: Yiwei Zhang <zzyiwei@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25101>
 2023-12-13 20:09:37 +00:00
Chris Spencer 50458703fa meson: Add option to ignore artificial Android limitations 
Some capabilities are artificially disabled on Android to avoid running
afoul of the CTS. Make this behaviour opt-out so devices that don't need
strict conformance can take advantage of the full capabilities of the
driver.

Signed-off-by: Chris Spencer <spencercw@gmail.com>
Reviewed-by: Chia-I Wu <olvaffe@gmail.com>
Acked-by: Yiwei Zhang <zzyiwei@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25101>
 2023-12-13 20:09:37 +00:00
Caio Oliveira 6a4156f812 clover: Remove usage of glsl_type C++ helpers 
Preparation for removing the C++ helpers from glsl_type.

Reviewed-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26671>
 2023-12-13 19:52:24 +00:00
Sagar Ghuge a4947f7bd8 intel/fs: Adjust destination size for load ubo on Xe2+ 
Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26639>
 2023-12-13 19:06:21 +00:00
Sagar Ghuge e0ce94318b intel/fs: Adjust destination size for global load constant on Xe2+ 
Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26639>
 2023-12-13 19:06:21 +00:00
Sagar Ghuge 11fea46bdc intel/fs: Adjust destination size for image size intrinsic 
Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26639>
 2023-12-13 19:06:21 +00:00
Sagar Ghuge c426553658 intel/compiler: Adjust assertion in lower_get_buffer_size() for Xe2 
Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26639>
 2023-12-13 19:06:21 +00:00
Eric Engestrom f8e583d537 ci/b2c: identify dut by its id instead of its tags 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26653>
 2023-12-13 18:29:23 +00:00
Eric Engestrom b93d836e47 ci/b2c: rename B2C_TEST_SCRIPT to B2C_CONTAINER_CMD to match the automatic import 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26653>
 2023-12-13 18:29:23 +00:00
Eric Engestrom 4362d5913f ci/b2c: import all variables starting with B2C_ 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26653>
 2023-12-13 18:29:23 +00:00
Eric Engestrom ef0e8bae0d ci/b2c: use envvars directly instead of converting them back and forth into cli args 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26653>
 2023-12-13 18:29:23 +00:00
Eric Engestrom e157d67d39 ci/b2c: export B2C_TEST_SCRIPT 
Next commit will use it.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26653>
 2023-12-13 18:29:23 +00:00
Eric Engestrom b2e78a9775 ci/b2c: use with:write instead of manually doing open;write;close 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26653>
 2023-12-13 18:29:23 +00:00
Eric Engestrom 50da22812d ci/b2c: always define cmdline_extras 
Just make it an empty string when undefined

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26653>
 2023-12-13 18:29:23 +00:00
Eric Engestrom 86ee903b38 ci/b2c: always define job_volume_exclusions 
The template doesn't do anything if the list is empty, so simplify the code.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26653>
 2023-12-13 18:29:23 +00:00
Eric Engestrom 14f59188f6 ci/b2c: drop unused --volume and --mount-volume 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26653>
 2023-12-13 18:29:23 +00:00
Eric Engestrom 5142ae2d4f ci/b2c: drop support for harbor.freedesktop.org 
It's dead, Jim.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26653>
 2023-12-13 18:29:23 +00:00
Eric Engestrom 8eabe3d913 ci/b2c: tags are mandatory 
Jobs without tags are not accepted, so there is no point in having
support for creating them.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26653>
 2023-12-13 18:29:23 +00:00
Eric Engestrom 850d3e28e5 ci/b2c: drop unused B2C_EXTRA_VOLUME_ARGS 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26653>
 2023-12-13 18:29:23 +00:00
Eric Engestrom a10bd6fcb0 ci/b2c: fix indentation of comment and after_script: list 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26653>
 2023-12-13 18:29:23 +00:00
Eric Engestrom 918199a154 ci/b2c: stop ignoring errors in before_script 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26653>
 2023-12-13 18:29:23 +00:00
Eric Engestrom 6cc6ebde3a ci/b2c: drop passthrough of unset CI_JOB_JWT 
Fixes: dabc068e6c ("ci: Use ci-fairy minio login via token file")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26653>
 2023-12-13 18:29:23 +00:00
Lionel Landwerlin d761871761 isl: drop AUX-TT CCS alignment with INTEL_DEBUG=noccs 
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26644>
 2023-12-13 17:40:38 +00:00
Boris Brezillon db5166718d util/hash_table: Don't leak hash_key_u64 objects when the u64 hash table is destroyed 
Allocate a ralloc sub-context which takes the u64 hash table as a parent
and attach a destructor to it so we can free the hash_key_u64 objects
that were allocated by _mesa_hash_table_u64_insert().

The order of creation of this sub-context is crucial: it needs to happen
after the _mesa_hash_table_create() call to guarantee that the
destructor is called before ht->table and its children are freed,
otherwise the _mesa_hash_table_u64_clear() call in the destructor leads
to a use-after-free situation.

Fixes: ff494361be ("util: rzalloc and free hash_table_u64")
Cc: stable
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Yonggang Luo <luoyonggang@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26423>
 2023-12-13 17:02:02 +00:00
Boris Brezillon 5a60fd7b14 util/hash_table: Don't leak hash_u64_key objects when the entry exists 
When an entry exists, _mesa_hash_table_insert() updates the entry with
the new data/key pair, which causes a leak if the key has previously
been dynamically allocated, like is the case for hash_u64_key keys.

One solution to solve that is to do the insertion in two steps: first
_mesa_hash_table_search_pre_hashed(), and if the entry doesn't exist
_mesa_hash_table_insert_pre_hashed(). But approach forces us to do the
double-hashing twice.

Another approach is to extract the logic in hash_table_insert() that's
responsible for the searching and entry allocation into a separate helper
called hash_table_get_entry(), and keep the entry::{key,data} assignment
in hash_table_insert().

This way we can re-use hash_table_get_entry() from
_mesa_hash_table_u64_insert(), and lake sure we free the allocated
key if the entry was already present.

Fixes: 6649b840c3 ("mesa/util: add a hash table wrapper which support 64-bit keys")
Cc: stable
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Yonggang Luo <luoyonggang@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26423>
 2023-12-13 17:02:02 +00:00
Boris Brezillon 977cc3157d util/hash_table: Use FREE() to be consistent with the CALLOC_STRUCT() call 
CALLOC_STRUCT() calls the OS abstraction layer to do the allocation.
Call FREE() to free the corresponding objects so we keep things
consistent and have proper debug traces when memory-debugging
is enabled.

Fixes: 6649b840c3 ("mesa/util: add a hash table wrapper which support 64-bit keys")
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Yonggang Luo <luoyonggang@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26423>
 2023-12-13 17:02:02 +00:00