AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
166,862 Commits 1 Branch 0 Tags
3b037ac07361ec5c09e4ec3350840975ea5bf28a
Commit Graph

166862 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Lionel Landwerlin 3b037ac073 anv: fix vma heap memory leak 
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: a5f9e59ce3 ("anv: Use vma_heap for descriptor pool host allocation")
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21385>
 2023-02-17 21:37:34 +00:00
Eric Engestrom b772de9c78 ci: bump tags of deqp images 
Signed-off-by: Eric Engestrom <eric@engestrom.ch>
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21392>
 2023-02-17 20:17:08 +00:00
Eric Engestrom 61c2ae3d09 ci: fix grouping of image tags 
Signed-off-by: Eric Engestrom <eric@engestrom.ch>
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21392>
 2023-02-17 20:17:08 +00:00
Eric Engestrom 560ccdf05a ci: remove no-op sed 
This is a duplicate from the first patch applied above.

Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21392>
 2023-02-17 20:17:08 +00:00
Eric Engestrom 37a7f03ad8 ci: simplify adding & removing deqp patches 
Instead of everyone having to copy the curl command from somewhere else
when a new deqp version needs new patches; now all they need to do is
paste the commit hash in the array.

Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21392>
 2023-02-17 20:17:08 +00:00
Ryan Neph 525b8c582f venus: temporarily redirect VkDrmFormatModifierPropertiesListEXT to "2" variant 
Temporarily remove driver-side uses of
VkDrmFormatModifierPropertiesListEXT so the encode/decode procedures can
be fixed asynchronously in a follow-up.

Signed-off-by: Ryan Neph <ryanneph@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21367>
 2023-02-17 19:55:15 +00:00
Alyssa Rosenzweig e9bcfcf19c panfrost: Fix prim restart XML on Valhall 
Harmless in practice (so no need to backport) but still very wrong. Noticed
looking at traces of Dolphin trying to debug acute misrendering.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20780>
 2023-02-17 19:13:33 +00:00
Chia-I Wu 4459668b6e radv: add a size check in radv_create_buffer for Android 
This is to make dEQP-VK.api.buffer.basic.size_max_uint64 pass on
android.

The test creates a buffer of size UINT64_MAX and makes sure the memory
requirement for the buffer is sane.  It fails because our memory
requirement is "align64(UINT64_MAX, 16)" which is 0 after overflow.

The test checks maintenance4's maxBufferSize and is skipped normally.
But the extension can be disabled on an android build.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21346>
 2023-02-17 18:14:34 +00:00
Timur Kristóf e13074d763 radv: Call nir_lower_array_deref_of_vec in radv_lower_io_to_scalar_early. 
This fixes an issue when a vector component of an arrayed output has a deref.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8197
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21028>
 2023-02-17 17:47:47 +00:00
Konstantin Seurer c76060c253 radv: Advertise ray query support with LLVM 
What could go wrong?

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21268>
 2023-02-17 17:04:47 +00:00
Konstantin Seurer 3966fbdc51 radv: Pre-compile BVH build shaders if there is a cache 
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21268>
 2023-02-17 17:04:47 +00:00
Konstantin Seurer 40f246e3e9 radv: Force ACO for BVH build shaders 
They hang with LLVM.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21268>
 2023-02-17 17:04:47 +00:00
Konstantin Seurer 2ef5acedc2 radv: Make accel struct meta state initialization thread safe 
Fixes: 0d5570b ("radv: Always compile accel structure shaders on demand.")
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21268>
 2023-02-17 17:04:47 +00:00
Konstantin Seurer 0f709510f4 ac/llvm: Implement bvh64_intersect_ray_amd 
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21268>
 2023-02-17 17:04:47 +00:00
Mike Blumenkrantz a6d3d65c3c zink: handle semi-matching i/o for separate shaders 
while separate shaders requires i/o blocks to match between stages,
there are two tricky cases:
* sparse location specification
* variables are required to match in type by location

the first item means user locations must increment if a slot is not used

the second item means that e.g., a mat3x2 can match three vec2 variables
in matching slots

fix both of these cases now

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21383>
 2023-02-17 16:02:46 +00:00
Alyssa Rosenzweig fc30fe5bc5 panfrost: Disable CRC by default 
Known unsound code.

So far I'm not convinced transaction elimination is doing us much good. Even in
synthetic glmark style benchmarks this seems to be a few % hit at most. Given
that transaction elimination is unsound by design, and that panfrost's
implementation is buggy in several places and getting it right (up to the
unsoundness of the hardware feature itself) would take actual engineering
effort, and the priority is making glamor work... disabling is the obvious
choice here.

For now, we leave the code but gate it behind a env var
flag (PAN_MESA_DEBUG=crc) rather than defaulting to enabled unless
PAN_MESA_DEBUG=nocrc is set. This way, we can still experiment with it if we
need that data ("what performance could we gain if we had this feature,
unsoundness be damned?"). That said, I'm not really ok with having unsoundness
on my devices, y'know? Back of the napkin math suggests that it's not unlikely
that somebody has hit a transaction elimination collision in the wild with the
DDK.

Boils down to values.

Closes: #8113
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21258>
 2023-02-17 14:36:01 +00:00
Lionel Landwerlin 18bf85468c anv: track vram only BOs to print things out on ENOMEM execbuf 
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21380>
 2023-02-17 13:45:00 +00:00
Lionel Landwerlin 0aa44b107a anv: move debug submit to helper and call it on execbuf failure 
Helps telling when you've run out of local memory.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21380>
 2023-02-17 13:45:00 +00:00
Samuel Pitoiset c8495dbee3 radv: stop using a PS epilog when the FS doesn't write any color outputs 
This is a small optimization for fragment shaders that only write
depth/stencil/sample mask without any color outputs.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21341>
 2023-02-17 13:19:54 +00:00
Samuel Pitoiset 78c0fae08c radv: only skip emitting the pipeline blend state if the FS uses an epilog 
The blend state is emitted from the command buffer when the FS uses
an epilog (either compiled from a lib with GPL or compiled on-demand).

This shouldn't change anything but it will allow to disable using a
PS epilog when the fragment shader doesn't write any color outputs.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21341>
 2023-02-17 13:19:54 +00:00
Karmjit Mahil 5a5a131127 pvr: Handle VK_QUERY_RESULT_WAIT_BIT. 
Not handling device loss currently. That needs to be done
throughout the code base so out of scope for this.

Signed-off-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20091>
 2023-02-17 13:06:51 +00:00
Tapani Pälli d53613dbd7 anv: Wa_14016407139, add required pc when SBA programmed 
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21374>
 2023-02-17 12:44:00 +00:00
Lionel Landwerlin 14266d3c2d intel/perf: also add the oa timestamp shift on MTL 
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: 90c86fe63e ("intel: add MTL performance metrics")
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21378>
 2023-02-17 12:10:05 +00:00
Samuel Pitoiset 6d73841d34 radv/amdgpu: only set a new pstate if the current one is different 
AMDGPU pstate is per context but if there is multiple AMDGPU contexts
in flight, the kernel can return -EBUSY.

Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21222>
 2023-02-17 11:36:06 +00:00
Samuel Pitoiset 663877e894 Revert "radv: acquire pstate on-demand when capturing with RGP" 
This change is wrong for two reasons:
- it hangs most of the time maybe, because changing PSTATE when the
  application is running is broken somehow
- it increases the time between triggering and generating the capture
  considerably, because there is a delay for changing PSTATE

This restores previous logic where PSTATE is set to profile_peak at
logical device creation. Though, it also re-introduces an issue with
multiple logical devices (kernel returns -EBUSY) but this will be
fixed in the next commit.

This fixes GPU hangs when trying to record RGP captures on my NAVI21.
Note that profile_peak is only required for some RDNA2 chips (including
VanGogh).

Cc: mesa-stable
This reverts commit 923a864d94.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21222>
 2023-02-17 11:36:06 +00:00
Erico Nunes c426e5677f lima: don't use resource_from_handle while creating scanout 
resource_from_handle implementations create an additional reference to
the scanout resource, which caused lima to leak those resources after
commit ad4d7ca833.

Do as the other drivers do and import the bo directly while creating
the scanount resource.

Cc: 22.3 mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8198
Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21330>
 2023-02-17 10:36:46 +00:00
Karmjit Mahil 5277e45849 pvr: Add support to copy descriptors on vkUpdateDescriptorSets() 
Signed-off-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21332>
 2023-02-17 10:10:11 +00:00
Karmjit Mahil 30b7263419 pvr: Move descriptor write into pvr_write_descriptor_set() 
Moving descriptor write functionality from
pvr_UpdateDescriptorSets() into pvr_write_descriptor_set().

This is in preparation for adding descriptor copy support.

Signed-off-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21332>
 2023-02-17 10:10:11 +00:00
Boyuan Zhang c660cef599 virgl: add more formats to conv table 
Adding UYVY, YUYV, P010 to formats_conv_table.

Signed-off-by: Boyuan Zhang <boyuan.zhang@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21250>
 2023-02-17 09:23:27 +00:00
Gert Wollny 20584e04e3 r600/sfn: Fix Cayman trans from string and add test for copy prop 
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21357>
 2023-02-17 08:30:17 +00:00
Gert Wollny 4152e38924 r600/sfn: Fix alu trans op flag setup 
Fixes: commit 2df023a1f1
   r600/sfn: pre-evaluate allowed dest mask in Alu instructions

Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21357>
 2023-02-17 08:30:17 +00:00
Gert Wollny f07a2715c6 r600/sfn: Fix handling of fetch through texture clause 
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21357>
 2023-02-17 08:30:17 +00:00
Gert Wollny a99c08e181 r600: Don't start new CF for every fetch through tex clause 
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21357>
 2023-02-17 08:30:17 +00:00
Gert Wollny c44a9c8765 r600/sfn: Forward setting the block ID and index 
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21357>
 2023-02-17 08:30:17 +00:00
Gert Wollny 08ed216a11 r600/sfn: address use in group only if instr can be added 
Otherwise the group will signal an address use that may not
be relevant.

Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21357>
 2023-02-17 08:30:17 +00:00
Gert Wollny 560731279f r600/sfn: rename texture coordinate offset for clarity 
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21357>
 2023-02-17 08:30:17 +00:00
Gert Wollny 869e4de6af r600/sfn: Stop try scheduling in t-slot with empty related v-slot 
This requires adding a nop in the relates v-slot, and the readport
valiation seems to be broken for this case, so drop this for now.

Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21357>
 2023-02-17 08:30:17 +00:00
Gert Wollny b406cfd922 r600/sfn: Don't copy propagate indirect loads to more than one dest 
Propagating the indirect load to more instructions would result
in more address load instructions. This would (a) remove the advantage
of eliminating one move, and (b) introduce more latency, because between
address load and use two cycles must pass.

Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21357>
 2023-02-17 08:30:17 +00:00
Gert Wollny d1f419b365 r600/sfn: Silence warnings about unused parameters 
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21357>
 2023-02-17 08:30:17 +00:00
Gert Wollny c527293924 r600/sfn: Fix a typo 
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21357>
 2023-02-17 08:30:17 +00:00
Gert Wollny b1df8b0393 r600/sfn: drop useless instr use count 
This is handled with the dest registers

Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21357>
 2023-02-17 08:30:17 +00:00
Gert Wollny ac6b95d40b r600/sfn: Work around dependency issue when splitting op to group 
The instruction that is split may still be referenced as extra
dependency in other instructions, so add a handle to the instruction
that it can be set to be scheduled.

Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21357>
 2023-02-17 08:30:17 +00:00
Gert Wollny 8b5d41cacb r600/sfn: Use range_base for atomics and images 
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21357>
 2023-02-17 08:30:17 +00:00
Tapani Pälli ee7953ab97 mesa/st: support compute shader decoding of ASTC 
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19886>
 2023-02-17 07:57:12 +00:00
Tapani Pälli 977bc760fa mesa: add astc decoder shader template (glsl es version) 
This shader originates from Granite 3D engine and has been adapted
to be used with Open GL and some GLSL ES specifics.

GLSL ES adaptation:

- remove Vulkan specifics: EXT_samplerless_texture_functions usage,
  specialization constants, push constant usage
- inline bitextract.h
- always DECODE_8BIT and hardcode error color (for now)
- port to GLSL ES, required some type changes, explicit type
  conversions and setting up precisions for types

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19886>
 2023-02-17 07:57:12 +00:00
Tapani Pälli 179adf9d59 mesa/st: initialize resources for ASTC decoding 
Generates required resources for ASTC texture decoding pass.

Partition table resources will be cached in to hash during runtime
as one is required for each block size.

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19886>
 2023-02-17 07:57:12 +00:00
Tapani Pälli ad51f5bd13 mesa/st: add astc decoder lookup tables 
Commit introduces ASTC decoding lookup tables from Granite 3D engine.

These lookup tables will be used during transcoding by a compute
shader in later commits when decoding ASTC textures.

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19886>
 2023-02-17 07:57:12 +00:00
Samuel Pitoiset 685f08f91d radv: add support for rectangularLines 
dEQP-VK.*rectangular_line* pass on NAVI21.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21287>
 2023-02-17 07:38:10 +00:00
Samuel Pitoiset 3368c0e6f2 radv: reduce maximum line width to 8.0 
Using 8191.875 seems to big for the hardware to correctly render wide
rectangular lines. This can also be reproduced with AMDVLK by forcing
rectangularLines = True, and fixed by reducing the maximum size as well.

Other drivers seem to expose that value.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21287>
 2023-02-17 07:38:10 +00:00
Mike Blumenkrantz 65469eeca5 zink: more accurately handle i/o for separate shaders 
this can be simplified since i/o is required to match exactly between
stages, meaning that assigning in increasing order should always be correct

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21336>
 2023-02-17 04:30:04 +00:00