AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

panfrost: Fix prim restart XML on Valhall

Browse Source 
Harmless in practice (so no need to backport) but still very wrong. Noticed
looking at traces of Dolphin trying to debug acute misrendering.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20780>
This commit is contained in:
Alyssa Rosenzweig
2023-02-17 14:10:47 -05:00
committed by Marge Bot
parent 4459668b6e
commit e9bcfcf19c
2 changed files with 3 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/panfrost/lib/genxml/v10.xml
+2 -8
View File
@@ -915,12 +915,6 @@
<value name="FP32" value="3"/>
</enum>
<enum name="Primitive Restart">
<value name="None" value="0"/>
<value name="Implicit" value="2"/>
<value name="Explicit" value="3"/>
</enum>
<enum name="FIFO format">
<value name="Auto" value="0"/>
<value name="Basic" value="1"/>
@@ -937,7 +931,7 @@
<field name="Low Depth Cull" size="1" start="0:16" type="bool" default="true"/>
<field name="High Depth Cull" size="1" start="0:17" type="bool" default="true"/>
<field name="Secondary Shader" size="1" start="0:18" type="bool"/>
<field name="Primitive restart" size="2" start="0:19" type="Primitive Restart"/>
<field name="Primitive restart" size="1" start="0:19" type="bool"/>
<field name="Layer index enable" size="1" start="0:20" type="bool"/>
<field name="Scissor array enable" size="1" start="0:21" type="bool"/>
<field name="Position FIFO format" size="2" start="0:22" type="FIFO format"/>
@@ -954,7 +948,7 @@
<field name="Low Depth Cull" size="1" start="0:16" type="bool" default="true"/>
<field name="High Depth Cull" size="1" start="0:17" type="bool" default="true"/>
<field name="Secondary Shader" size="1" start="0:18" type="bool"/>
<field name="Primitive restart" size="2" start="0:19" type="Primitive Restart"/>
<field name="Primitive restart" size="1" start="0:19" type="bool"/>
<field name="Layer index enable" size="1" start="0:20" type="bool"/>
<field name="Scissor array enable" size="1" start="0:21" type="bool"/>
src/panfrost/lib/genxml/v9.xml
+1 -7
View File
@@ -599,12 +599,6 @@
<value name="FP32" value="3"/>
</enum>
<enum name="Primitive Restart">
<value name="None" value="0"/>
<value name="Implicit" value="2"/>
<value name="Explicit" value="3"/>
</enum>
<struct name="Primitive">
<field name="Draw mode" size="8" start="0:0" type="Draw Mode" default="None"/>
<field name="Index type" size="3" start="0:8" type="Index Type" default="None"/>
@@ -615,7 +609,7 @@
<field name="Low Depth Cull" size="1" start="0:16" type="bool" default="true"/>
<field name="High Depth Cull" size="1" start="0:17" type="bool" default="true"/>
<field name="Secondary Shader" size="1" start="0:18" type="bool"/>
<field name="Primitive restart" size="2" start="0:19" type="Primitive Restart"/>
<field name="Primitive restart" size="1" start="0:19" type="bool"/>
<field name="Layer index enable" size="1" start="0:20" type="bool"/>
<field name="Scissor array enable" size="1" start="0:21" type="bool"/>