Commit Graph

189008 Commits

Author SHA1 Message Date
Caio Oliveira
3a081106b0 intel/brw: Hide register pressure information in dumps
It was the default to show register pressure for each instruction,
but it gets in the way of cleaner diffs before/after an optimization pass.
Add INTEL_DEBUG=reg-pressure option to show it again.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29114>
2024-05-11 02:17:56 +00:00
Caio Oliveira
866b1245e9 intel/brw: Don't print IP as part of the dump
The sequential IP cause noise when diffing before/after a pass that
either add or remove instructions.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29114>
2024-05-11 02:17:56 +00:00
Lionel Landwerlin
fd47f90d37 brw: drop dependency on libintel_common
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11136
Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29128>
2024-05-11 01:52:01 +00:00
Lionel Landwerlin
36c043e2eb intel: move debug identifier out of libintel_dev
The debug identifier is put into the captured buffers for error
capture. This helps us figure out what version of the driver people
are running when encountering a GPU hang. This identifier has the
git-sha1 + driver name.

libintel_dev is also a dependency of the compiler so any change to the
git-sha1 also triggers recompile which we want to avoid.

This changes moves the debug identifier to src/intel/common which
drivers already depend on, so the compiler is not affected anymore.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11136
Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29128>
2024-05-11 01:52:01 +00:00
Mike Blumenkrantz
4882f49e6b zink: don't submit main cmdbuf if has_work is not set
this should avoid submitting empty cmdbufs

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29108>
2024-05-11 01:29:44 +00:00
Mike Blumenkrantz
0a24b8f9a3 zink: stop flagging has_work on batch tracking
this used to be a lazy workaround, but now it can actually mean something

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29108>
2024-05-11 01:29:44 +00:00
Mike Blumenkrantz
74f572b28f zink: flag has_work in a few more places
it's unlikely that any of these would be hit without first triggering
a has_work elsewhere, but this makes it more obvious

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29108>
2024-05-11 01:29:44 +00:00
Mike Blumenkrantz
8f687f2a46 zink: rely on zink_get_cmdbuf() to set has_work flags
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29108>
2024-05-11 01:29:44 +00:00
Mike Blumenkrantz
b9ec12d439 zink: check all has_work flags for flushes
not sure this actually changes anything right now

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29108>
2024-05-11 01:29:44 +00:00
Mike Blumenkrantz
06abe4399d zink: reset all the has_work flags in the same place
no functional changes

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29108>
2024-05-11 01:29:44 +00:00
Mike Blumenkrantz
e4c516bece zink: zink_batch_state::has_barriers -> has_reordered_work
and add a note

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29108>
2024-05-11 01:29:44 +00:00
Mike Blumenkrantz
ac07fefdda zink: delete zink_batch
this makes the code a bit more ergonomic

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29108>
2024-05-11 01:29:44 +00:00
Mike Blumenkrantz
40f595b30c zink: remove all zink_batch usage from zink_context.c
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29108>
2024-05-11 01:29:44 +00:00
Mike Blumenkrantz
91969dfa5a zink: remove all zink_batch usage from zink_render_pass.c
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29108>
2024-05-11 01:29:44 +00:00
Mike Blumenkrantz
05ba13ed18 zink: remove all zink_batch usage from zink_draw.cpp
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29108>
2024-05-11 01:29:44 +00:00
Mike Blumenkrantz
bdb4860c10 zink: remove all zink_batch usage from zink_resource.h
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29108>
2024-05-11 01:29:44 +00:00
Mike Blumenkrantz
0d8d90d577 zink: remove all uses of zink_batch from zink_batch.c
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29108>
2024-05-11 01:29:44 +00:00
Mike Blumenkrantz
4adfb03f5b zink: remove zink_batch usage from zink_clear.c
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29108>
2024-05-11 01:29:44 +00:00
Mike Blumenkrantz
efa8ce29a4 zink: delete all zink_batch uses from zink_query.c
no functional changes

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29108>
2024-05-11 01:29:44 +00:00
Mike Blumenkrantz
e27018dc79 zink: rename zink_batch::state -> zink_batch::bs
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29108>
2024-05-11 01:29:44 +00:00
Mike Blumenkrantz
107bf9ec7c zink: move swapchain from zink_batch to zink_context
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29108>
2024-05-11 01:29:44 +00:00
Mike Blumenkrantz
2837cf9dde zink: move work_count from zink_batch to zink_context
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29108>
2024-05-11 01:29:44 +00:00
Mike Blumenkrantz
8eacafaccc zink: move last_work_was_compute from zink_batch to zink_context
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29108>
2024-05-11 01:29:44 +00:00
Mike Blumenkrantz
fb6828a9a1 zink: rename last_was_compute -> last_work_was_compute
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29108>
2024-05-11 01:29:44 +00:00
Mike Blumenkrantz
d157b89bee zink: move has_work from zink_batch to zink_batch_state
no functional state

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29108>
2024-05-11 01:29:44 +00:00
Mike Blumenkrantz
c8026f01bc zink: move ref_lock from zink_batch to zink_batch_state
no functional changes

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29108>
2024-05-11 01:29:44 +00:00
Mike Blumenkrantz
f8876a0533 zink: move in_rp to zink_context
no functional changes

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29108>
2024-05-11 01:29:44 +00:00
Mike Blumenkrantz
c85fc875d9 zink: delete unused zink_batch struct member
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29108>
2024-05-11 01:29:44 +00:00
Mike Blumenkrantz
ae8fbe220a freedreno/replay: use inttypes format string for 64bit
cc: mesa-stable

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29142>
2024-05-11 01:09:25 +00:00
Eric Engestrom
654ef35635 zink: avoid designated initializers as they are not supported in C++ < 20
error C7555: use of designated initializers requires at least '/std:c++20'

Fixes: 7bdaf6e95f ("zink: use zink_shader_key_optimal unions for pipeline state asserts")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29139>
2024-05-11 00:08:47 +00:00
Eric Engestrom
320c0b44f4 radv/ci: add navi21 flakes
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29141>
2024-05-10 22:52:35 +00:00
Eric Engestrom
32f2b5d245 llvmpipe: wrap the push/pull in the ifdef as well
Fixes: c7634c25e4 ("llvmpipe: Fix build error with clang-18")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29138>
2024-05-10 21:14:08 +00:00
Eric Engestrom
860b262f44 microsoft/clc: fix incorrect changes that got through while the Windows CI was down
Fixes: e80d52223e ("microsoft: Use spirv_capabilities for spirv_to_dxil")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29137>
2024-05-10 20:52:21 +00:00
José Expósito
18c5315731 meson: Update proc_macro2 meson.build patch
Update the proc-macro2/meson.build to include the changes from v1.0.81.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11071
Signed-off-by: José Expósito <jexposit@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28923>
2024-05-10 20:07:01 +00:00
Lionel Landwerlin
d1c01e256d brw: add more condition for reducing sampler simdness
Running
KHR-GL46.sparse_texture_clamp_tests.SparseTextureClampLookupColor test
with Zink on Anv we run into an assert :

assert(inst->mlen <= MAX_SAMPLER_MESSAGE_SIZE * reg_unit(devinfo));

Turns out we've not covered all the cases in the SIMD lowering.

It's a bit of a shame to have both files reproduce the same logic.
Will try to think of a better way to extract the layout of the a send
message but that'll be a much bigger rework.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: mesa-stable
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29118>
2024-05-10 19:40:00 +00:00
Alyssa Rosenzweig
e0aa70bd55 dzn: use common stype debug
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29009>
2024-05-10 18:49:38 +00:00
Alyssa Rosenzweig
90866bc58c anv,hasvk: use common stype debug
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29009>
2024-05-10 18:49:38 +00:00
Alyssa Rosenzweig
4c7c80e047 pvr: use common stype debug
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29009>
2024-05-10 18:49:38 +00:00
Alyssa Rosenzweig
edac80d8a7 broadcom: use common stype debug
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29009>
2024-05-10 18:49:38 +00:00
Alyssa Rosenzweig
cd6dfd6c2d nvk: use common stype debug
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29009>
2024-05-10 18:49:38 +00:00
Alyssa Rosenzweig
9d34c0f705 vulkan: add vk_debug_ignored_stype helper
from nvk.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29009>
2024-05-10 18:49:38 +00:00
Alyssa Rosenzweig
9d5f15abb0 docs: add header-stub for vk_enum_to_str
Suppresses fail from test-docs-mr. from the next commit.

Trivial.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29009>
2024-05-10 18:49:38 +00:00
Alyssa Rosenzweig
3ccf7208a2 nir/lower_robust_access: also handle image derefs
for unlowered image intrinsics

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28681>
2024-05-10 17:49:13 +00:00
Alyssa Rosenzweig
fb187c9c89 nir/lower_subgroups: relax ballot_type_to_uint
we can generate 32-bit scalar inverse_ballots from the boolean reduce lowering
which will blow up when trying to lower the resulting inverse_ballot with the
common lowering. but the assert can be quieted just fine.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28993>
2024-05-10 17:00:54 +00:00
Alyssa Rosenzweig
b9a0c8dc6d nir/lower_subgroups: add generic scan/reduce lower
this is the lowering from NAK, fixed up for common code. the existing code is
used for boolean scan/reduce. I make no guarantee that this works for subgroup
sizes other than 32.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28993>
2024-05-10 17:00:54 +00:00
Alyssa Rosenzweig
8b070c36ec nir/lower_subgroups: add filter
this will be useful for AGX, which has many reductions (but not all) in
hardware with the logic too backend-specific to encode with bitflags.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28993>
2024-05-10 17:00:54 +00:00
Juan A. Suarez Romero
3990463c48 v3d/vc4/ci: set full renderer version check
Include the full expected renderer name, with the version.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27449>
2024-05-10 15:00:44 +00:00
Eric Engestrom
c0e6a72b00 rpi5/ci: use deqp-runner suite for vk job
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27449>
2024-05-10 15:00:44 +00:00
Eric Engestrom
993dd0832f rpi4/ci: use deqp-runner suite for vk job as well
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27449>
2024-05-10 15:00:44 +00:00
Luc Ma
3825e24085 loader: silence implicit-load zink error by the loader
Since commit 7d9ea77b45 ("glx: add automatic zink fallback loading between hw
and sw drivers"), zink could be tried as a fallback. It'd better silence
if the zink loading is implicit and on fail as what commit 4cc975c6e9 ("glx: silence
more implicit-load zink errors") has done. But there seems to be one
left bebind, which is spit when building swrast but no zink with -Dglx=dri.

v2: plumb the flag through from egl/glx to the loader (zmike)

Signed-off-by: Luc Ma <luc@sietium.com>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28970>
2024-05-10 14:19:59 +00:00