1668feefb4
ci: Make it possible to use ANGLE traces on other architectures
...
Don't hardcode amd64 architecture, use PIGLIT_REPLAY_ANGLE_ARCH to make
it easier to opt in for ANGLE traces on arm64 in the future.
Signed-off-by: Valentine Burley <valentine.burley@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34308 >
2025-04-05 09:13:53 +02:00
3041440bcb
zink+tu/ci: update expectations
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34386 >
2025-04-04 23:49:23 +00:00
d49b38059f
zink+radv/ci: update expectations
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34386 >
2025-04-04 23:49:23 +00:00
e3a5a181a1
zink+nvk/ci: update expectations
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34386 >
2025-04-04 23:49:23 +00:00
ecaa3392d3
lvp/ci: update expectations
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34386 >
2025-04-04 23:49:23 +00:00
d1922ef7ea
nvk/ci: update expectations
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34386 >
2025-04-04 23:49:23 +00:00
90844640a1
freedreno/ci: update expectations
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34386 >
2025-04-04 23:49:23 +00:00
e65d0d2250
radv/ci: update expectations
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34386 >
2025-04-04 23:49:23 +00:00
6a86683ef8
radeonsi/ci: update expectations
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34386 >
2025-04-04 23:49:23 +00:00
7ae638c0fe
brw: Add brw_builder::uniform()
...
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34355 >
2025-04-04 23:07:21 +00:00
f33d93da11
brw: Remove HSW specific code from brw_compile_cs.cpp
...
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34355 >
2025-04-04 23:07:21 +00:00
536b2b13c8
tu: Implement VK_EXT_fragment_density_map_offset
...
Implement support for dynamic rendering, including suspending and
resuming render passes.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34159 >
2025-04-04 22:35:20 +00:00
f5ac3c452d
vk/runtime: Add common CmdEndRendering
...
Similar to the common CmdEndRenderPass, add a default implementation for
drivers that implement VK_EXT_fragment_density_map_offset.
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34159 >
2025-04-04 22:35:19 +00:00
4947436da7
vk/runtime: Use vk_command_buffer in renderpass wrappers
...
The comment is out of date, and all drivers using the runtime use
vk_command_buffer. Let's use it directly.
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34159 >
2025-04-04 22:35:19 +00:00
8f90b10b63
intel/tools: Improve memory allocation failure handling in aubinator_error_decode_xe
...
Ensure proper cleanup when memory allocation fails during HWCTX and VMA
parsing in `read_xe_data_file`. This ensures graceful error handling by
preventing potential memory leaks.
Reviewed-by: José Roberto de Souza <jose.souza@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34371 >
2025-04-04 22:09:27 +00:00
9ddc160012
meson: Sync subproject version numbers in packagefiles with their .wrap equivalents
...
These tell meson which version the `.wrap` file downloads and should therefore always stay in sync.
No dependency is actually being updated here.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34368 >
2025-04-04 21:22:27 +00:00
83bf45b0ce
meson: Update pest subproject family
...
Starting with Rust 1.83 this benign warning is show when compiling the pest dependency:
```
warning: elided lifetime has a name
--> pest/src/iterators/pairs.rs:330:70
|
89 | impl<'i, R: RuleType> Pairs<'i, R> {
| -- lifetime `'i` declared here
...
330 | ) -> Filter<FlatPairs<'i, R>, impl FnMut(&Pair<'i, R>) -> bool + '_> {
| ^^ this elided lifetime gets resolved as `'i`
|
= note: `#[warn(elided_named_lifetimes)]` on by default
```
Meson, at least as of version 1.7.0, unfortunately does not suppress warnings originating in dependencies.
Upstream has resolved the warning in 2.8.0, so update to that.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34368 >
2025-04-04 21:22:27 +00:00
03aca2d248
brw: Use new bld/exp style in scoreboard tests
...
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34354 >
2025-04-04 20:14:53 +00:00
7ee673c195
brw: Add parser of SWSB annotations to use in tests
...
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34354 >
2025-04-04 20:14:53 +00:00
81dd3e1527
brw: Return actual progress in brw_lower_scoreboard
...
This will be useful later for tests to be used in conjunction with the
EXPECT_PROGRESS / EXPECT_NO_PROGRESS helpers.
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34354 >
2025-04-04 20:14:53 +00:00
3e727000dd
brw: Stop setting SFID in scoreboard tests
...
They won't affect the scoreboard, and will get in the
way of a later change.
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34354 >
2025-04-04 20:14:53 +00:00
bcea076aca
brw: Use SIMD16 shaders in scoreboard tests for Xe2+
...
Some tests changed to avoid unintended overlap between operands which
would change the SWSB assigned. In some cases also changed the Gfx12
matching test so they remain equal.
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34354 >
2025-04-04 20:14:52 +00:00
cd486cda48
brw: Use control flow helpers in scoreboard tests
...
Also update WHILE to optionally take a predicate (default to NONE). And
make the predicate in the IF optional (default to NORMAL).
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34354 >
2025-04-04 20:14:52 +00:00
7c5389695b
ci/fluster: don't overwrite FLUSTER_VECTORS_HOST_PATH to a different meaning
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34362 >
2025-04-04 19:36:09 +00:00
8ec11893d9
ci/fluster: use http proxy when checking for the vector files
...
It's done properly when downloading it, but not when checking for it.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34362 >
2025-04-04 19:36:09 +00:00
e7a44de184
nir/tests: Do not rely on __LINE__
...
__LINE__ can be inconsistent when using different compilers. This patch
changes the test runner to do a simple string find/replace of the test
source file instead of looking for the line where the reference string
starts.
Acked-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33980 >
2025-04-04 19:01:01 +00:00
c496774c35
freedreno/a6xx: Implement ARB_shader_clock
...
Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29860 >
2025-04-04 18:22:49 +00:00
0e9854a894
tu: Implement VK_KHR_shader_clock
...
There is a special address defined in kernel from which ALWAYSON
counter could be read.
Blob uses this sequence to read it:
getone #l15
mov.s32s32 r2.y, -4096
mov.s32s32 r2.z, 131071
(rpt5)nop
ldg.u32 r2.w, g[r2.y], 1
ldg.u32 r2.y, g[r2.y+4], 1
(sy)(ss)mov.s32s32 r48.x, (last)r2.w
mov.s32s32 r48.y, (last)r2.y
l15:
Passes:
dEQP-VK.glsl.shader_clock.*
Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29860 >
2025-04-04 18:22:49 +00:00
4b1b4ee10c
freedreno,tu: Read and pass to compiler uche_trap_base
...
KGSL always exposed uche_trap_base, and MSM only recently
got support for it.
Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29860 >
2025-04-04 18:22:49 +00:00
6a448ca08b
freedreno: Bump kernel uapi (linux 6.14)
...
Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29860 >
2025-04-04 18:22:48 +00:00
0941af995a
lavapipe: Don't advertise support for multiplane drm formats
...
Fixes: bd4f69a0feotte@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34190 >
2025-04-04 17:59:43 +00:00
8b76f521a0
meson: Bump minimum version to 1.3.0
...
Builds currently fail on older versions since the commit
below.
Fixes: f35172b6a4robert.mader@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34313 >
2025-04-04 17:15:34 +00:00
e4359cc49c
tu/kgsl: Fix KGSL syncobj lifetime in no CB submit
...
The temporary syncobj created in the fast path of kgsl_queue_submit was
not being destroyed, and potentially being assigned to multiple syncobjs
without being properly duplicated. This could lead to a use-after-free
or double-free since multiple syncobjs could be assigned the same FD.
Signed-off-by: Mark Collins <mark@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34328 >
2025-04-04 16:54:17 +00:00
cf4bd2e412
tu/kgsl: Revert "Remove zero CB queue submission fast path"
...
This reverts commit 0342d34bdbmark@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34328 >
2025-04-04 16:54:17 +00:00
c70dcd1451
aco/gfx9+: use d16 global/scratch/buffer loads
...
Full register loads are not nessecary and prevent packing optimizations.
Global/Scratch is GFX9+ so D16 loads are always supported.
We already used LDS D16 loads.
Foz-DB Navi31(mostly RA noise):
Totals from 716 (0.90% of 79789) affected shaders:
Instrs: 3854176 -> 3854238 (+0.00%); split: -0.00%, +0.00%
CodeSize: 20034440 -> 20035220 (+0.00%); split: -0.00%, +0.00%
Latency: 24410951 -> 24411120 (+0.00%)
InvThroughput: 5181276 -> 5181301 (+0.00%)
Copies: 320258 -> 320317 (+0.02%)
VALU: 2207307 -> 2207366 (+0.00%)
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34346 >
2025-04-04 16:20:39 +00:00
f5e36e382f
broadcom/compiler: initialize register
...
This fixes issue detected by static analyzer: passed-by-value struct
argument contains uninitialized data (e.g., field: 'file').
Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com >
Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com >
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34050 >
2025-04-04 15:55:13 +00:00
0e50b09d4a
broadcom/compiler: don't use VLA on emit alu
...
Using constant-size array instead of variable-length array is preferred
due several issues with the latter.
Particularly, for this case using VLA generates several warnings by
static analyzer: passed-by-value struct argument contains uninitialized
data (e.g., field: 'file').
Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com >
Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com >
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34050 >
2025-04-04 15:55:13 +00:00
01151f045f
broadcom/compiler: use safe iterator to remove instructions
...
The current approach has an issue detected by static analyzer: use of
memory after it is freed.
Using a proper iterator makes things safer.
Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com >
Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com >
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34050 >
2025-04-04 15:55:13 +00:00
0b0d6a36f2
vc4: use safe iterator to remove instructions
...
The current approach has an issue detected by static analyzer: use of
memory after it is freed.
Using a proper iterator makes things safer.
Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com >
Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com >
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34050 >
2025-04-04 15:55:13 +00:00
baa4fefe74
broadcom/cle: assert attribute has a value
...
This assertions helps to fix several warnings detected by static
analyzer regarding passing null pointers to functions that expects
non-null pointer.
Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com >
Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com >
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34050 >
2025-04-04 15:55:13 +00:00
47f280778e
vc4: assert there are sources when emitting texture
...
This assertion fixes an issue detected by static analyzer:
passed-by-value struct argument contains uninitialized data (e.g.,
field: 'file').
Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com >
Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com >
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34050 >
2025-04-04 15:55:13 +00:00
8f5423820a
vc4: add assertion on constant_fold
...
This fixes an issue detected by static analyzer: the right operand of
'>>' is a garbage value due to array index out of bounds.
Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com >
Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com >
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34050 >
2025-04-04 15:55:13 +00:00
54db7c46fa
vc4: initialize register
...
While this is likely not necessary, it fixes an issue detected by static
analyzer: the left operand of '<=' is a garbage value.
Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com >
Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com >
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34050 >
2025-04-04 15:55:12 +00:00
6d6a3ab679
v3dv: asserts push constants data is valid
...
When pushing constants.
This fixes an issue detected by static analyzer: null pointer passed to
1st parameter expecting 'nonnull'.
Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com >
Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com >
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34050 >
2025-04-04 15:55:12 +00:00
665df034e7
v3dv: check dynamic offset output
...
The output variable must be non NULL when descriptor type is dynamic.
This fixes an issue detected by static analyzer: dereference of null
pointer (loaded from variable 'dynamic_offset').
Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com >
Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com >
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34050 >
2025-04-04 15:55:12 +00:00
ede3feb16d
v3dv: asserts struct is always non null
...
This fixes an issue detected by static analyzer: access to field 'pNext'
results in a dereference of a null pointer (loaded from variable
'rs_info').
Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com >
Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com >
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34050 >
2025-04-04 15:55:12 +00:00
2c8411e9d2
vc4: check instruction before setting flags
...
This fixes an issue detected by static analyzer: access to field 'sf'
results in a dereference of a null pointer (loaded from variable
'last_inst').
Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com >
Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com >
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34050 >
2025-04-04 15:55:12 +00:00
72bc74f0be
anv: add shader-hash debug option
...
Emits a dummy MI_STORE_DATA_IMM with the shader hash in front of :
- 3DSTATE_VS
- 3DSTATE_HS
- 3DSTATE_DS
- 3DSTATE_HS
- 3DSTATE_PS
- COMPUTE_WALKER / GPGPU_WALKER
Example :
0x00000000: 0x10000002: MI_STORE_DATA_IMM
0x00000000: 0x10000002 : Dword 0
DWord Length: 2
Force Write Completion Check : false
Store Qword: 0
Use Global GTT: false
0x00000004: 0xffffe0c0 : Dword 1
Core Mode Enable: 0
0x00000008: 0x0000effe : Dword 2
Address: 0xeffeffffe0c0
0x0000000c: 0x126e815a : Dword 3 <------------ shader hash
0x00000010: 0x78100007 : Dword 4
Immediate Data: 309231962
0x00000000: 0x78100007: 3DSTATE_VS
0x00000000: 0x78100007 : Dword 0
DWord Length: 7
0x00000004: 0x00000000 : Dword 1
0x00000008: 0x00000000 : Dword 2
Kernel Start Pointer: 0x00000000
0x0000000c: 0x00040000 : Dword 3
Software Exception Enable: false
Accesses UAV: false
It'll correlate with the value emitted in the pipeline stats from fossil replay :
$ grep -i 126e815a /tmp/stats.csv
fossilize.aab93c5c3f965151.1.foz,GRAPHICS,de1b925dec8a8083,507378,498283,303434,vertex,8,50,4,0,1826,0,0,0,8,17,0,0x00000000126e815a,15
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com >
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34332 >
2025-04-04 15:18:28 +00:00
789f13359a
anv: consolidate environment variables
...
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com >
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34332 >
2025-04-04 15:18:28 +00:00
713cb0fdc1
anv/hasvk: sort out debug options
...
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com >
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34332 >
2025-04-04 15:18:28 +00:00
Valentine Burley