AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

radv: pre-compute VGT_TF_PARAM.DISTRIBUTION_MODE

Browse Source 
For less CPU overhead.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28965>
This commit is contained in:
Samuel Pitoiset
2024-04-29 08:55:06 +02:00
committed by Marge Bot
parent d7679c0370
commit be98fe2724
3 changed files with 13 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/amd/vulkan/radv_cmd_buffer.c
View File

@@ -4170,7 +4170,7 @@ radv_emit_tess_domain_origin(struct radv_cmd_buffer *cmd_buffer)
const struct radv_physical_device *pdev = radv_device_physical(device);
const struct radv_shader *tes = radv_get_shader(cmd_buffer->state.shaders, MESA_SHADER_TESS_EVAL);
const struct radv_dynamic_state *d = &cmd_buffer->state.dynamic;
unsigned type = 0, partitioning = 0, distribution_mode = 0;
unsigned type = 0, partitioning = 0;
unsigned topology;
switch (tes->info.tes._primitive_mode) {
@@ -4201,15 +4201,6 @@ radv_emit_tess_domain_origin(struct radv_cmd_buffer *cmd_buffer)
unreachable("Invalid tess spacing type");
}
if (pdev->info.has_distributed_tess) {
if (pdev->info.family == CHIP_FIJI || pdev->info.family >= CHIP_POLARIS10)
distribution_mode = V_028B6C_TRAPEZOIDS;
else
distribution_mode = V_028B6C_DONUTS;
} else {
distribution_mode = V_028B6C_NO_DIST;
}
if (tes->info.tes.point_mode) {
topology = V_028B6C_OUTPUT_POINT;
} else if (tes->info.tes._primitive_mode == TESS_PRIMITIVE_ISOLINES) {
@@ -4226,7 +4217,7 @@ radv_emit_tess_domain_origin(struct radv_cmd_buffer *cmd_buffer)
radeon_set_context_reg(cmd_buffer->cs, R_028B6C_VGT_TF_PARAM,
S_028B6C_TYPE(type) | S_028B6C_PARTITIONING(partitioning) | S_028B6C_TOPOLOGY(topology) |
S_028B6C_DISTRIBUTION_MODE(distribution_mode));
S_028B6C_DISTRIBUTION_MODE(pdev->tess_distribution_mode));
}
static void

9
src/amd/vulkan/radv_physical_device.c
View File

@@ -2167,6 +2167,15 @@ radv_physical_device_try_create(struct radv_instance *instance, drmDevicePtr drm
ac_get_task_info(&pdev->info, &pdev->task_info);
radv_get_binning_settings(pdev, &pdev->binning_settings);
if (pdev->info.has_distributed_tess) {
if (pdev->info.family == CHIP_FIJI || pdev->info.family >= CHIP_POLARIS10)
pdev->tess_distribution_mode = V_028B6C_TRAPEZOIDS;
else
pdev->tess_distribution_mode = V_028B6C_DONUTS;
} else {
pdev->tess_distribution_mode = V_028B6C_NO_DIST;
}
*pdev_out = pdev;
return VK_SUCCESS;

2
src/amd/vulkan/radv_physical_device.h
View File

@@ -184,6 +184,8 @@ struct radv_physical_device {
bool video_encode_enabled;
struct radv_physical_device_cache_key cache_key;
uint32_t tess_distribution_mode;
};
VK_DEFINE_HANDLE_CASTS(radv_physical_device, vk.base, VkPhysicalDevice, VK_OBJECT_TYPE_PHYSICAL_DEVICE)