AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

anv/brw: move INTEL_MSAA_* flag computation to the compiler

Browse Source 
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33751>
This commit is contained in:
Lionel Landwerlin
2025-01-23 14:57:26 +02:00
committed by Marge Bot
parent beaba53010
commit 93a327c4e6
2 changed files with 50 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/intel/compiler/intel_shader_enums.h
+41
View File
@@ -341,6 +341,47 @@ intel_fs_is_coarse(enum intel_sometimes shader_coarse_pixel_dispatch,
return (pushed_msaa_flags & INTEL_MSAA_FLAG_COARSE_RT_WRITES) != 0;
}
struct intel_fs_params {
bool shader_sample_shading;
float shader_min_sample_shading;
bool state_sample_shading;
uint32_t rasterization_samples;
bool coarse_pixel;
bool alpha_to_coverage;
};
static inline enum intel_msaa_flags
intel_fs_msaa_flags(struct intel_fs_params params)
{
enum intel_msaa_flags fs_msaa_flags = INTEL_MSAA_FLAG_ENABLE_DYNAMIC;
if (params.rasterization_samples > 1) {
fs_msaa_flags |= INTEL_MSAA_FLAG_MULTISAMPLE_FBO;
if (params.shader_sample_shading)
fs_msaa_flags |= INTEL_MSAA_FLAG_PERSAMPLE_DISPATCH;
if (params.shader_sample_shading ||
(params.state_sample_shading &&
(params.shader_min_sample_shading *
params.rasterization_samples) > 1)) {
fs_msaa_flags |= INTEL_MSAA_FLAG_PERSAMPLE_DISPATCH |
INTEL_MSAA_FLAG_PERSAMPLE_INTERP;
}
}
if (!(fs_msaa_flags & INTEL_MSAA_FLAG_PERSAMPLE_DISPATCH) &&
params.coarse_pixel) {
fs_msaa_flags |= INTEL_MSAA_FLAG_COARSE_PI_MSG |
INTEL_MSAA_FLAG_COARSE_RT_WRITES;
}
if (params.alpha_to_coverage)
fs_msaa_flags |= INTEL_MSAA_FLAG_ALPHA_TO_COVERAGE;
return fs_msaa_flags;
}
#ifdef __cplusplus
} /* extern "C" */
#endif
src/intel/vulkan/genX_gfx_state.c
+9 -25
View File
@@ -712,31 +712,15 @@ update_fs_msaa_flags(struct anv_gfx_dynamic_state *hw_state,
wm_prog_data->alpha_to_coverage != INTEL_SOMETIMES)
return;
enum intel_msaa_flags fs_msaa_flags = INTEL_MSAA_FLAG_ENABLE_DYNAMIC;
if (dyn->ms.rasterization_samples > 1) {
fs_msaa_flags |= INTEL_MSAA_FLAG_MULTISAMPLE_FBO;
if (wm_prog_data->sample_shading) {
assert(wm_prog_data->persample_dispatch != INTEL_NEVER);
fs_msaa_flags |= INTEL_MSAA_FLAG_PERSAMPLE_DISPATCH;
}
if ((pipeline->sample_shading_enable &&
(pipeline->min_sample_shading * dyn->ms.rasterization_samples) > 1) ||
wm_prog_data->sample_shading) {
fs_msaa_flags |= INTEL_MSAA_FLAG_PERSAMPLE_DISPATCH |
INTEL_MSAA_FLAG_PERSAMPLE_INTERP;
}
}
if (wm_prog_data->coarse_pixel_dispatch == INTEL_SOMETIMES &&
!(fs_msaa_flags & INTEL_MSAA_FLAG_PERSAMPLE_DISPATCH)) {
fs_msaa_flags |= INTEL_MSAA_FLAG_COARSE_PI_MSG |
INTEL_MSAA_FLAG_COARSE_RT_WRITES;
}
if (dyn->ms.alpha_to_coverage_enable)
fs_msaa_flags |= INTEL_MSAA_FLAG_ALPHA_TO_COVERAGE;
enum intel_msaa_flags fs_msaa_flags =
intel_fs_msaa_flags((struct intel_fs_params) {
.shader_sample_shading = wm_prog_data->sample_shading,
.shader_min_sample_shading = pipeline->min_sample_shading,
.state_sample_shading = pipeline->sample_shading_enable,
.rasterization_samples = dyn->ms.rasterization_samples,
.coarse_pixel = !vk_fragment_shading_rate_is_disabled(&dyn->fsr),
.alpha_to_coverage = dyn->ms.alpha_to_coverage_enable,
});
SET(FS_MSAA_FLAGS, fs_msaa_flags, fs_msaa_flags);
}