AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mesa: Remove unnecessary and incorrect TexEnv parameter validation.

Browse Source 
For GL_RGB_SCALE and GL_ALPHA_SCALE targets, the API wrapper code
attempts to ensure the parameter is 1.0, 2.0, or 4.0.

This is unnecessary: set_combiner_scale in texenv.c (called by
_mesa_TexEnvfv) already checks this and raises an appropriate error.

It's also incorrect: For glTexEnvx, the API validation code directly
compares the GLfixed input parameter with a floating point constant,
prior to converting fixed-point to floating point.

Fixes an issue in the OpenGL ES 1.1 conformance suite.

Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
This commit is contained in:
Kenneth Graunke
2011-10-17 16:41:57 -07:00
parent 00ddc7ea47
commit 7a86bf816c
1 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/mesa/main/APIspec.xml
-6
View File
@@ -631,12 +631,6 @@
<desc name="pname">
<value name="GL_RGB_SCALE"/>
<value name="GL_ALPHA_SCALE"/>
<desc name="param" convert="true" error="GL_INVALID_VALUE">
<value name="1.0"/>
<value name="2.0"/>
<value name="4.0"/>
</desc>
</desc>
<desc name="pname">