AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nir/lower_wrmasks: drop callback

Browse Source 
All drivers use the same callback and it is unlikely that new drivers will use
this pass since it has better replacements today (lower_mem_bit_sizes for
memory, and it never worked for I/O). This should discourage as much.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Marek Olšák <maraeo@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38533>
This commit is contained in:
Alyssa Rosenzweig
2025-11-19 10:39:50 -05:00
committed by Marge Bot
parent 5515160b55
commit 2c2dd835af
5 changed files with 9 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/broadcom/compiler/vir.c
+1 -16
View File
@@ -1399,21 +1399,6 @@ v3d_instr_delay_cb(nir_instr *instr, void *data)
return 0;
}
static bool
should_split_wrmask(const nir_instr *instr, const void *data)
{
nir_intrinsic_instr *intr = nir_instr_as_intrinsic(instr);
switch (intr->intrinsic) {
case nir_intrinsic_store_ssbo:
case nir_intrinsic_store_shared:
case nir_intrinsic_store_global:
case nir_intrinsic_store_scratch:
return true;
default:
return false;
}
}
static nir_intrinsic_instr *
nir_instr_as_constant_ubo_load(nir_instr *inst)
{
@@ -1857,7 +1842,7 @@ v3d_attempt_compile(struct v3d_compile *c)
glsl_get_natural_size_align_bytes);
NIR_PASS(_, c->s, v3d_nir_lower_global_2x32);
NIR_PASS(_, c->s, nir_lower_wrmasks, should_split_wrmask, c->s);
NIR_PASS(_, c->s, nir_lower_wrmasks);
NIR_PASS(_, c->s, v3d_nir_lower_load_store_bitsize);
NIR_PASS(_, c->s, v3d_nir_lower_scratch);