Alejandro Piñeiro
fef9ef48dd
To avoid a scenario like this: * One blit needed the four components => XYZW filled up with 4 values * Following blit needing two components => ZW uses the previous values We detected this using the v3d driver with the arb_framebuffer_srgb-blit test, specifically: ./bin/arb_framebuffer_srgb-blit texture linear_to_srgb msaa enabled render -auto -fbo The main linear to srgb with msaa (not doing the resolve yet) blit requires the four components. At the end (after a resolve copy), the test uses glReadPixels, and internally it uses the blitter with two components, but the shader still uses lod on the texel fetch, so it gets the one used for the main blit, when it should be zero. Right now v3d works fine even with that wrong value, and I assume that any other driver too. But we can't ensure that would keep happening on the future, so let's use correct values. Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13753>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.