Asahi Lina
fdec9f9c6b
When an empty batch is submitted, nothing happens. However, this batch may have taken over writer status for some BOs which still have a pending submitted batch that hasn't finished yet. If we drop writer status at this point, two bad things happen: - We spuriously clear bo->writer_syncobj, which breaks syncing on post-facto BO exports - We break agx_sync_writer(), since we no longer know about the old writer to properly block on it. To fix this (hopefully rare) case, take advantage of bo->writer_syncobj to find the currently submitted writer batch again, and revert the writer to it. If this turns out to be common and a performance issue iterating through submitted batches for each written BO, we could implement it with two writer batch arrays instead, one for active writers and one for submitted writers... but hopefully that isn't necessary. This splits the cleanup path in agx_batch_cleanup() depending on whether the cleanup is for a reset or proper completion. Since this is only used within agx_batch.c, drop the public prototype while we're at it. Signed-off-by: Asahi Lina <lina@asahilina.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22891>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.