fdeabf4162
We clone loads for uniforms for each user, which means that each ppir_node will have its own, however an instruction may have several nodes that need to load uniforms. Currently, in this case ppir compiler will place all but one load uniforms nodes into a new instruction and create an extra mov. We can optimize that by checking whether load_uniform node in the instruction is the same as the one we are trying to insert and reuse it. It is safe to do so, because successors use pipeline register, so regalloc doesn't care about it. shader-db: total instructions in shared programs: 27808 -> 27718 (-0.32%) instructions in affected programs: 2652 -> 2562 (-3.39%) helped: 31 HURT: 0 helped stats (abs) min: 1 max: 8 x̄: 2.90 x̃: 2 helped stats (rel) min: 0.56% max: 33.33% x̄: 5.12% x̃: 4.11% 95% mean confidence interval for instructions value: -3.78 -2.03 95% mean confidence interval for instructions %-change: -7.24% -2.99% Instructions are helped. total loops in shared programs: 4 -> 4 (0.00%) loops in affected programs: 0 -> 0 helped: 0 HURT: 0 total spills in shared programs: 391 -> 390 (-0.26%) spills in affected programs: 1 -> 0 helped: 1 HURT: 0 total fills in shared programs: 1213 -> 1210 (-0.25%) fills in affected programs: 3 -> 0 helped: 1 HURT: 0 LOST: 0 GAINED: 0 Reviewed-by: Erico Nunes <nunes.erico@gmail.com> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33746>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.