fc44e708d7
Commit534a04d557optimized agx_resource_from_handle() to lazily defer assignment of a kms-ro renderonly_scanout object to an imported resource until its kms winsys handle is actually queried by a caller via agx_resource_get_handle(), to avoid unnecessary import into the DCP display controller. Only resources with bind flag PIPE_BIND_SCANOUT will get a renderonly_scanout object assigned during such queries. Problem: This prevents Mesa GBM's gbm_bo_import() function from properly importing dmabufs for direct scanout use by some Wayland compositors, e.g., GNOME mutter. gbm_bo_import() of dmabuf fd's (GBM_BO_IMPORT_FD / GBM_BO_IMPORT_FD_MODIFIER), even with GBM_BO_USE_SCANOUT flag, will not mark an imported bo with the PIPE_BIND_SCANOUT bind flag before internally assigning its KMS winsys handle via screen->resource_get_handle() -> agx_resource_get_handle(), causing silent failure of that query. Therefore gbm_bo_import() seems to return a successfully created gbm_bo with all proper properties, but gbm_bo_get_handle() and gbm_bo_get_handle_for_plane() will return invalid handles. These invalid handles cause drmAddFbXXX ioctl calls to fail, and therefore failure of direct scanout of wl_buffers. Setting PIPE_BIND_SCANOUT for a resource in agx_resource_from_handle() may retain the optimization and makes gbm_bo_get_handle[_for_plane]() work. This fixes direct scanout of fullscreen wl_surface / wl_buffers under at least GNOME mutter 48. Fixes:534a04d557("asahi: Flip kmsro around to allocate on the GPU") Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37538>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.