LingMan
fc00314085
GCC 12.2.0 warns: ../src/intel/compiler/brw_fs.cpp: In member function ‘bool fs_visitor:: split_virtual_grfs()’: ../src/intel/compiler/brw_fs.cpp:2199:10: warning: ‘void* memset(void*, int, size_t)’ specified size between 18446744071562067968 and 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=] 2199 | memset(vgrf_has_split, 0, num_vars * sizeof(*vgrf_has_split)); `num_vars` is an `int` but gets assigned the value of `this->alloc.count`, which is an `unsigned int`. Thus, `num_vars` will be negative if `this->alloc.count` is larger than int max value. Converting that negative `int` to a `size_t`, which `memset` expects, then blows it up to a huge positive value. Simply turning `num_vars` into an `unsigned int` would be enough to fix this specific problem, but there are many other instances where an `unsigned int` gets assigned to an `int` for no good reason in this function. Some of which the compiler warns about now, some of which it doesn't warn about. This turns all variables in `fs_visitor::split_virtual_grfs`, which should reasonably be unsigned, into `unsigned int`s. While at it, a few now pointless casts are removed. Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19423>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.