Alyssa Rosenzweig
f625c5a8a0
Unify the "create regular resource" and "create scanout resource" code paths. They only differ in how the backing memory is allocated. This unifies the layout code as well, avoiding hacks for AFBC. What I really care about is that, if we're creating the resource, we choose the layout first with pan_image_layout_init and allocate that layout. pan_image_layout_init is a common, extensively tested (including unit tested) helper written for correctness with a deep understanding of the hardware. By contrast, we currently guess the layout with some hacks specific to AFBC, allocate our guess, and then then tell pan_image_layout_init to use the layout we guessed and pray everything works out. (It does work out, but it's all kinds of wrong, in terms of layering violation. If that really is the way to go, I can add the required routines to the layout code. But that doesn't seem right.) All of this is motivated by extending the layout code to handle AFBC with other superblock sizes or tiled headers without having to pile on extra hacks in this WSI path. Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16334>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.