Nanley Chery
f53638fa1a
Add support for using BLORP's ambiguate pass to initialize MCS instead of mapping and memsetting it on the CPU. Note that this won't be used if the first operation on the MSAA layer is a fast clear. Since we're no longer mapping, this removes a blocker towards getting MCS_CCS enabled in small-BAR mode. This functionality is difficult to test because of the way iris is set up. It always tries to compress writes. So, a test would only read the ambiguated MCS element if it tries to read from undefined samples. To test this, I locally disabled fast clears and rendering with MCS (via iris_resource_render_aux_usage). I continued to allow sampling with MCS in iris_resource_texture_aux_usage. So, writes go directly to the main surface and reads go through the ambiguated MCS surface. When I then ran the test group, dEQP-GLES3.functional.multisample.*, all 48/64 supported tests passed on my Ice Lake. If I slightly changed BLORP's ambiguate pass, I observed several tests failing. Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22545>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.