f530e72ea0
LLVMpipe always used the bounding-box to rasterize-points, rather than the actual rasterization-planes. This happened because the primitive was expanded by one unit outside the bounding box. While this kinda work for non-multisampled cases, it's not really quite *correct*. Rasterization of non-legacy points in OpenGL is defined as the intersection of a the pixel centers with a rectangle of size width and height, centered around the point in viewport coordinates. This applies both to multi-sampled and non-multisampled cases. So let's fix the rasterizer to use the correct definition in both cases. We leave the legacy case as-is, and just do the inverse adjustment there so the end result should be the same. This fixes the following dEQP test-cases: - dEQP-GLES3.functional.rasterization.fbo.rbo_multisample_4.primitives.points - dEQP-GLES3.functional.rasterization.fbo.rbo_multisample_max.primitives.points ...as well as this one for Lavapipe: - dEQP-VK.rasterization.primitives_multisample_4_bit.no_stipple.points Reviewed-by: Roland Scheidegger <sroland@vmware.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11183>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.