Alejandro Piñeiro
f2236065b7
Specifically to use the common vk_dynamic_graphics_state. The advantage of using the common struct is not only reducing the size of our custom one, but also using common helpers (like all those cmd buffer setters), and a lot of the logic that in the future will be used for other extensions. Some notes: * We still keep dirty flags, for things like PIPELINE, DESCRIPTOR_SETS, etc. Other driver do the same. FWIW, this is also an improvement, as before we were mixing those with the per-spec Vulkan dynamic info. * For the port viewport/scissor we still keep some data on a custom structure, as we cache the translate/scale info that is derived from scissor/viewport, but used in three different places. For that we also maintain a custom implementation of CmdSetViewport, that computes translate/scale, and call the common implementation. * We make the same for color_write_enables. The vulkan runtime saves it as a 8-bit bitset, with a bit per attachment. But when combining with color_write_mask you need a 32bit with 4 bits set per attachment. To avoid recompute it during emission, we also cache the color_write_enables, using the runtime just to track the dirty status. Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27609>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.