Alyssa Rosenzweig
f0fb8d05e3
Add a pass for bounds checking UBOs, SSBOs, and images to implement robustness. This pass is based on v3d_nir_lower_robust_access.c, with significant modifications to be appropriate for common code. Notably: * v3d-isms are removed. * Stop generating invalid imageSize() instructions for cube maps, this blows up nir_validate with asahi's lowerings. * Logic to wrap an intrinsic in an if-statement is extracted in anticipation of future robustness2 support that will reuse that code path for buffers. * Misc cleanups to follow modern NIR best practice. This pass is noticeably shorter than the original v3d version. For future support of robustness2, I envision the booleans turning into tristate enums. There's a few more knobs added for Asahi's benefit. Apple hardware can do imageLoad and imageStore to non-buffer images (only). There is no support for image atomics. To handle, Asahi implements software lowering for buffer images and for image atomics. While the hardware is robust, the software paths are not. So we would like to use this pass to lower robustness for the software paths but not the hardware paths. Or maybe we want a filter callback? Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23895>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.