Timur Kristóf
f001515c87
SGPR offset is not included in the bounds check according to the ISA documentation of GFX6-7 and indeed it can trigger VM faults on OOB access. Note that ACO already doesn't use the SGPR offset on GFX6-7 for buffer loads and stores. This commit just does the same for buffer atomics. This commit mitigates a ton of VM faults that are exposed by: https://github.com/KhronosGroup/VK-GL-CTS/commit/24e75fea4b0c6031445a31528f41a65062e37265 Fossil DB stats on Hawaii (GFX7): Totals from 148 (0.24% of 61818) affected shaders: Instrs: 324004 -> 327352 (+1.03%) CodeSize: 1556468 -> 1514100 (-2.72%); split: -2.74%, +0.02% Latency: 1271480 -> 1276894 (+0.43%) InvThroughput: 396850 -> 397740 (+0.22%) VClause: 6861 -> 6858 (-0.04%) Copies: 34083 -> 37430 (+9.82%) PreVGPRs: 5705 -> 5706 (+0.02%) VALU: 147529 -> 150898 (+2.28%) SALU: 98194 -> 98172 (-0.02%) Signed-off-by: Timur Kristóf <timur.kristof@gmail.com> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38958>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.