Paulo Zanoni
ea9f19ac7b
Funcion anv_get_image_format_properties() can get called from two different Vulkan entry points: - anv_GetPhysicalDeviceImageFormatProperties2 - anv_GetPhysicalDeviceSparseImageFormatProperties2 While there is a sparse-named function aimed specifically at sparse images, you can call vkGetPhysicalDeviceImageFormatProperties2 passing sparse flags in VkPhysicalDeviceImageFormatInfo2::flags. And when that happens, we need to detect it and properly either return VK_ERROR_FORMAT_NOT_SUPPORTED or properly set props->imageFormatProperties->sampleCounts with a value that matches the sparse usage. This change affects our behavior in 3 types of cases: color MSAA cases, depth/stencil MSAA cases and atomic_emulated cases. The previous patches should have covered these cases, so everything should be passing now. v2: Rebase. v3: Reword the commit message. v4: Rebase and reword the commit message. Testcase: dEQP-VK.api.info.sparse_image_format_properties2.2d.optimal.r16g16_unorm Testcase: dEQP-VK.api.info.image_format_properties.2d.optimal.d16_unorm Testcase: dEQP-VK.api.info.image_format_properties.2d.optimal.r64_uint Reviewed-by: Iván Briano <ivan.briano@intel.com> (v1) Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35524>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.