Adam Jackson
e89e1f5049
Unlike the legacy CreateContext path, we would try to send the GLXCreateContextAttribs request regardless of whether we'd successfully created the client context state. And there's not a lot on the server side to go wrong besides BadAlloc, so if the request succeeded but the client side didn't we'd need to destroy the server context and synthesize an X error. Since that itself involves more X protocol it's tricky to get the request number right in the error, and tests and apps can notice when you get it wrong. Since we have now fixed client-side validation to generate the right errors at the right times, this patch does something simpler, we match CreateContext and fail early if the client-side setup fails. Now there's no question of what request number to use, because we haven't sent any protocol, the error is for the request as if it'd been sent. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4763 Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12006>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.