e83da2d8e3
Previously, when importing a resource with modifiers that include clear color as auxiliary data, we were mapping the clear color BO on the CPU in order to set res->aux.clear_color to the value stored there. We are generally trying to avoid CPU mapping imported buffers, because in hybrid setups, they could be from a different device, and may not be mappable. So we'd like to avoid that here. This CPU-side knowledge of the clear color is only used in a few cases: 1. Avoiding a resolve due to a partial clear with a changing clear color 2. Avoiding disabling CCS when rendering to a texture view of a resource where the only format difference is sRGB vs. linear and the clear color is 0/1. Instead of mapping the clear color BO on the CPU, we instead set a flag indicating that we don't know the clear color, and reset it to known on our first clear. In the first case, the first partial fast clear of a resource would eat an extra resolve (there is no penalty if we clear the whole resource). The second case doesn't seem that critical, as it's someone rendering to an imported BO - when the common case is to texture from it. Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11888>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.