Iago Toral Quiroga
e790c20403
The way we handle thrsw instructions is that we try to merge them back into previously scheduled instructions to fill up its delay slots. This is generally safe, because the thrsw won't happen until after the delay slots, so we are not really changing the execution order of the instructions and we just need to make sure we don't violate a few specific restrictions. If we have not managed to fill up all delay slots after doing this, then we emit as many NOPs as needed to fill them. This is to ensure that we don't schedule an instruction that needs to execute after the thread switch before the thread switch happens. However, doing this can lead to inefficient code, since some times the instructions we schedule after a thrsw are indepdent of the thrsw and could be safely executed in its delay slots. This change removes the fixed NOP emission after a thrsw to fill delay slots and instead adds code to ensure that our instruction scheduling is aware of when it is scheduling instructions in the delay slots of a previous thrsw to avoid selecting conflicting instructions. The only case were we still emit fixed NOPs is for the thread end that we emit to terminate the program after scheduling all instructions because we can't end the instruction stream before the thread end is properly executed. total instructions in shared programs: 13691004 -> 13648140 (-0.31%) instructions in affected programs: 4345951 -> 4303087 (-0.99%) helped: 19645 HURT: 652 Instructions are helped. total max-temps in shared programs: 2319317 -> 2318687 (-0.03%) max-temps in affected programs: 10510 -> 9880 (-5.99%) helped: 532 HURT: 9 Max-temps are helped. total sfu-stalls in shared programs: 31752 -> 32354 (1.90%) sfu-stalls in affected programs: 840 -> 1442 (71.67%) helped: 7 HURT: 467 Sfu-stalls are HURT. total inst-and-stalls in shared programs: 13722756 -> 13680494 (-0.31%) inst-and-stalls in affected programs: 4335590 -> 4293328 (-0.97%) helped: 19453 HURT: 758 Inst-and-stalls are helped. Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9825>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `Freenode's #dri-devel <irc://chat.freenode.net#dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.