Erik Faye-Lund
e77e4d5c17
When using 16x MSAA, we have two sample-positions on the negative boundary of the unit-square covering the pixel. This causes problems when using the default tie-breaking rule, where we miss some sample-positions when rasterizing primitives covering the entire viewport. This works fine on Bifrost and later, but this setting is ignored on those GPUs, and they assume the default (e.g MINUS_180_OUT_0_IN). Because we'd prefer for rasterization to match between Midgard and Bifrost when we can, we only apply this when we have 16x MSAA. As an added bonus, this behavior matches what the DDK does. Fixes these tests when 16x MSAA is enabled: - dEQP-GLES31.functional.texture.multisample.samples_16.use_texture_* - dEQP-GLES3.functional.multisample.fbo_max_samples.proportionality_alpha_to_coverage Reviewed-by: Eric R. Smith <eric.smith@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35184>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.